From: Mike Rapoport <rppt@kernel.org>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, david@redhat.com, lkp@intel.com
Subject: Re: [PATCH v5 0/5] mm: clean up names and parameters of memmap_init_xxxx functions
Date: Fri, 22 Jan 2021 20:12:09 +0200 [thread overview]
Message-ID: <20210122181209.GD6332@kernel.org> (raw)
In-Reply-To: <20210122135956.5946-1-bhe@redhat.com>
On Fri, Jan 22, 2021 at 09:59:51PM +0800, Baoquan He wrote:
> This patchset is correcting inappropriate function names of
> memmap_init_xxx, and simplify parameters of functions in the code flow.
> And also fix a prototype warning reported by lkp.
>
> This is based on the latest next/master.
>
> V4 can be found here:
> https://lore.kernel.org/linux-mm/20210120045213.6571-1-bhe@redhat.com/
>
> v4->v5:
> - Add patch 1 into series which fixes a prototype warning from kernel
> test robot. Then rebase the v4 patches on top of it.
>
> v3->v4:
> - Rebased patch 1, 2 on top of Mike's below new patch.
> [PATCH v3 0/2] mm: fix initialization of struct page for holes in memory layout
>
> - Move the code of renaming function parameter 'range_start_pfn' and local
> variable 'range_end_pfn' of memmap_init() from patch 1 to patch 2
> according to David's comment.
>
> - Use the reverse Christmas tree style to reorder the local variables
> in memmap_init_zone() in patch 2 accodrding to David's comment.
>
> Baoquan He (5):
> mm: fix prototype warning from kernel test robot
> mm: rename memmap_init() and memmap_init_zone()
> mm: simplify parater of function memmap_init_zone()
> mm: simplify parameter of setup_usemap()
> mm: remove unneeded local variable in free_area_init_core
For the series:
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
>
> arch/ia64/include/asm/pgtable.h | 6 -----
> arch/ia64/mm/init.c | 14 +++++-----
> include/linux/mm.h | 3 ++-
> mm/memory_hotplug.c | 2 +-
> mm/page_alloc.c | 46 ++++++++++++++-------------------
> 5 files changed, 31 insertions(+), 40 deletions(-)
>
> --
> 2.17.2
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2021-01-22 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 13:59 [PATCH v5 0/5] mm: clean up names and parameters of memmap_init_xxxx functions Baoquan He
2021-01-22 13:59 ` [PATCH v5 1/5] mm: fix prototype warning from kernel test robot Baoquan He
2021-01-22 15:38 ` David Hildenbrand
2021-01-22 13:59 ` [PATCH v5 2/5] mm: rename memmap_init() and memmap_init_zone() Baoquan He
2021-01-22 15:38 ` David Hildenbrand
2021-01-22 13:59 ` [PATCH v5 3/5] mm: simplify parater of function memmap_init_zone() Baoquan He
2021-01-22 15:39 ` David Hildenbrand
2021-01-22 13:59 ` [PATCH v5 4/5] mm: simplify parameter of setup_usemap() Baoquan He
2021-01-22 13:59 ` [PATCH v5 5/5] mm: remove unneeded local variable in free_area_init_core Baoquan He
2021-01-22 18:12 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122181209.GD6332@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).