From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44623C433E6 for ; Thu, 28 Jan 2021 07:05:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE57164DD9 for ; Thu, 28 Jan 2021 07:05:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE57164DD9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A8FFB8D0001; Thu, 28 Jan 2021 02:04:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A1DAB6B0095; Thu, 28 Jan 2021 02:04:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77FF58D0001; Thu, 28 Jan 2021 02:04:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 5A6916B0093 for ; Thu, 28 Jan 2021 02:04:56 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 233CC1F06 for ; Thu, 28 Jan 2021 07:04:56 +0000 (UTC) X-FDA: 77754296592.13.help65_4a159472759d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 0620B18140B60 for ; Thu, 28 Jan 2021 07:04:55 +0000 (UTC) X-HE-Tag: help65_4a159472759d X-Filterd-Recvd-Size: 4841 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 07:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=VNAFKxZrqabv/yx6V4SaNA8WzUebWhfbbMRyhZjeU8A=; b=RGxhwhYO9p+7/a9E3aTKRtC9U3 lz229sH7y7t4kUKhqPra6HgP1BNqDxxmBEL79+uW5puxH/eTaDr8aGZaKUava8sdBV2cILuK6Tm1l 9S1lRUpA80hMB0wNlBbJWas7S4TC4q+vpUsj83FfJMbesbrjccevO0se1p4avb5uCYmnh2+5SrJdU V17hXLlHlYB6e26QbSz3oY+I+FS0PEMDHqMXLMBwB/nLOQFUC5Hyv6SBVNWgDl5ucp1zPKRABMZ6A 0EIS3QBONNRYwWCzejcHTpapc7VuEIu7c6IxsHEntAgHiUx/5iRsOhbtfA4vS9lVENg8cwBfGQvt8 12QJMtLg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l51MK-00848r-A6; Thu, 28 Jan 2021 07:04:52 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Subject: [PATCH v3 23/25] mm: Convert test_clear_page_writeback to test_clear_folio_writeback Date: Thu, 28 Jan 2021 07:04:02 +0000 Message-Id: <20210128070404.1922318-24-willy@infradead.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210128070404.1922318-1-willy@infradead.org> References: <20210128070404.1922318-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The one caller of test_clear_page_writeback() already has a folio, so mak= e it clear that test_clear_page_writeback() operates on the entire folio. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/page-flags.h | 2 +- mm/filemap.c | 2 +- mm/page-writeback.c | 18 +++++++++--------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 90381858d901..01aa4a71bf14 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -594,7 +594,7 @@ static __always_inline void SetPageUptodate(struct pa= ge *page) =20 CLEARPAGEFLAG(Uptodate, uptodate, PF_NO_TAIL) =20 -int test_clear_page_writeback(struct page *page); +int test_clear_folio_writeback(struct folio *folio); int __test_set_page_writeback(struct page *page, bool keep_write); =20 #define test_set_page_writeback(page) \ diff --git a/mm/filemap.c b/mm/filemap.c index 906b29c3e1fb..a00030b2ef71 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1463,7 +1463,7 @@ void end_folio_writeback(struct folio *folio) * reused before the wake_up_folio(). */ get_folio(folio); - if (!test_clear_page_writeback(&folio->page)) + if (!test_clear_folio_writeback(folio)) BUG(); =20 smp_mb__after_atomic(); diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 908fc7f60ae7..db8a99e4a3d2 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2719,24 +2719,24 @@ int clear_page_dirty_for_io(struct page *page) } EXPORT_SYMBOL(clear_page_dirty_for_io); =20 -int test_clear_page_writeback(struct page *page) +int test_clear_folio_writeback(struct folio *folio) { - struct address_space *mapping =3D page_mapping(page); + struct address_space *mapping =3D folio_mapping(folio); struct mem_cgroup *memcg; struct lruvec *lruvec; int ret; =20 - memcg =3D lock_page_memcg(page); - lruvec =3D mem_cgroup_page_lruvec(page, page_pgdat(page)); + memcg =3D lock_folio_memcg(folio); + lruvec =3D mem_cgroup_folio_lruvec(folio, folio_pgdat(folio)); if (mapping && mapping_use_writeback_tags(mapping)) { struct inode *inode =3D mapping->host; struct backing_dev_info *bdi =3D inode_to_bdi(inode); unsigned long flags; =20 xa_lock_irqsave(&mapping->i_pages, flags); - ret =3D TestClearPageWriteback(page); + ret =3D TestClearFolioWriteback(folio); if (ret) { - __xa_clear_mark(&mapping->i_pages, page_index(page), + __xa_clear_mark(&mapping->i_pages, folio_index(folio), PAGECACHE_TAG_WRITEBACK); if (bdi->capabilities & BDI_CAP_WRITEBACK_ACCT) { struct bdi_writeback *wb =3D inode_to_wb(inode); @@ -2752,12 +2752,12 @@ int test_clear_page_writeback(struct page *page) =20 xa_unlock_irqrestore(&mapping->i_pages, flags); } else { - ret =3D TestClearPageWriteback(page); + ret =3D TestClearFolioWriteback(folio); } if (ret) { dec_lruvec_state(lruvec, NR_WRITEBACK); - dec_zone_page_state(page, NR_ZONE_WRITE_PENDING); - inc_node_page_state(page, NR_WRITTEN); + dec_zone_folio_stat(folio, NR_ZONE_WRITE_PENDING); + inc_node_folio_stat(folio, NR_WRITTEN); } __unlock_page_memcg(memcg); return ret; --=20 2.29.2