linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 04/25] mm/debug: Add VM_BUG_ON_FOLIO and VM_WARN_ON_ONCE_FOLIO
Date: Thu, 28 Jan 2021 07:03:43 +0000	[thread overview]
Message-ID: <20210128070404.1922318-5-willy@infradead.org> (raw)
In-Reply-To: <20210128070404.1922318-1-willy@infradead.org>

These are the folio equivalents of VM_BUG_ON_PAGE and VM_WARN_ON_ONCE_PAGE.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 include/linux/mmdebug.h | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 5d0767cb424a..77d24e1dcaec 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -23,6 +23,13 @@ void dump_mm(const struct mm_struct *mm);
 			BUG();						\
 		}							\
 	} while (0)
+#define VM_BUG_ON_FOLIO(cond, folio)					\
+	do {								\
+		if (unlikely(cond)) {					\
+			dump_page(&folio->page, "VM_BUG_ON_FOLIO(" __stringify(cond)")");\
+			BUG();						\
+		}							\
+	} while (0)
 #define VM_BUG_ON_VMA(cond, vma)					\
 	do {								\
 		if (unlikely(cond)) {					\
@@ -48,6 +55,17 @@ void dump_mm(const struct mm_struct *mm);
 	}								\
 	unlikely(__ret_warn_once);					\
 })
+#define VM_WARN_ON_ONCE_FOLIO(cond, folio)	({			\
+	static bool __section(".data.once") __warned;			\
+	int __ret_warn_once = !!(cond);					\
+									\
+	if (unlikely(__ret_warn_once && !__warned)) {			\
+		dump_page(&folio->page, "VM_WARN_ON_ONCE_FOLIO(" __stringify(cond)")");\
+		__warned = true;					\
+		WARN_ON(1);						\
+	}								\
+	unlikely(__ret_warn_once);					\
+})
 
 #define VM_WARN_ON(cond) (void)WARN_ON(cond)
 #define VM_WARN_ON_ONCE(cond) (void)WARN_ON_ONCE(cond)
@@ -56,11 +74,13 @@ void dump_mm(const struct mm_struct *mm);
 #else
 #define VM_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond)
 #define VM_BUG_ON_PAGE(cond, page) VM_BUG_ON(cond)
+#define VM_BUG_ON_FOLIO(cond, folio) VM_BUG_ON(cond)
 #define VM_BUG_ON_VMA(cond, vma) VM_BUG_ON(cond)
 #define VM_BUG_ON_MM(cond, mm) VM_BUG_ON(cond)
 #define VM_WARN_ON(cond) BUILD_BUG_ON_INVALID(cond)
 #define VM_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond)
 #define VM_WARN_ON_ONCE_PAGE(cond, page)  BUILD_BUG_ON_INVALID(cond)
+#define VM_WARN_ON_ONCE_FOLIO(cond, folio)  BUILD_BUG_ON_INVALID(cond)
 #define VM_WARN_ONCE(cond, format...) BUILD_BUG_ON_INVALID(cond)
 #define VM_WARN(cond, format...) BUILD_BUG_ON_INVALID(cond)
 #endif
-- 
2.29.2



  parent reply	other threads:[~2021-01-28  7:04 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28  7:03 [PATCH v3 00/25] Page folios Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 01/25] mm: Introduce struct folio Matthew Wilcox (Oracle)
2021-03-01 20:26   ` Zi Yan
2021-03-01 20:53     ` Matthew Wilcox
2021-03-01 21:03       ` Zi Yan
2021-01-28  7:03 ` [PATCH v3 02/25] mm: Add folio_pgdat Matthew Wilcox (Oracle)
2021-03-01 21:05   ` Zi Yan
2021-01-28  7:03 ` [PATCH v3 03/25] mm/vmstat: Add folio stat wrappers Matthew Wilcox (Oracle)
2021-03-01 21:17   ` Zi Yan
2021-03-01 22:15     ` Matthew Wilcox
2021-01-28  7:03 ` Matthew Wilcox (Oracle) [this message]
2021-03-01 21:25   ` [PATCH v3 04/25] mm/debug: Add VM_BUG_ON_FOLIO and VM_WARN_ON_ONCE_FOLIO Zi Yan
2021-01-28  7:03 ` [PATCH v3 05/25] mm: Add put_folio Matthew Wilcox (Oracle)
2021-03-01 21:41   ` Zi Yan
2021-01-28  7:03 ` [PATCH v3 06/25] mm: Add get_folio Matthew Wilcox (Oracle)
2021-03-01 21:45   ` Zi Yan
2021-01-28  7:03 ` [PATCH v3 07/25] mm: Create FolioFlags Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 08/25] mm: Handle per-folio private data Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 09/25] mm: Add folio_index, folio_page and folio_contains Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 10/25] mm/util: Add folio_mapping and folio_file_mapping Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 11/25] mm/memcg: Add folio_memcg, lock_folio_memcg and unlock_folio_memcg Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 12/25] mm/memcg: Add mem_cgroup_folio_lruvec Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 13/25] mm: Add unlock_folio Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 14/25] mm: Add lock_folio Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 15/25] mm: Add lock_folio_killable Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 16/25] mm: Convert lock_page_async to lock_folio_async Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 17/25] mm/filemap: Convert end_page_writeback to end_folio_writeback Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 18/25] mm: Convert wait_on_page_bit to wait_on_folio_bit Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 19/25] mm: Add wait_for_stable_folio and wait_on_folio_writeback Matthew Wilcox (Oracle)
2021-01-28  7:03 ` [PATCH v3 20/25] mm: Add wait_on_folio_locked & wait_on_folio_locked_killable Matthew Wilcox (Oracle)
2021-01-28  7:04 ` [PATCH v3 21/25] mm: Convert lock_page_or_retry to lock_folio_or_retry Matthew Wilcox (Oracle)
2021-01-28  7:04 ` [PATCH v3 22/25] mm/filemap: Convert wake_up_page_bit to wake_up_folio_bit Matthew Wilcox (Oracle)
2021-01-28  7:04 ` [PATCH v3 23/25] mm: Convert test_clear_page_writeback to test_clear_folio_writeback Matthew Wilcox (Oracle)
2021-01-28  7:04 ` [PATCH v3 24/25] mm/filemap: Convert page wait queues to be folios Matthew Wilcox (Oracle)
2021-01-28  7:04 ` [PATCH v3 25/25] cachefiles: Switch to wait_page_key Matthew Wilcox (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128070404.1922318-5-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).