From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E68C433DB for ; Thu, 28 Jan 2021 07:12:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9322D64DDA for ; Thu, 28 Jan 2021 07:12:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9322D64DDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 218816B0078; Thu, 28 Jan 2021 02:12:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C7F86B007B; Thu, 28 Jan 2021 02:12:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08F336B007D; Thu, 28 Jan 2021 02:12:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id E44396B0078 for ; Thu, 28 Jan 2021 02:11:59 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A5512181AC9BF for ; Thu, 28 Jan 2021 07:11:59 +0000 (UTC) X-FDA: 77754314358.26.heat75_0703af82759d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 77CE01804B65C for ; Thu, 28 Jan 2021 07:11:59 +0000 (UTC) X-HE-Tag: heat75_0703af82759d X-Filterd-Recvd-Size: 6648 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 07:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1611817918; x=1643353918; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1Q7huJyMDOVynURh2o3jolV4xRilOq3cl8xkF29/liU=; b=U+cC16W/Y6rD6CKWD76T1+MSeGGxh7IGRgV/A/1UujQdP5WxIL5Dgom6 c70i/H2LgI2Ir6aeXOHEMWa9cL8/WI7sRlx+2kDPqLF0KVYcGzdg+ei1H EyO/ed7YrSmIfN2wpMXgvFpD2xVtCOfKgeoxXR1k73Dfxuv2vUh7gpHXf 6mZiel/GuYrHgqIbIw0P/4QGjlUuFdIT+yTg9Kj3pgCaavPzsiKEPx5vS hlnImhuMQjLxbMK+0d1pnVCNA16aQnkCIBoFXQq0aThQ/IyYaexCTZ3ct 66b3eT0i7ZP8tSxt6Y0Ob3NA/58Q/UZts14XoIHG8NvIZkKFdFpbgAOyP A==; IronPort-SDR: Mt2cz5r/c15Qcx8q2JVPXPSTbE9ePu2Q4Isk3Cd2Ar5ibn7ppo4Ec7Rczx/PGvJTYWqpUbXXe0 xguRImpEvvYUl4Vv9uogiQ0lyEuJbf3TOEwKtaJrvWD1Q++ROtv+kolo7LtZpuAtvkjPrpxCqv XAUmx6NGOjJX04ae61LImYpJgyZ5cViGgv0kKmyvpvn1K3yq6INdcrXQhrbofLi68BWLp6MLmy PzdwkikfR0gSoJwcY/OmSA3p83rKzwLfnIO6vdborT1l2SfgzHxXC3WiuNNWajy5nAPrl7Q6rI 3hE= X-IronPort-AV: E=Sophos;i="5.79,381,1602518400"; d="scan'208";a="158517994" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Jan 2021 15:11:57 +0800 IronPort-SDR: HtBuIYRGChnvhUJh1zbP2ISMEuQoXK4EQrt29gDUyuM+f3B+gnRi21iLib8nl8jbeI4hQ2S69s G9w4rWXaNrd2FwByeLF90UHUyP7wf0Hx8Ogodq1+f9LscdpiCz0BYouBA0UFsKyxUhNdYKJ7SF SrIOgr7Lyl9P/jpA3haBCQVhAZgt0z4HjWqjCX/UdQt5HxpMizbxAzpC5mwQGugwRbjWprJhTx PqYJ6hlNDM0Iad95gK1lQHNcRQgZcM8VlB9jepMFKrE65KgfhUp4ZnqrJWADogcCYtaPqFq3uF /Jopj6/D7uAILbV6TTValpBu Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 22:54:15 -0800 IronPort-SDR: HYKG8+pmcZ9KZ4KZ0ijEvKFdi7W0dgGDXHFsWIaWNxW3zaOZulAuYVmKBU97gor6eDg6ylP5Ni 6/ahnxe6yM79ewZwsqKvrfMjvqQiAhLVOYCtlxS8Bh1Gz/vhwXPlVRnl4SwtLQD680yYKL86EL o3y724i0cbqHM9ChTIb0swq0MYuYoJx+iwqVjQ/XkVzNSKEtJ8uwRbdybmRUPVMHWHGtPAl98+ IjNd0sVxBZiY+I2eDgAQpiJ9r1dqmBNoZAqnfBCkqleNy/DSVZGKQaXDO89s0wR1FlZS/ZCSSd 5w0= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip02.wdc.com with ESMTP; 27 Jan 2021 23:11:57 -0800 From: Chaitanya Kulkarni To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fscrypt@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org Cc: axboe@kernel.dk, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, konrad.wilk@oracle.com, roger.pau@citrix.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, agk@redhat.com, snitzer@redhat.com, hch@lst.de, sagi@grimberg.me, chaitanya.kulkarni@wdc.com, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, tytso@mit.edu, jaegeuk@kernel.org, ebiggers@kernel.org, djwong@kernel.org, shaggy@kernel.org, konishi.ryusuke@gmail.com, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, damien.lemoal@wdc.com, naohiro.aota@wdc.com, jth@kernel.org, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, akpm@linux-foundation.org, hare@suse.de, gustavoars@kernel.org, tiwai@suse.de, alex.shi@linux.alibaba.com, asml.silence@gmail.com, ming.lei@redhat.com, tj@kernel.org, osandov@fb.com, bvanassche@acm.org, jefflexu@linux.alibaba.com Subject: [RFC PATCH 02/34] block: introduce and use bio_new Date: Wed, 27 Jan 2021 23:11:01 -0800 Message-Id: <20210128071133.60335-3-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1 In-Reply-To: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Introduce bio_new() helper and use it in blk-lib.c to allocate and initialize various non-optional or semi-optional members of the bio along with bio allocation done with bio_alloc(). Here we also calmp the max_bvecs for bio with BIO_MAX_PAGES before we pass to bio_alloc(). Signed-off-by: Chaitanya Kulkarni --- block/blk-lib.c | 6 +----- include/linux/bio.h | 25 +++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index fb486a0bdb58..ec29415f00dd 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -14,17 +14,13 @@ struct bio *blk_next_bio(struct bio *bio, struct bloc= k_device *bdev, sector_t sect, unsigned op, unsigned opf, unsigned int nr_pages, gfp_t gfp) { - struct bio *new =3D bio_alloc(gfp, nr_pages); + struct bio *new =3D bio_new(bdev, sect, op, opf, gfp, nr_pages); =20 if (bio) { bio_chain(bio, new); submit_bio(bio); } =20 - new->bi_iter.bi_sector =3D sect; - bio_set_dev(new, bdev); - bio_set_op_attrs(new, op, opf); - return new; } =20 diff --git a/include/linux/bio.h b/include/linux/bio.h index c74857cf1252..2a09ba100546 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -826,5 +826,30 @@ static inline void bio_set_polled(struct bio *bio, s= truct kiocb *kiocb) if (!is_sync_kiocb(kiocb)) bio->bi_opf |=3D REQ_NOWAIT; } +/** + * bio_new - allcate and initialize new bio + * @bdev: blockdev to issue discard for + * @sector: start sector + * @op: REQ_OP_XXX from enum req_opf + * @op_flags: REQ_XXX from enum req_flag_bits + * @max_bvecs: maximum bvec to be allocated for this bio + * @gfp_mask: memory allocation flags (for bio_alloc) + * + * Description: + * Allocates, initializes common members, and returns a new bio. + */ +static inline struct bio *bio_new(struct block_device *bdev, sector_t se= ctor, + unsigned int op, unsigned int op_flags, + unsigned int max_bvecs, gfp_t gfp_mask) +{ + unsigned nr_bvec =3D clamp_t(unsigned int, max_bvecs, 0, BIO_MAX_PAGES)= ; + struct bio *bio =3D bio_alloc(gfp_mask, nr_bvec); + + bio_set_dev(bio, bdev); + bio->bi_iter.bi_sector =3D sector; + bio_set_op_attrs(bio, op, op_flags); + + return bio; +} =20 #endif /* __LINUX_BIO_H */ --=20 2.22.1