From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE29DC433E6 for ; Thu, 28 Jan 2021 07:12:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 81EFA64DCE for ; Thu, 28 Jan 2021 07:12:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81EFA64DCE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1EFA46B0074; Thu, 28 Jan 2021 02:12:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A80E6B0081; Thu, 28 Jan 2021 02:12:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 065F86B0082; Thu, 28 Jan 2021 02:12:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id E391D6B0074 for ; Thu, 28 Jan 2021 02:12:47 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B213C181AEF1F for ; Thu, 28 Jan 2021 07:12:47 +0000 (UTC) X-FDA: 77754316374.06.bear11_30061e82759d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 8F7EF10049850 for ; Thu, 28 Jan 2021 07:12:47 +0000 (UTC) X-HE-Tag: bear11_30061e82759d X-Filterd-Recvd-Size: 8132 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 07:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1611817966; x=1643353966; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=A6gWT2+anXyYq2Hv6qVI+iojoFiSM9Vb51ZpjBpkhPc=; b=bOHtMxkTG2v+CHUqITtmmBl473wU24AkhqG09BYDpak6cAG94rrx0HEu ygQSLZQHju3OQIDmFhcYEBiMbmgSGn4OjSLrXF3MKrbbGxgINSWlGUppJ VH1CVIq4yjXNpWckT+9nQuAEnlaz5Xa37r8ubk3ZaPsqweXW1s5aYwdRZ l+QhxF0aJj9JF9jE4NVLH9Wunqi7AQi2WK7fJmJRam2pysqyXzxn6bJc/ CzgMHGuXls6Q6JF+zURa8dCUb/9CA2sURwO3Dg53nmnfHL88lA9uppPKP FaR1TTRsXoq0V86cQkCySb1NPEKHpNo76dM6TyJC+WPR2z3NZMNOWrr2x w==; IronPort-SDR: Zj0BsuSYOwCfUH3plftuu777m4H3A698xjxGczOIWX39SQFZgsgTE6isOJ12QU1QjAFzhy0W2o AXNAkNhaP2NKyUkOj7iBHlqPLjMAG29gUSGY/aZJCTd7XpjhhkyH2jnBeeaSaAHhCyAW3eW/B4 vmDxrZKLFZWlQxUBlBa4/BSeGbMZxPSJXhbqxc5/4EqIIhoDw3qFubKR+DJxX6fqrbdEdo/H4o wo7cWBcY6DKNiuxcncVSeq8Z5TIkCUXuyAYpaC9+pdZVGNPFzz8xH7u8NIFo1QrK09FH/bvzQN 69Y= X-IronPort-AV: E=Sophos;i="5.79,381,1602518400"; d="scan'208";a="158518106" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 28 Jan 2021 15:12:45 +0800 IronPort-SDR: ec0IP7thZQ3EKUUUhrg6fkao7FUn/Rqvznn6GXGluYSHqIutNkCKRhPxUF+aEfLs8A1BNIJ05x OeAg+Uy33u1OfSFOaREheBChtJumHLrVkniNjNZFPNx0DczkcZDMCuj9stmDqrQCwAvevfGdc7 clTVNSSJCxqKLx9ju9FulVBMxJXl1n6anUytrzJ00BKREsvBpg8Usyhnx+as0MXglfgRB7dUkA YspNfXBm8GO3f0Cp3jah4YMG8ZpigQcEiLuQLLDs44xrBk5D16Mcz5hxWylwmLuCW7nSrXcNp4 cBnili6MmMLmenoefulT6+2k Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 22:57:05 -0800 IronPort-SDR: iX0HhBu+61xFa7EtRWB17G0RFoDdFxtABLHP5yHe733z1qMOeQszsqPYXIq64MFQkReY48/RWk FOClHc2dhNxuRM1QyLpF0KtQrhnCpVvcpPgq0B9OecXrJpCL8UYdCuDWFTL9LdxFS6qWHXh51B DNrP6xQEwjJPm/GL/W/Mv5XtvThzXYCRCRRzvICfBStun4/LN576oOtiFYHwzWMShhTX3BjqKf c8icNJold/1bdh3xf4xqkQcFwP0TJ4M2AqZVo41MRst8Lsv9bfR6qeue7iMnlhLF3vJJuSRBwu WXg= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip02.wdc.com with ESMTP; 27 Jan 2021 23:12:45 -0800 From: Chaitanya Kulkarni To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fscrypt@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org Cc: axboe@kernel.dk, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, konrad.wilk@oracle.com, roger.pau@citrix.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, agk@redhat.com, snitzer@redhat.com, hch@lst.de, sagi@grimberg.me, chaitanya.kulkarni@wdc.com, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, tytso@mit.edu, jaegeuk@kernel.org, ebiggers@kernel.org, djwong@kernel.org, shaggy@kernel.org, konishi.ryusuke@gmail.com, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, damien.lemoal@wdc.com, naohiro.aota@wdc.com, jth@kernel.org, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, akpm@linux-foundation.org, hare@suse.de, gustavoars@kernel.org, tiwai@suse.de, alex.shi@linux.alibaba.com, asml.silence@gmail.com, ming.lei@redhat.com, tj@kernel.org, osandov@fb.com, bvanassche@acm.org, jefflexu@linux.alibaba.com Subject: [RFC PATCH 07/34] dm: use bio_new in dm-log-writes Date: Wed, 27 Jan 2021 23:11:06 -0800 Message-Id: <20210128071133.60335-8-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1 In-Reply-To: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-log-writes.c | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c index e3d35c6c9f71..7ca9af407647 100644 --- a/drivers/md/dm-log-writes.c +++ b/drivers/md/dm-log-writes.c @@ -217,18 +217,15 @@ static int write_metadata(struct log_writes_c *lc, = void *entry, void *ptr; size_t ret; =20 - bio =3D bio_alloc(GFP_KERNEL, 1); + bio =3D bio_new(lc->logdev->bdev, sector, REQ_OP_WRITE, 0, 1, GFP_KERNE= L); if (!bio) { DMERR("Couldn't alloc log bio"); goto error; } bio->bi_iter.bi_size =3D 0; - bio->bi_iter.bi_sector =3D sector; - bio_set_dev(bio, lc->logdev->bdev); bio->bi_end_io =3D (sector =3D=3D WRITE_LOG_SUPER_SECTOR) ? log_end_super : log_end_io; bio->bi_private =3D lc; - bio_set_op_attrs(bio, REQ_OP_WRITE, 0); =20 page =3D alloc_page(GFP_KERNEL); if (!page) { @@ -264,7 +261,7 @@ static int write_inline_data(struct log_writes_c *lc,= void *entry, size_t entrylen, void *data, size_t datalen, sector_t sector) { - int num_pages, bio_pages, pg_datalen, pg_sectorlen, i; + int num_pages, pg_datalen, pg_sectorlen, i; struct page *page; struct bio *bio; size_t ret; @@ -272,24 +269,21 @@ static int write_inline_data(struct log_writes_c *l= c, void *entry, =20 while (datalen) { num_pages =3D ALIGN(datalen, PAGE_SIZE) >> PAGE_SHIFT; - bio_pages =3D min(num_pages, BIO_MAX_PAGES); =20 atomic_inc(&lc->io_blocks); =20 - bio =3D bio_alloc(GFP_KERNEL, bio_pages); + bio =3D bio_new(lc->logdev->bdev, sector, REQ_OP_WRITE, 0, + num_pages, GFP_KERNEL); if (!bio) { DMERR("Couldn't alloc inline data bio"); goto error; } =20 bio->bi_iter.bi_size =3D 0; - bio->bi_iter.bi_sector =3D sector; - bio_set_dev(bio, lc->logdev->bdev); bio->bi_end_io =3D log_end_io; bio->bi_private =3D lc; - bio_set_op_attrs(bio, REQ_OP_WRITE, 0); =20 - for (i =3D 0; i < bio_pages; i++) { + for (i =3D 0; i < bio->bi_max_vecs; i++) { pg_datalen =3D min_t(int, datalen, PAGE_SIZE); pg_sectorlen =3D ALIGN(pg_datalen, lc->sectorsize); =20 @@ -317,7 +311,7 @@ static int write_inline_data(struct log_writes_c *lc,= void *entry, } submit_bio(bio); =20 - sector +=3D bio_pages * PAGE_SECTORS; + sector +=3D bio->bi_max_vecs * PAGE_SECTORS; } return 0; error_bio: @@ -364,17 +358,15 @@ static int log_one_block(struct log_writes_c *lc, goto out; =20 atomic_inc(&lc->io_blocks); - bio =3D bio_alloc(GFP_KERNEL, min(block->vec_cnt, BIO_MAX_PAGES)); + bio =3D bio_new(lc->logdev->bdev, sector, REQ_OP_WRITE, 0, + block->vec_cnt, GFP_KERNEL); if (!bio) { DMERR("Couldn't alloc log bio"); goto error; } bio->bi_iter.bi_size =3D 0; - bio->bi_iter.bi_sector =3D sector; - bio_set_dev(bio, lc->logdev->bdev); bio->bi_end_io =3D log_end_io; bio->bi_private =3D lc; - bio_set_op_attrs(bio, REQ_OP_WRITE, 0); =20 for (i =3D 0; i < block->vec_cnt; i++) { /* @@ -386,17 +378,15 @@ static int log_one_block(struct log_writes_c *lc, if (ret !=3D block->vecs[i].bv_len) { atomic_inc(&lc->io_blocks); submit_bio(bio); - bio =3D bio_alloc(GFP_KERNEL, min(block->vec_cnt - i, BIO_MAX_PAGES))= ; + bio =3D bio_new(lc->logdev->bdev, sector, REQ_OP_WRITE, + 0, block->vec_cnt - i, GFP_KERNEL); if (!bio) { DMERR("Couldn't alloc log bio"); goto error; } bio->bi_iter.bi_size =3D 0; - bio->bi_iter.bi_sector =3D sector; - bio_set_dev(bio, lc->logdev->bdev); bio->bi_end_io =3D log_end_io; bio->bi_private =3D lc; - bio_set_op_attrs(bio, REQ_OP_WRITE, 0); =20 ret =3D bio_add_page(bio, block->vecs[i].bv_page, block->vecs[i].bv_len, 0); --=20 2.22.1