From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 111CCC433DB for ; Sat, 30 Jan 2021 02:31:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73DC164E1C for ; Sat, 30 Jan 2021 02:31:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73DC164E1C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 77A138D0002; Fri, 29 Jan 2021 21:31:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 729608D0001; Fri, 29 Jan 2021 21:31:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63F218D0002; Fri, 29 Jan 2021 21:31:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 510008D0001 for ; Fri, 29 Jan 2021 21:31:34 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 15CBB1DFF for ; Sat, 30 Jan 2021 02:31:34 +0000 (UTC) X-FDA: 77760865308.27.knot64_49024fc275ad Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id ECE1D3D663 for ; Sat, 30 Jan 2021 02:31:33 +0000 (UTC) X-HE-Tag: knot64_49024fc275ad X-Filterd-Recvd-Size: 3256 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Sat, 30 Jan 2021 02:31:33 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9DE0464E1A; Sat, 30 Jan 2021 02:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611973892; bh=cGf3iJ+ecwtb9Ubl0TlE4VdI62kqOG/SRgvcxfXZejg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Wyotr9H9B00UJUKheIXtljvx8UCaT02HI/9TZ//h3FJLuKKoSlXIoUT4dm6LRRuVv AUVjtQBdvXqMf4nJUiAd8k1d8TkppgzKPcKYBIq527jRWD3XHIy0fiJkEkxNZthJvx 3YD6JzlBY2rtZOnwnxCqjZYRG3Tp9Iz5+9HEbe3615xDxhTdjSuGf9yxlvpeK5zzmO D4fPKYi/j0h0Urv7ObZS28fLIdKiQL90fnnAcGF9W2dFqKpeV5tNQ+h8miISEY0PSP NEFeNtttgTEBEGpKv4rAQDR1NI7PhXdj4rbOefks8jgfQ61g1GQ/k+Y4dxmeqiybEk Yu2M65T9m2x7w== Date: Fri, 29 Jan 2021 18:30:51 -0800 From: Jakub Kicinski To: Andrew Morton Cc: Alexander Lobakin , "David S. Miller" , David Rientjes , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 net-next 1/4] mm: constify page_is_pfmemalloc() argument Message-ID: <20210129183051.62874a6d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210127201031.98544-2-alobakin@pm.me> References: <20210127201031.98544-1-alobakin@pm.me> <20210127201031.98544-2-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 27 Jan 2021 20:11:01 +0000 Alexander Lobakin wrote: > The function only tests for page->index, so its argument should be > const. > > Signed-off-by: Alexander Lobakin > --- > include/linux/mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index ecdf8a8cd6ae..078633d43af9 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1584,7 +1584,7 @@ struct address_space *page_mapping_file(struct page *page); > * ALLOC_NO_WATERMARKS and the low watermark was not > * met implying that the system is under some pressure. > */ > -static inline bool page_is_pfmemalloc(struct page *page) > +static inline bool page_is_pfmemalloc(const struct page *page) > { > /* > * Page index cannot be this large so this must be No objections for this going via net-next?