From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97806C433E0 for ; Mon, 1 Feb 2021 14:12:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 351E764EA2 for ; Mon, 1 Feb 2021 14:12:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 351E764EA2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8499F6B0005; Mon, 1 Feb 2021 09:12:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81FEE6B006C; Mon, 1 Feb 2021 09:12:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75CB16B0078; Mon, 1 Feb 2021 09:12:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 5CE046B0005 for ; Mon, 1 Feb 2021 09:12:34 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1A39C3633 for ; Mon, 1 Feb 2021 14:12:34 +0000 (UTC) X-FDA: 77769889428.18.skate15_3404c44275c2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id DD539100ED9C4 for ; Mon, 1 Feb 2021 14:12:33 +0000 (UTC) X-HE-Tag: skate15_3404c44275c2 X-Filterd-Recvd-Size: 2732 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 14:12:33 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2AC6364DE1; Mon, 1 Feb 2021 14:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612188752; bh=bhH1EtxkV570baZYIdO2ZQx3Qz4p1Kp0KAuVJO2Tg0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qz1IgX5S9ddahNwh/RMFVP9g2eA95R5fUDDf16jlgOlI3MsVoO4VA9seW8wX2S4KD MpLisyTUAc5Rg8lUCWrlafEFJ8DaADH5isQBfqXsOI2H7T6mMxvOwaAl14Kj72QPjt ktWG6uBPY/s+Zyx8MvJsgEkQK9APbNaEfmQCOisY1ZVDqFJAxuN2w8/cgl6+Kgn3+U v37PE2uqaT5tvwi7as8dS9lxxbVN5+bSsiLEQpmYuEYpS9jj16CqSzMP0Zv7DMJmnt CT4ZnJsv3du9axuLoOTVpKogG/QdG5AEKZ5nx/0UbPVHB6lbOJScOmlS/omikR7/Lx Lcdj/fDYJ3Qxg== Date: Mon, 1 Feb 2021 16:12:22 +0200 From: Mike Rapoport To: Baoquan He Cc: David Hildenbrand , Andrew Morton , Andrea Arcangeli , Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Mel Gorman , Michal Hocko , Mike Rapoport , Qian Cai , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v3 2/2] mm: fix initialization of struct page for holes in memory layout Message-ID: <20210201141222.GH242749@kernel.org> References: <20210111194017.22696-1-rppt@kernel.org> <20210111194017.22696-3-rppt@kernel.org> <20210201093958.GD28734@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210201093958.GD28734@MiWiFi-R3L-srv> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 01, 2021 at 05:39:58PM +0800, Baoquan He wrote: > On 02/01/21 at 10:14am, David Hildenbrand wrote: > > On 11.01.21 20:40, Mike Rapoport wrote: > > > + > > > +static void __init init_unavailable_mem(void) > > > +{ > > > + int zone; > > > + > > > + for (zone = 0; zone < ZONE_MOVABLE; zone++) > > > + init_zone_unavailable_mem(zone); > > > > Why < ZONE_MOVABLE? > > > > I remember we can have memory holes inside the movable zone when messing > > with "movablecore" cmdline parameter. > > Maybe because we haven't initialized MOABLE zone info at this time. We already have zone_movable_pfn initialized at this point. So if there is a possibility for holes in the movable zone, we should take care of it. -- Sincerely yours, Mike.