From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Kevin Hao <haokexin@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next v2 1/4] mm: page_frag: Introduce page_frag_alloc_align()
Date: Tue, 2 Feb 2021 12:31:54 +0000 [thread overview]
Message-ID: <20210202123153.tt7c6icrysrbpluc@skbuf> (raw)
In-Reply-To: <2d406568-5b1d-d941-5503-68ba2ed49f34@suse.cz>
On Tue, Feb 02, 2021 at 12:48:28PM +0100, Vlastimil Babka wrote:
> On 2/2/21 12:36 PM, Ioana Ciornei wrote:
> > On Sun, Jan 31, 2021 at 03:44:23PM +0800, Kevin Hao wrote:
> >> In the current implementation of page_frag_alloc(), it doesn't have
> >> any align guarantee for the returned buffer address. But for some
> >> hardwares they do require the DMA buffer to be aligned correctly,
> >> so we would have to use some workarounds like below if the buffers
> >> allocated by the page_frag_alloc() are used by these hardwares for
> >> DMA.
> >> buf = page_frag_alloc(really_needed_size + align);
> >> buf = PTR_ALIGN(buf, align);
> >>
> >> These codes seems ugly and would waste a lot of memories if the buffers
> >> are used in a network driver for the TX/RX.
> >
> > Isn't the memory wasted even with this change?
>
> Yes, but less of it. Not always full amount of align, but up to it. Perhaps even
> zero.
Indeed, the worst case is still there but we gain by not allocating the
full 'size + align' all the time.
Thanks.
>
> > I am not familiar with the frag allocator so I might be missing
> > something, but from what I understood each page_frag_cache keeps only
> > the offset inside the current page being allocated, offset which you
> > ALIGN_DOWN() to match the alignment requirement. I don't see how that
> > memory between the non-aligned and aligned offset is going to be used
> > again before the entire page is freed.
>
> True, thath's how page_frag is designed. The align amounts would be most likely
> too small to be usable anyway.
next prev parent reply other threads:[~2021-02-02 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 7:44 [PATCH net-next v2 0/4] net: Avoid the memory waste in some Ethernet drivers Kevin Hao
2021-01-31 7:44 ` [PATCH net-next v2 1/4] mm: page_frag: Introduce page_frag_alloc_align() Kevin Hao
2021-02-02 11:36 ` Ioana Ciornei
2021-02-02 11:48 ` Vlastimil Babka
2021-02-02 12:31 ` Ioana Ciornei [this message]
2021-02-02 16:19 ` Alexander Duyck
2021-02-04 6:40 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202123153.tt7c6icrysrbpluc@skbuf \
--to=ioana.ciornei@nxp.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haokexin@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).