From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A47DC433DB for ; Wed, 3 Feb 2021 18:54:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9A1D64F87 for ; Wed, 3 Feb 2021 18:54:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9A1D64F87 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A7686B0005; Wed, 3 Feb 2021 13:54:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 157306B0006; Wed, 3 Feb 2021 13:54:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0468C6B006E; Wed, 3 Feb 2021 13:54:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id E10626B0005 for ; Wed, 3 Feb 2021 13:54:36 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A74141EE6 for ; Wed, 3 Feb 2021 18:54:36 +0000 (UTC) X-FDA: 77777857752.09.03422A6 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf08.hostedemail.com (Postfix) with ESMTP id 2EA1B80191EB for ; Wed, 3 Feb 2021 18:53:34 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id m6so427303pfk.1 for ; Wed, 03 Feb 2021 10:53:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dzT+zXS02AtWyri914T4RsybmYHwYLbz9EWKPRFdXXk=; b=LTV2jY7OP8MRqDVetuT8spPDkWetfx03dGt3EVUYfPjNPWzYtxcebRq9p+eTwnmfA8 AtP4dGBBZH7vWOtm8Uwfo1u6KhoAaIZvRyo1hEfOdFi7dG0q9KS+67NPvo7taFJbjI2E A8RPRqYU630/EkxrpThbfq2xo5q0vEU7dnO1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dzT+zXS02AtWyri914T4RsybmYHwYLbz9EWKPRFdXXk=; b=Mo5u8RwE0VPwhvGF8avakLoOZyK9KD2wgjJA1xtEe+/XqBG9R4eO+IkDjE6xgKXM+B lA7n5pReO1Dd/o53bptG+JhmJ1ytiIHTDYvbBnpvKhj9CXYlpugBSr9kO5us20kyIzT0 DLQltrNEAt5peZB6ZxhYagnioQ2RY6pFjhIaf2Ut2q/dSNY2cOhgpGmFk3+suTjpaZAo 73qR8hIr/sSzZvydPQ6wDhMs2ySdJslCCCuN3A5iBXRA4NoF0CZPJ2DJ+tfJTsEDhXg3 4uMrSFU4FSWY6nsqJkN9VJF1l/hcFugNH0Ao9qS3Lahf6k9n7UtdSofCit6kGEazw0Z+ FI0A== X-Gm-Message-State: AOAM530ALI9hrhVfOV/T33WowYqimkWVxNNid6hJrj7Nw+NWAvr9BbBd oxvUkAd3SI/OD+ZiBBa88XDsYQ== X-Google-Smtp-Source: ABdhPJw6qtA6XXf+bOOkWXfhEVNcBeKb7xGPOAptplAWZ2eUzFpuxEg7zjxnEaLgPCkPgd6qn5w4Kw== X-Received: by 2002:a65:654e:: with SMTP id a14mr5124637pgw.265.1612378399056; Wed, 03 Feb 2021 10:53:19 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b18sm3078716pfi.173.2021.02.03.10.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 10:53:18 -0800 (PST) Date: Wed, 3 Feb 2021 10:53:17 -0800 From: Kees Cook To: Linus Torvalds Cc: Steven Rostedt , Timur Tabi , Petr Mladek , Sergey Senozhatsky , Linux Kernel Mailing List , Linux-MM , Matthew Wilcox , Andrew Morton , roman.fietze@magna.com, John Ogness , Akinobu Mita Subject: Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed Message-ID: <202102031052.36869CC@keescook> References: <20210202201846.716915-1-timur@kernel.org> <202102021351.AEDE896AB3@keescook> <9ce56a1c-9ea6-996b-84c6-cfde908c2ecd@kernel.org> <20210202173436.6516c676@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2EA1B80191EB X-Stat-Signature: 6xg14hhbxcu7kszes4fxam1rh3jh4dri Received-SPF: none (chromium.org>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail-pf1-f182.google.com; client-ip=209.85.210.182 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612378414-21417 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 02, 2021 at 02:51:00PM -0800, Linus Torvalds wrote: > On Tue, Feb 2, 2021 at 2:34 PM Steven Rostedt wrote: > > > > "I also suspect that everybody has already accepted that KASLR isn't > > really working locally anyway (due to all the hw leak models with > > cache and TLB timing), so anybody who can look at kernel messages > > already probably could figure most of those things out." > > Honestly, if you have to pass a kernel command line, and there's a big > notice in the kernel messages about this, I no longer care. Okay, cool; it's fine by me too. I prefer this kind of "boot into debug mode" switch to having lots of %px scattered around in questionable places. :) I will update the %p deprecation docs. -- Kees Cook