From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE1DC433DB for ; Wed, 3 Feb 2021 20:47:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BAE2064F7C for ; Wed, 3 Feb 2021 20:47:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAE2064F7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E3096B0005; Wed, 3 Feb 2021 15:47:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 193E66B006C; Wed, 3 Feb 2021 15:47:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07F6D6B006E; Wed, 3 Feb 2021 15:47:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id E08AC6B0005 for ; Wed, 3 Feb 2021 15:47:32 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A481C1EE6 for ; Wed, 3 Feb 2021 20:47:32 +0000 (UTC) X-FDA: 77778142344.20.fuel08_4500868275d6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 7FDFB180C07A3 for ; Wed, 3 Feb 2021 20:47:32 +0000 (UTC) X-HE-Tag: fuel08_4500868275d6 X-Filterd-Recvd-Size: 2498 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 3 Feb 2021 20:47:32 +0000 (UTC) Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 760A360234; Wed, 3 Feb 2021 20:47:29 +0000 (UTC) Date: Wed, 3 Feb 2021 15:47:27 -0500 From: Steven Rostedt To: Kees Cook Cc: Timur Tabi , Petr Mladek , Sergey Senozhatsky , linux-kernel@vger.kernel.org, vbabka@suse.cz, linux-mm@kvack.org, willy@infradead.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, roman.fietze@magna.com, john.ogness@linutronix.de, Andy Shevchenko , Rasmus Villemoes , akinobu.mita@gmail.com Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed Message-ID: <20210203154727.20946539@gandalf.local.home> In-Reply-To: <202102031234.9BF349F@keescook> References: <20210202213633.755469-1-timur@kernel.org> <19c1c17e-d0b3-326e-97ec-a4ec1ebee749@kernel.org> <202102031201.FFED9547D@keescook> <20210203152513.34492916@gandalf.local.home> <202102031234.9BF349F@keescook> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 3 Feb 2021 12:35:07 -0800 Kees Cook wrote: > > With a big notice that all pointers of unhashed, I don't think we need to > > print it failed when we expect it to fail. > > > > If anything, skip the test and state: > > > > test_printf: hash test skipped because "make-printk-non-secret" is on the > > command line. > > Yeah, I'm fine with "fail" or "skip". "pass" is mainly what I don't > like. :) Is there any printing of the tests being done? Looks to me that the tests only print something if they fail. Thus "skip" and "pass" are basically the same (if "skip" is simply not to do the test). I mean, we could simply have: static void __init plain(void) { int err; + if (debug_never_hash_pointers) + return; -- Steve