From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4FF6C433E0 for ; Tue, 9 Feb 2021 19:46:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D68C764EAC for ; Tue, 9 Feb 2021 19:46:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D68C764EAC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0DE6A6B0005; Tue, 9 Feb 2021 14:46:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08F466B006C; Tue, 9 Feb 2021 14:46:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9A6E6B006E; Tue, 9 Feb 2021 14:46:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id D4B286B0005 for ; Tue, 9 Feb 2021 14:46:43 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9626E1807B522 for ; Tue, 9 Feb 2021 19:46:43 +0000 (UTC) X-FDA: 77799761886.14.walk18_53026dc2760a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 74210180B8F16 for ; Tue, 9 Feb 2021 19:46:43 +0000 (UTC) X-HE-Tag: walk18_53026dc2760a X-Filterd-Recvd-Size: 2129 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 19:46:42 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0584664E85; Tue, 9 Feb 2021 19:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1612900001; bh=Tibp+D2Q1fLAWYC0pmdwEcPTKdC9dJtIKxcQZULcsjE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rse+ayemXBSfNdjdOADaJKaOySC6VHwaFAcgRgC6E7VW4kTzQhz08AQptUyzvAm85 QUKn8ECsDODXqY+mzEcjP9BGMyivax4L1/iHNiS+pjMKam7WpgniNCJTkR0RgCvNU9 013T0dhjSmenA7iCcHvpA/HQ0nZdPmWQe8TJN1yA= Date: Tue, 9 Feb 2021 11:46:40 -0800 From: Andrew Morton To: Naoya Horiguchi Cc: linux-mm@kvack.org, Michal Hocko , Oscar Salvador , Tony Luck , Matthew Wilcox , "Aneesh Kumar K.V" , Naoya Horiguchi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp Message-Id: <20210209114640.73a68074f635852c2ce498e6@linux-foundation.org> In-Reply-To: <20210209062128.453814-1-nao.horiguchi@gmail.com> References: <20210209062128.453814-1-nao.horiguchi@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 9 Feb 2021 15:21:28 +0900 Naoya Horiguchi wrote: > Currently hwpoison code checks PageAnon() for thp and refuses to handle > errors on non-anonymous thps (just for historical reason). We now > support non-anonymou thp like shmem one, so this patch suggests to enable > to handle shmem thps. Fortunately, we already have can_split_huge_page() > to check if a give thp is splittable, so this patch relies on it. Thanks. We're at -rc7 so I think I'll park this one for 5.12-rc1, unless it is more urgent than I believe it to be?