From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D3FC433E0 for ; Tue, 9 Feb 2021 21:42:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D3B364ED3 for ; Tue, 9 Feb 2021 21:42:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D3B364ED3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8DCCF6B0074; Tue, 9 Feb 2021 16:42:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88CA26B0075; Tue, 9 Feb 2021 16:42:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A07C6B0078; Tue, 9 Feb 2021 16:42:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 6385C6B0074 for ; Tue, 9 Feb 2021 16:42:13 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2970D18580DF9 for ; Tue, 9 Feb 2021 21:42:13 +0000 (UTC) X-FDA: 77800052946.25.dolls56_3d129462760a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 01C171863135D for ; Tue, 9 Feb 2021 21:42:12 +0000 (UTC) X-HE-Tag: dolls56_3d129462760a X-Filterd-Recvd-Size: 3076 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 21:42:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3099F64ED1; Tue, 9 Feb 2021 21:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1612906931; bh=BgOINZYLdLy8InPCq9hDEhwV8Pk9o0wU1HeH016GAGA=; h=Date:From:To:Subject:In-Reply-To:From; b=IIzZ5aGbA8x4NXDlxp0eEZyjMBMryi6OWTIL84mpTGhA9g1QbaFcBUpYOfYs3f9jF bhlsByo2xWhlkN6FqgXzxKdl63dpxWp2sb2E0+G0/Ffmqy5Dl/9iUMJosmvgCFM6qE lFhkCov98OTlgTB+s3VMTYyKUKVQ3gBMS8TeawsU= Date: Tue, 09 Feb 2021 13:42:10 -0800 From: Andrew Morton To: 0x7f454c46@gmail.com, akpm@linux-foundation.org, arnd@arndb.de, bgeffon@google.com, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, natechancellor@gmail.com, ndesaulniers@google.com, richard.weiyang@linux.alibaba.com, sedat.dilek@gmail.com, torvalds@linux-foundation.org, vbabka@suse.cz Subject: [patch 07/14] mm/mremap: fix BUILD_BUG_ON() error in get_extent Message-ID: <20210209214210.G_1knYh_y%akpm@linux-foundation.org> In-Reply-To: <20210209134115.4d933d446165cd0ed8977b03@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arnd Bergmann Subject: mm/mremap: fix BUILD_BUG_ON() error in get_extent clang can't evaluate this function argument at compile time when the function is not inlined, which leads to a link time failure: ld.lld: error: undefined symbol: __compiletime_assert_414 >>> referenced by mremap.c >>> mremap.o:(get_extent) in archive mm/built-in.a Mark the function as __always_inline to avoid it. Link: https://lkml.kernel.org/r/20201230154104.522605-1-arnd@kernel.org Fixes: 9ad9718bfa41 ("mm/mremap: calculate extent in one place") Signed-off-by: Arnd Bergmann Tested-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Tested-by: Sedat Dilek Cc: Kirill A. Shutemov" Cc: Wei Yang Cc: Vlastimil Babka Cc: Dmitry Safonov <0x7f454c46@gmail.com> Cc: Brian Geffon Signed-off-by: Andrew Morton --- mm/mremap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/mm/mremap.c~mm-mremap-fix-build_bug_on-error-in-get_extent +++ a/mm/mremap.c @@ -336,8 +336,9 @@ enum pgt_entry { * valid. Else returns a smaller extent bounded by the end of the source and * destination pgt_entry. */ -static unsigned long get_extent(enum pgt_entry entry, unsigned long old_addr, - unsigned long old_end, unsigned long new_addr) +static __always_inline unsigned long get_extent(enum pgt_entry entry, + unsigned long old_addr, unsigned long old_end, + unsigned long new_addr) { unsigned long next, extent, mask, size; _