From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E43C433E0 for ; Wed, 10 Feb 2021 19:43:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3BE9464E57 for ; Wed, 10 Feb 2021 19:43:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BE9464E57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD95B8D0002; Wed, 10 Feb 2021 14:43:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CAEE26B0092; Wed, 10 Feb 2021 14:43:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B77DE8D0002; Wed, 10 Feb 2021 14:43:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 9E3736B008C for ; Wed, 10 Feb 2021 14:43:50 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5FBCC180ACEFC for ; Wed, 10 Feb 2021 19:43:50 +0000 (UTC) X-FDA: 77803383420.13.jeans43_490178527612 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 9426718023ED0 for ; Wed, 10 Feb 2021 19:43:48 +0000 (UTC) X-HE-Tag: jeans43_490178527612 X-Filterd-Recvd-Size: 4950 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Feb 2021 19:43:48 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id k22so1795983pll.6 for ; Wed, 10 Feb 2021 11:43:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dGHT8XOGSqwJihWSbK4ZCApnRLwGxJl/53HxYyWXezs=; b=if4tN2WNJyzWPTaspQ776mp/XyIjptrjUE6vyDEJQHwBwjbBKoCDQLne6RBOay/Gya ETjxZrzFV35RGRbhe869RCQ/5E/RIbbwgzIoniAUCJ5k201x5mkuiLZOhL0VYdQ4jsAv RyPDmVPC5itgGoWraSB8PUeUtLim9zZMSuPrw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dGHT8XOGSqwJihWSbK4ZCApnRLwGxJl/53HxYyWXezs=; b=XZu42NNX8pGISoBV5+WRwk9cX44YllK8JUilx6DQSV69k7+agT1DSYlcvThbvPZgcO xtqlqB8hBW0UgVQslGzStbDkLLG8Desqys5hBj7XjyxxQM4RlNoirvK7aigouh+am2Xn wHmiWcTzC2qM8Z28ohvacUSSmExdknSvRN+I0e3ChBLsaT005T9kadZTNQPOjvkwiJAG tV+RTrj/FcFo7+VQJjkoK/nWPn35t3UGkbhDHH62T7ZmNyiro5Iwoq13TtEmA0tONVNH ZxqKD9JO4k5pUvAGBnDCV/Hz5muiiWO75hcafdrdFTIxHJKVt5enl4JewluFpC11lBb2 /PfA== X-Gm-Message-State: AOAM532R+QcKS9zrDPCSE6J8jijEhE8x4ycj7oNPqNdw9His+57JO7vq wpsS9SmKpfGuenb3Kvj8YO6r8w== X-Google-Smtp-Source: ABdhPJzEeGazBGDtvRNKKcgM+jRUEzPCcD05XU2/gT44RhHj/XxWHNUDZXuhwPlL1NIDCRlRSpYvHQ== X-Received: by 2002:a17:90a:ab17:: with SMTP id m23mr511137pjq.0.1612986227233; Wed, 10 Feb 2021 11:43:47 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w1sm2853653pjq.38.2021.02.10.11.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 11:43:46 -0800 (PST) Date: Wed, 10 Feb 2021 11:43:45 -0800 From: Kees Cook To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , haitao.huang@intel.com Subject: Re: [PATCH v20 11/25] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY to _PAGE_COW Message-ID: <202102101143.6585C93D43@keescook> References: <20210210175703.12492-1-yu-cheng.yu@intel.com> <20210210175703.12492-12-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210175703.12492-12-yu-cheng.yu@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 10, 2021 at 09:56:49AM -0800, Yu-cheng Yu wrote: > When Shadow Stack is introduced, [R/O + _PAGE_DIRTY] PTE is reserved for > shadow stack. Copy-on-write PTEs have [R/O + _PAGE_COW]. > > When a PTE goes from [R/W + _PAGE_DIRTY] to [R/O + _PAGE_COW], it could > become a transient shadow stack PTE in two cases: > > The first case is that some processors can start a write but end up seeing > a read-only PTE by the time they get to the Dirty bit, creating a transient > shadow stack PTE. However, this will not occur on processors supporting > Shadow Stack, and a TLB flush is not necessary. > > The second case is that when _PAGE_DIRTY is replaced with _PAGE_COW non- > atomically, a transient shadow stack PTE can be created as a result. > Thus, prevent that with cmpxchg. > > Dave Hansen, Jann Horn, Andy Lutomirski, and Peter Zijlstra provided many > insights to the issue. Jann Horn provided the cmpxchg solution. > > Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook -- Kees Cook