From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A21C6C433E0 for ; Wed, 10 Feb 2021 11:41:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1A93F60200 for ; Wed, 10 Feb 2021 11:41:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A93F60200 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5200C6B0006; Wed, 10 Feb 2021 06:41:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CF716B006C; Wed, 10 Feb 2021 06:41:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E62F6B006E; Wed, 10 Feb 2021 06:41:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 297486B0006 for ; Wed, 10 Feb 2021 06:41:16 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E863E8248047 for ; Wed, 10 Feb 2021 11:41:15 +0000 (UTC) X-FDA: 77802167310.13.doll82_020154d2760f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id B8E821856CFEF for ; Wed, 10 Feb 2021 11:41:15 +0000 (UTC) X-HE-Tag: doll82_020154d2760f X-Filterd-Recvd-Size: 4416 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Feb 2021 11:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612957274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wL4SG9uMFV+mFhCtvdkD+pczNWZ7HBnX4eYd8blqO0A=; b=JMY1hyri3dAgrr2kGxz4NfbGbGKMBmFZzYzXlkSiI3e9HVaqs5CHKkff02pMhz2RzmQ5Nj GGmL/MYHjwFcF3++gPoxqfD32C8lbPm60upvBu1jDbsECvbu8uVTspomO2jShBr/cnUoRB KUn+o+6TMCZCs3WlluThCLES5we0X64= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-NB1JMqSQO_6iEkM3iVqzsw-1; Wed, 10 Feb 2021 06:41:11 -0500 X-MC-Unique: NB1JMqSQO_6iEkM3iVqzsw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37F975B364; Wed, 10 Feb 2021 11:41:10 +0000 (UTC) Received: from carbon (unknown [10.36.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65EF560BE2; Wed, 10 Feb 2021 11:41:03 +0000 (UTC) Date: Wed, 10 Feb 2021 12:41:03 +0100 From: Jesper Dangaard Brouer To: Mel Gorman Cc: Chuck Lever , "mgorman@suse.de" , Linux NFS Mailing List , "linux-mm@kvack.org" , brouer@redhat.com, Jakub Kicinski Subject: Re: alloc_pages_bulk() Message-ID: <20210210124103.56ed1e95@carbon> In-Reply-To: <20210210084155.GA3697@techsingularity.net> References: <2A0C36E7-8CB0-486F-A8DB-463CA28C5C5D@oracle.com> <20210209113108.1ca16cfa@carbon> <20210210084155.GA3697@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 10 Feb 2021 08:41:55 +0000 Mel Gorman wrote: > On Tue, Feb 09, 2021 at 11:31:08AM +0100, Jesper Dangaard Brouer wrote: > > > > Neil Brown pointed me to this old thread: > > > > > > > > https://lore.kernel.org/lkml/20170109163518.6001-1-mgorman@techsingularity.net/ > > > > > > > > We see that many of the prerequisites are in v5.11-rc, but > > > > alloc_page_bulk() is not. I tried forward-porting 4/4 in that > > > > series, but enough internal APIs have changed since 2017 that > > > > the patch does not come close to applying and compiling. > > > > I forgot that this was never merged. It is sad as Mel showed huge > > improvement with his work. > > > > > > I'm wondering: > > > > > > > > a) is there a newer version of that work? > > > > > > > > Mel, why was this work never merged upstream? > > > > Lack of realistic consumers to drive it forward, finalise the API and > confirm it was working as expected. It eventually died as a result. If it > was reintroduced, it would need to be forward ported and then implement > at least one user on top. I guess I misunderstood you back in 2017. I though that I had presented a clear use-case/consumer in page_pool[1]. But you wanted the code as part of the patchset I guess. I though, I could add it later via the net-next tree. It seems that Chuck now have a NFS use-case, and Hellwig also have a use-case for DMA-iommu in __iommu_dma_alloc_pages. The performance improvement (in above link) were really impressive! Quote: "It's roughly a 50-70% reduction of allocation costs and roughly a halving of the overall cost of allocating/freeing batches of pages." Who have time to revive this patchset? I can only signup for coding the page_pool usage. Chuck do you have time if Mel doesn't? [1] https://github.com/torvalds/linux/blob/master/net/core/page_pool.c#L201-L209 -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer