From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7B37C433E0 for ; Fri, 12 Feb 2021 20:16:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 202EC64E8E for ; Fri, 12 Feb 2021 20:16:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 202EC64E8E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7FFA88D0088; Fri, 12 Feb 2021 15:16:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B09D8D0060; Fri, 12 Feb 2021 15:16:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6797F8D0088; Fri, 12 Feb 2021 15:16:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 5255C8D0060 for ; Fri, 12 Feb 2021 15:16:13 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 160E0184C0537 for ; Fri, 12 Feb 2021 20:16:13 +0000 (UTC) X-FDA: 77810722626.01.jail56_6306d7f27624 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id E5A0E100918C7 for ; Fri, 12 Feb 2021 20:16:12 +0000 (UTC) X-HE-Tag: jail56_6306d7f27624 X-Filterd-Recvd-Size: 2905 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Fri, 12 Feb 2021 20:16:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AFB1764E8A; Fri, 12 Feb 2021 20:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1613160971; bh=Z6BeODGzyRx31VY22FuktGBOIe3w+i59UrY0eDPk1GU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XZc0O/AHZdME36mBlSpuJdaTY86T1zGR/Y8O1geqGr3tJc8lInivmvBY/iG5gMK/1 NpxE17zhrMoPpLnCDQrfGi3aBw0mAUQxTyUBpmxB5OaQlm4tSPchaNe/Srul9UUh+4 lp+bEV3E7OyO9/FkAgl3yJXmPMw3I3BAfrWesAGk= Date: Fri, 12 Feb 2021 12:16:10 -0800 From: Andrew Morton To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Christoph Hellwig , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm] kasan: export HW_TAGS symbols for KUnit tests Message-Id: <20210212121610.ff05a7bb37f97caef97dc924@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 12 Feb 2021 21:08:52 +0100 Andrey Konovalov wrote: > Currently, building KASAN-KUnit tests as a module fails with: > > ERROR: modpost: "mte_enable_kernel" [lib/test_kasan.ko] undefined! > ERROR: modpost: "mte_set_report_once" [lib/test_kasan.ko] undefined! > > This change adds KASAN wrappers for mte_enable_kernel() and > mte_set_report_once() and only defines and exports them when KASAN-KUnit > tests are enabled. > > The wrappers aren't defined when tests aren't enabled to avoid misuse. > The mte_() functions aren't exported directly to avoid having low-level > KASAN ifdefs in the arch code. > Please confirm that this is applicable to current Linus mainline? Today is pretty much the last day for getting material into 5.11, and this patch has been churning somewhat. So I think it would be better to merge this into 5.12-rc1, with a cc:stable so it goes into 5.11.1. For which we'll need a Fixes:, please?