From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0793C433E0 for ; Mon, 15 Feb 2021 22:33:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 88D8664E00 for ; Mon, 15 Feb 2021 22:33:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88D8664E00 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AFB228D0149; Mon, 15 Feb 2021 17:33:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAB318D0140; Mon, 15 Feb 2021 17:33:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C13E8D0149; Mon, 15 Feb 2021 17:33:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 872BA8D0140 for ; Mon, 15 Feb 2021 17:33:03 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 47CD618019F23 for ; Mon, 15 Feb 2021 22:33:03 +0000 (UTC) X-FDA: 77821953846.03.teeth20_42140e62763e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 268B628A4E9 for ; Mon, 15 Feb 2021 22:33:03 +0000 (UTC) X-HE-Tag: teeth20_42140e62763e X-Filterd-Recvd-Size: 2504 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Feb 2021 22:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rNTiBhtx2cHnzut4A17lywdTi88BOFanfH8m1sFkqqI=; b=KKlmnNDmTZo7kh3gqtISwaGQ1N 4UNDWIVa2mEvehxLS9xhrYJCQ8UyTaNANRzIUgtqKQTiu+/c+OXKykJBAncpUpQEFkvGMmvaZEs47 8TKsOeyCLy/Syqlp+42GyufcfRauNTnkkOnrkgZ6ht4c6ClPoVgRlse3bJhlh+avyMEA1mhFSTqkB AyW6JJN87CrJEBZ8+VguVA0cV53W8Xys64cLbjIXMDD/rup5kPukmzRD7/OPMxnlgjBI3wcVQWStB DIpBzA/DOYJYPM2RBOpg9enDQpBVCWQD3jzNFIA/USBP+Dm9x99LpR4sfcYbUfn4Lao6GQIG2LZ9Q 2nnQ3/7w==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lBmQL-00G9R4-44; Mon, 15 Feb 2021 22:32:57 +0000 Date: Mon, 15 Feb 2021 22:32:57 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH v2 5/6] mm/mempolicy: Rewrite alloc_pages documentation Message-ID: <20210215223257.GG2858050@casper.infradead.org> References: <20210215210203.3827513-1-willy@infradead.org> <20210215210203.3827513-6-willy@infradead.org> <20210215214740.GU299309@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210215214740.GU299309@linux.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 15, 2021 at 11:47:40PM +0200, Mike Rapoport wrote: > > /** > > + * alloc_pages - Allocate pages. > > + * @gfp: GFP flags. > > + * @order: Power of two of number of pages to allocate. > > * > > + * Allocate 1 << @order contiguous pages. The physical address of the > > + * first page is naturally aligned (eg an order-3 allocation will be aligned > > + * to a multiple of 8 * PAGE_SIZE bytes). The NUMA policy of the current > > + * process is honoured when in process context. > > * > > + * Context: Can be called from any context, providing the appropriate GFP > > + * flags are used. > > + * Return: NULL when no page can be allocated. > > Don't you want to mention the return value on success? It is quite obvious, > but still. Sure. Preferred wording? + * Return: The page on success or NULL if allocation fails.