From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 079F4C433DB for ; Tue, 16 Feb 2021 10:27:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 82F8464DAF for ; Tue, 16 Feb 2021 10:27:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82F8464DAF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 099118D016C; Tue, 16 Feb 2021 05:27:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04A428D0140; Tue, 16 Feb 2021 05:27:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC9388D016C; Tue, 16 Feb 2021 05:27:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id D637C8D0140 for ; Tue, 16 Feb 2021 05:27:02 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A9355127F for ; Tue, 16 Feb 2021 10:27:02 +0000 (UTC) X-FDA: 77823753084.07.hose82_4b07ba927643 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 892041803F911 for ; Tue, 16 Feb 2021 10:27:02 +0000 (UTC) X-HE-Tag: hose82_4b07ba927643 X-Filterd-Recvd-Size: 1773 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 16 Feb 2021 10:27:02 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id EDE4F67373; Tue, 16 Feb 2021 11:26:59 +0100 (CET) Date: Tue, 16 Feb 2021 11:26:59 +0100 From: Christoph Hellwig To: David Howells Cc: Trond Myklebust , Anna Schumaker , Steve French , Dominique Martinet , Linus Torvalds , "Matthew Wilcox (Oracle)" , Alexander Viro , Christoph Hellwig , linux-mm@kvack.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Jeff Layton , David Wysochanski , linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/33] mm: Add an unlock function for PG_private_2/PG_fscache Message-ID: <20210216102659.GA27714@lst.de> References: <161340385320.1303470.2392622971006879777.stgit@warthog.procyon.org.uk> <161340387944.1303470.7944159520278177652.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161340387944.1303470.7944159520278177652.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +extern void unlock_page_private_2(struct page *page); No need for the extern. Otherwise this looks good: Reviewed-by: Christoph Hellwig