From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55ADBC433DB for ; Wed, 17 Feb 2021 19:35:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFBCF64E4A for ; Wed, 17 Feb 2021 19:35:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFBCF64E4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 452946B0006; Wed, 17 Feb 2021 14:35:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DA336B006C; Wed, 17 Feb 2021 14:35:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A10D6B006E; Wed, 17 Feb 2021 14:35:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 118986B0006 for ; Wed, 17 Feb 2021 14:35:56 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CA1951264 for ; Wed, 17 Feb 2021 19:35:55 +0000 (UTC) X-FDA: 77828765070.08.620052D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 7FD55E0001B4 for ; Wed, 17 Feb 2021 19:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613590554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a6lkoNLwaY2kbnYVognDDNLrsSmwkL+Qv8v4auisu9Y=; b=GClESXzJXc/Wd/N9z86UwzVMZue8oX+PvOgiMWGnsyergUrfPuaFEdh5IDg7KwnPn+Acy0 hXKrSSp3gaNdNIMQ+P+KhVi3KNlhDbEY0Xr9YYq5CufBdNgdk13L3tamIxiUbUd9k9ROjy TXvayGDmLHI7P+eBAhIlgYXRveVjrOg= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-7bYIsoplO8W4UtyJEVtTjQ-1; Wed, 17 Feb 2021 14:35:52 -0500 X-MC-Unique: 7bYIsoplO8W4UtyJEVtTjQ-1 Received: by mail-qv1-f69.google.com with SMTP id n8so7667058qvo.18 for ; Wed, 17 Feb 2021 11:35:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a6lkoNLwaY2kbnYVognDDNLrsSmwkL+Qv8v4auisu9Y=; b=U8PEUUqtwI4fXtxYRS3eWJIj1UfIHu8lQZWrOUsD6vB2cgmMGBDk+2SkVWIdlK4YX3 KPRFgpdfl0fhvy6fWMU6FqFrBNXPEYE0aiYXcADSuh/zRGxnPWrYCuWEcUUulN5M4azD /V7IPnUT6BNc74odS+KTrq2arvNrJgkXNa2zpauBX50wgoOX5+gXUosOwK+UfdPGWfoh vgeuBBBtWEsMnmuW1lV6rtJMRnQVKKy5hCu0rKkBa48iBqs1BQYurRp4alaQatxV9hOW qjtir9Q2e6bss32jzp9rTZzGinRjmYwxUdvblqAURYBjMOtBw49ezIoPVzFZi2O5WVtx slCA== X-Gm-Message-State: AOAM5339ujPgXjdTuh9zzz2zX1xYpbqYkAeSKqiPsLHQXraxiw1FXLsq vHPNO7npQRfakiV/Y/K3/+HTwfAkcl+RZ7TaOUx3mQQEg6xlseO6RXDMMWyzdpcH0XRRaESGEVF KPQOVKzjguBI= X-Received: by 2002:a37:c17:: with SMTP id 23mr815915qkm.282.1613590552401; Wed, 17 Feb 2021 11:35:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTYIIg5rgOnDJUJSvEaJQTHUn7YXNS0+K5gx2PYQc1TOI5PZNuWIJYe6QRYJIwljMi/RFGQw== X-Received: by 2002:a37:c17:: with SMTP id 23mr815897qkm.282.1613590552210; Wed, 17 Feb 2021 11:35:52 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-182.dsl.bell.ca. [174.93.89.182]) by smtp.gmail.com with ESMTPSA id 12sm1861151qtt.88.2021.02.17.11.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 11:35:51 -0800 (PST) Date: Wed, 17 Feb 2021 14:35:50 -0500 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, shu wang , Axel Rasmussen , Andrea Arcangeli , Heiko Carstens , Alexey Dobriyan , Matthew Wilcox , Michel Lespinasse , Andrew Morton Subject: Re: [RFC PATCH 3/5] mm proc/task_mmu.c: add soft dirty pte checks for hugetlb Message-ID: <20210217193550.GC6519@xz-x1> References: <20210211000322.159437-1-mike.kravetz@oracle.com> <20210211000322.159437-4-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20210211000322.159437-4-mike.kravetz@oracle.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7FD55E0001B4 X-Stat-Signature: mwz9p1zoimy6d4ns43nqcyh3zipxeup9 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613590553-881224 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 10, 2021 at 04:03:20PM -0800, Mike Kravetz wrote: > Pagemap was only using the vma flag PM_SOFT_DIRTY for hugetlb vmas. > This is insufficient. Check the individual pte entries. > > Signed-off-by: Mike Kravetz > --- > fs/proc/task_mmu.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 602e3a52884d..829b35016aaa 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1507,6 +1507,10 @@ static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask, > flags |= PM_SOFT_DIRTY; > > pte = huge_ptep_get(ptep); > + > + if (huge_pte_soft_dirty(pte)) > + flags |= PM_SOFT_DIRTY; Should this be put into pte_present() chunk below? Since I feel like we'd need huge_pte_swp_soft_dirty() for !pte_present(). Say, _PAGE_SOFT_DIRTY and _PAGE_SWP_SOFT_DIRTY can be different. > + > if (pte_present(pte)) { > struct page *page = pte_page(pte); > > -- > 2.29.2 > -- Peter Xu