From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C11BC433DB for ; Thu, 18 Feb 2021 23:02:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AF8ED64E92 for ; Thu, 18 Feb 2021 23:02:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF8ED64E92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 301726B0005; Thu, 18 Feb 2021 18:02:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B0726B006C; Thu, 18 Feb 2021 18:02:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A31F6B006E; Thu, 18 Feb 2021 18:02:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 03F2F6B0005 for ; Thu, 18 Feb 2021 18:02:29 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C408C1815A4CC for ; Thu, 18 Feb 2021 23:02:29 +0000 (UTC) X-FDA: 77832914418.09.17C6CAF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 16F5CC000C72 for ; Thu, 18 Feb 2021 23:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613689348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FU+AIYqDGgm8srMw7KnfiWhYBmq4BR3BSBFf66+l9Sc=; b=Z7fTwP3EDBJuICg4JPriWWyFehPMfLtVxTxdC3S3TBgeTJCHQe1aLfUVCrcznTdeafV+He uRcnklbiimFliLEOUKWNPQsehSMjEeYlZUYcq2uf+fQDqLni7seY2ib5jE8irHLwAOxbMH DX6Bh4Uiw1/V3A28Bel7xBbWr1aaS74= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-cBuXwqtqNxmo03AwA32knw-1; Thu, 18 Feb 2021 18:02:27 -0500 X-MC-Unique: cBuXwqtqNxmo03AwA32knw-1 Received: by mail-qv1-f71.google.com with SMTP id k14so2082834qvw.17 for ; Thu, 18 Feb 2021 15:02:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FU+AIYqDGgm8srMw7KnfiWhYBmq4BR3BSBFf66+l9Sc=; b=pz1Hi0TWUw/G3SzzDJNaSWx8fhQ52q0q2+/CmUMKfp5N5idMAahlWONE2e03fzL28n kDqGuqFGoksIZ5e3iXuq5Z6paSiBQU6eSY6rNFwKSpuCztVLoR7rc1/sndPkq281tyj5 MmRU/434ZuK6+bWaWpzGF0boE5rAcJvsgziHbC+fQ+Nd91nQCM7/PwuOv5e0S5y+yMgg o/OIjAUqKchCIi2BfWvBHKYNV3pGuRJWk0juR+nduoYD2ATmKtfBmGfIGBh7O/YdXBmD G9NoUy69DRNCMa4HtEGDgR2BjFwlVQABF/Rjse8BYzzkuj41HIGtHLQW4Pd868rsd57K s2Sg== X-Gm-Message-State: AOAM530wfuqB43iPKNTWdBGF6kAyVbUMMcgtdoM0sU3yv7Qo5rg1/W4j X0mCXeWLV3hnbs9AIoogF7dq/zQgwaRVTIrCfpIPfdqxc+cDxBP2QfKL8j8nNg+hdCl/GQdNS1J VZUJDWeZC5Vg= X-Received: by 2002:ad4:5ecc:: with SMTP id jm12mr4018449qvb.33.1613689346908; Thu, 18 Feb 2021 15:02:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJxjIop6wWlrtUWew3t2FDo9DLD6rg6n78m0yu7ZvLqgdBvXGS0U7xBcDcd0OHbtsr2xsCDcfQ== X-Received: by 2002:ad4:5ecc:: with SMTP id jm12mr4018431qvb.33.1613689346688; Thu, 18 Feb 2021 15:02:26 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-182.dsl.bell.ca. [174.93.89.182]) by smtp.gmail.com with ESMTPSA id u126sm4902865qkc.107.2021.02.18.15.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 15:02:26 -0800 (PST) Date: Thu, 18 Feb 2021 18:02:24 -0500 From: Peter Xu To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Axel Rasmussen , Andrew Morton , Mike Rapoport , "Kirill A . Shutemov" , Matthew Wilcox , Andrea Arcangeli Subject: Re: [PATCH v3 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share() Message-ID: <20210218230224.GC6669@xz-x1> References: <20210218215434.10203-1-peterx@redhat.com> <20210218215434.10203-2-peterx@redhat.com> <76fee968-cfc2-787f-7e48-af781563756e@oracle.com> <20210218222757.GA6669@xz-x1> <9d93ec4c-4cb9-c3c8-5b73-ae00c4fa9435@oracle.com> MIME-Version: 1.0 In-Reply-To: <9d93ec4c-4cb9-c3c8-5b73-ae00c4fa9435@oracle.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 16F5CC000C72 X-Stat-Signature: cii96pzd6gtyk37kcqd8atmrxz5kmwi1 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613689346-28739 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 18, 2021 at 02:38:18PM -0800, Mike Kravetz wrote: > I thought the error was caused by not deleting the line > > pte_t *huge_pte_alloc(struct mm_struct *mm, > > when adding > > pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, > > as above. Sorry about that! I'll repost. -- Peter Xu