From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 274E3C433DB for ; Fri, 19 Feb 2021 19:18:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B450A64E86 for ; Fri, 19 Feb 2021 19:18:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B450A64E86 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 468FD6B0005; Fri, 19 Feb 2021 14:18:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 418B06B006C; Fri, 19 Feb 2021 14:18:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3301A6B006E; Fri, 19 Feb 2021 14:18:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 13E496B0005 for ; Fri, 19 Feb 2021 14:18:17 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C567A18019547 for ; Fri, 19 Feb 2021 19:18:16 +0000 (UTC) X-FDA: 77835978192.23.AE00600 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP id B43EBA00024C for ; Fri, 19 Feb 2021 19:18:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0D6A164E15; Fri, 19 Feb 2021 19:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613762293; bh=Nh1g4Cl03duznMm2PeHMKLPYAO5dMbJjFdDxNT2KAss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AdgROnoKSCedc1SEauF3FJpf73XnKvbhHAUliQOGa59+/mXLlVIYEEfIDMvxYyMSE gEdOz20c7k6P3P4HDlKud0Ew9408Xu+IOjlsCMUcRLCkprSU6KNzK4VR6yypnLqwpW Xi5KhTKQDPGQm2uLnoBgbz7fAPTr2XlLbVELDYKMAcAaC56ZPBb43iTfzrakuB3HV6 ZMsv3D6DGwT6388VGgdOYYp4Ib78ouhrwIfK8kRLRBS2FrsGmWOaKeRu1UpxJ/ssyg QtyWQonUQwgvxihl/YeTgkIW+K3bZF3ZEgT++b9AZiEqrBOpQChjLF94MhV7sMP1x3 5BTnvOE9s4mZg== Date: Fri, 19 Feb 2021 19:18:07 +0000 From: Will Deacon To: Pavel Tatashin Cc: tyhicks@linux.microsoft.com, jmorris@namei.org, catalin.marinas@arm.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, rppt@kernel.org, logang@deltatee.com, ardb@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mhocko@suse.com, linux-mm@kvack.org Subject: Re: [PATCH v3 1/1] arm64: mm: correct the inside linear map range during hotplug check Message-ID: <20210219191807.GB6683@willie-the-truck> References: <20210216150351.129018-1-pasha.tatashin@soleen.com> <20210216150351.129018-2-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210216150351.129018-2-pasha.tatashin@soleen.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: iq3prim1ayxrry3i1nrkzfr38biub5tp X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B43EBA00024C Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613762293-219490 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 16, 2021 at 10:03:51AM -0500, Pavel Tatashin wrote: > Memory hotplug may fail on systems with CONFIG_RANDOMIZE_BASE because the > linear map range is not checked correctly. > > The start physical address that linear map covers can be actually at the > end of the range because of randomization. Check that and if so reduce it > to 0. > > This can be verified on QEMU with setting kaslr-seed to ~0ul: > > memstart_offset_seed = 0xffff > START: __pa(_PAGE_OFFSET(vabits_actual)) = ffff9000c0000000 > END: __pa(PAGE_END - 1) = 1000bfffffff > > Signed-off-by: Pavel Tatashin > Fixes: 58284a901b42 ("arm64/mm: Validate hotplug range before creating linear mapping") > Tested-by: Tyler Hicks > --- > arch/arm64/mm/mmu.c | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) I tried to queue this as a fix, but unfortunately it doesn't apply. Please can you send a v4 based on the arm64 for-next/fixes branch? Thanks, Will