From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 734EDC433DB for ; Mon, 22 Feb 2021 07:53:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8894D64DDC for ; Mon, 22 Feb 2021 07:53:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8894D64DDC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 01A1A6B006E; Mon, 22 Feb 2021 02:53:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0C546B0070; Mon, 22 Feb 2021 02:53:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E24736B0071; Mon, 22 Feb 2021 02:53:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id C949E6B006E for ; Mon, 22 Feb 2021 02:53:00 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 906268777 for ; Mon, 22 Feb 2021 07:53:00 +0000 (UTC) X-FDA: 77845137720.25.778008C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 031B0C0001F7 for ; Mon, 22 Feb 2021 07:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hqGoMx9Yapzi0ILQOi0zy5A/uV/LCC4QPknj+HY+INU=; b=EmdXJYOJXjM7STZpMm+JRsjv5p g8jamnJj8HF2tF46KSFOBqpCx9zSAUudtn1lPJ5/WVMg1i2agaoR7xfeF2L4sP57cQM7xqW1W/I3O Q/qpnEH68D9sPpB9ezdlL44Y+46Ov1/bEqQYMiIAi9Q1eNlvA+VaTRNjMfwsRn9rG7aOAhofTUpau j+IZOaEjmRnEn/shL3dVqffZFfVH5mA4yy2KWqfv1Pk17mB9VsLvNVIMAgY/WWD3WqHuOqm12mzbH S37wG/jHIZtOJlrIyUD4gE+G4cYhp6TFagVgz38xDBoM/x0Kp1c0NnxkNtImBFpRypqMobgl+g91X UBioS/JQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lE61C-006HOz-NC; Mon, 22 Feb 2021 07:52:36 +0000 Date: Mon, 22 Feb 2021 07:52:34 +0000 From: Christoph Hellwig To: Joao Martins Cc: Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Andrew Morton , Jason Gunthorpe , Doug Ledford , John Hubbard , Matthew Wilcox Subject: Re: [PATCH v4 0/4] mm/gup: page unpining improvements Message-ID: <20210222075234.GA1492783@infradead.org> References: <20210212130843.13865-1-joao.m.martins@oracle.com> <20210218072432.GA325423@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 031B0C0001F7 X-Stat-Signature: ykcytwcsgts46urrdpuc96asqfy5ri3n Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613980380-942057 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 18, 2021 at 03:33:39PM +0000, Joao Martins wrote: > in a bvec at once? e.g. something like from this: > > bio_for_each_segment_all(bvec, bio, iter_all) { > if (mark_dirty && !PageCompound(bvec->bv_page)) > set_page_dirty_lock(bvec->bv_page); > put_page(bvec->bv_page); > } > > (...) to this instead: > > bio_for_each_bvec_all(bvec, bio, i) > unpin_user_page_range_dirty_lock(bvec->bv_page, > DIV_ROUND_UP(bvec->bv_len, PAGE_SIZE), > mark_dirty && !PageCompound(bvec->bv_page)); Yes, like that modulo the fix in your reply and any other fixes.