archive mirror
 help / color / mirror / Atom feed
From: Mike Rapoport <>
To: Andrew Morton <>
Cc: "Andrea Arcangeli" <>,
	"Baoquan He" <>, "Borislav Petkov" <>,
	"Chris Wilson" <>,
	"David Hildenbrand" <>,
	"H. Peter Anvin" <>,
	"Ingo Molnar" <>,
	"Linus Torvalds" <>,
	"Łukasz Majczak" <>,
	"Mel Gorman" <>,
	"Michal Hocko" <>,
	"Mike Rapoport" <>,
	"Mike Rapoport" <>, "Qian Cai" <>,
	"Sarvela, Tomi P" <>,
	"Thomas Gleixner" <>,
	"Vlastimil Babka" <>,,,,
Subject: [PATCH v6 0/1] mm: fix initialization of struct page for holes in  memory layout
Date: Mon, 22 Feb 2021 12:54:00 +0200	[thread overview]
Message-ID: <> (raw)

From: Mike Rapoport <>


@Andrew, this is based on v5.11-mmotm-2021-02-18-18-29 with the previous
version reverted

Commit 73a6e474cb37 ("mm: memmap_init: iterate over memblock regions rather
that check each PFN") exposed several issues with the memory map
initialization and these patches fix those issues.

Initially there were crashes during compaction that Qian Cai reported back
in April [1]. It seemed back then that the problem was fixed, but a few
weeks ago Andrea Arcangeli hit the same bug [2] and there was an additional
discussion at [3].

I didn't appreciate variety of ways BIOSes can report memory in the first
megabyte, so previous versions of this set caused all kinds of troubles.

The last version that implicitly extended node/zone to cover the complete
section might also have unexpected side effects, so this time I'm trying to
move in forward in baby steps.

This is mostly a return to the fist version that simply merges
init_unavailable_pages() into memmap_init() so that the only effective
change would be more sensible zone/node links in unavailable struct pages.

For now, I've dropped the patch that tried to make ZONE_DMA to span pfn 0
because it didn't cause any issues for really long time and there are way
to many hidden mines around this.

I have an ugly workaround for "pfn 0" issue that IMHO is the safest way to
deal with it until it could be gradually fixed properly:

* only interleave initialization of unavailable pages in memmap_init(), so
that it is essentially includes init_unavailable_pages().

* extend node/zone spans to cover complete sections, this allows to interleave
  the initialization of unavailable pages with "normal" memory map init.
* drop modifications to x86 early setup

* make sure pages in the range 0 - start_pfn_of_lowest_zone are initialized
  even if an architecture hides them from the generic mm
* finally make pfn 0 on x86 to be a part of memory visible to the generic
  mm as reserved memory.

* use architectural zone constraints to set zone links for struct pages
  corresponding to the holes
* drop implicit update of memblock.memory
* add a patch that sets pfn 0 to E820_TYPE_RAM on x86

* added patch that adds all regions in memblock.reserved that do not
overlap with memblock.memory to memblock.memory in the beginning of


Mike Rapoport (1):
  mm/page_alloc.c: refactor initialization of struct page for holes in
    memory layout

 mm/page_alloc.c | 144 ++++++++++++++++++++----------------------------
 1 file changed, 61 insertions(+), 83 deletions(-)


                 reply	other threads:[~2021-02-22 10:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).