From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B287C4332D for ; Tue, 23 Feb 2021 15:20:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F48F64E62 for ; Tue, 23 Feb 2021 15:20:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F48F64E62 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 83AD86B0005; Tue, 23 Feb 2021 10:20:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E9E76B0006; Tue, 23 Feb 2021 10:20:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B25C6B006E; Tue, 23 Feb 2021 10:20:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 547476B0005 for ; Tue, 23 Feb 2021 10:20:29 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 24776815E for ; Tue, 23 Feb 2021 15:20:29 +0000 (UTC) X-FDA: 77849894178.26.CBA67E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf03.hostedemail.com (Postfix) with ESMTP id CC577C0005D5 for ; Tue, 23 Feb 2021 15:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614093620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jwgWYg1VA5fUePkB2TEpm/nm7aaUWzYkZRWH3OYKmTM=; b=QXiLahxsPYDfeIkiu/CY5TlCJyUOlZCswsZOm6m7PyKqg5C8HbQolCELudgL5hrd5madBZ sHhbK6hpAfXuqWeyx9pmsf45cPhFTRiBFihqkdOzavIwtFX6yd8wBkoqfIhfVf0PXnU43G QYj/gBoiifk/bhwBB0CARiG6hY0OrA0= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-426-tw1LXIT2MVWNbJT6KkNuaQ-1; Tue, 23 Feb 2021 10:20:18 -0500 X-MC-Unique: tw1LXIT2MVWNbJT6KkNuaQ-1 Received: by mail-qt1-f197.google.com with SMTP id a41so3351207qtk.0 for ; Tue, 23 Feb 2021 07:20:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jwgWYg1VA5fUePkB2TEpm/nm7aaUWzYkZRWH3OYKmTM=; b=ZMYCfC9dsynynr8e5Fzr2WAcT76O+3DmokySCAJjZiBP3aJUv2AOQofXrLIndjyWHr uRoT1pdzkzfy34blvt7OQ5OVAuixaZccCSv5stJ0Q+nJbZyk2aiUv0hNmtesIxJWOiCW ocAlroBM2lvkAt6S+sd1VvBR3YDQeHWz4oo1TapMycXMDq1huN7HU6Zv6u0oi4dZOCsU q66WilBxZZ83776I8LTNcQ1x6zDt5Mf/7AgzPlpQJoFpAMOQUZSczT0qBERcLuu9rlme T9qFbW6lSKej6d6Uyr640n+Vg40K+AE5k3R2A2ccZITp8tTsUVJsubMtFDnXBNiI9YhA VnDQ== X-Gm-Message-State: AOAM533V8dVYg9dMFtHYJ1jmZdY+yeosKt2lvlavxYHD3rAUor8TfUes G/CabaU6nz5ig5snYeqepLGomxnxjWAjPKF1adj2Vn//HZCUMHbnE5PWd9lVN2izvgD5oco++U1 KqMr5D26s8Qo= X-Received: by 2002:a0c:c248:: with SMTP id w8mr1518138qvh.58.1614093618378; Tue, 23 Feb 2021 07:20:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWcuu23NOnPAZhpzswg6vHbLvB7EZ9s8gIVRn3vVyGv4fb9Pn+5A210Mu4KiqWVED3IWq47A== X-Received: by 2002:a0c:c248:: with SMTP id w8mr1518096qvh.58.1614093618102; Tue, 23 Feb 2021 07:20:18 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-25-174-95-95-253.dsl.bell.ca. [174.95.95.253]) by smtp.gmail.com with ESMTPSA id w139sm9203829qka.19.2021.02.23.07.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 07:20:17 -0800 (PST) Date: Tue, 23 Feb 2021 10:20:15 -0500 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Alexey Dobriyan , Andrea Arcangeli , Andrew Morton , Anshuman Khandual , Catalin Marinas , Chinwen Chang , Huang Ying , Ingo Molnar , Jann Horn , Jerome Glisse , Lokesh Gidra , "Matthew Wilcox (Oracle)" , Michael Ellerman , Michal =?utf-8?Q?Koutn=C3=BD?= , Michel Lespinasse , Mike Kravetz , Mike Rapoport , Nicholas Piggin , Shaohua Li , Shawn Anastasio , Steven Rostedt , Steven Price , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Adam Ruprecht , Cannon Matthews , "Dr . David Alan Gilbert" , David Rientjes , Mina Almasry , Oliver Upton Subject: Re: [PATCH v7 1/6] userfaultfd: add minor fault registration mode Message-ID: <20210223152015.GA154711@xz-x1> References: <20210219004824.2899045-1-axelrasmussen@google.com> <20210219004824.2899045-2-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20210219004824.2899045-2-axelrasmussen@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: wqq7wub34hxbetxek3tuqgwhu6pf8pmk X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CC577C0005D5 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614093623-916605 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 18, 2021 at 04:48:19PM -0800, Axel Rasmussen wrote: [...] > @@ -1290,14 +1299,20 @@ static int userfaultfd_register(struct userfaultfd_ctx *ctx, > ret = -EINVAL; > if (!uffdio_register.mode) > goto out; > - if (uffdio_register.mode & ~(UFFDIO_REGISTER_MODE_MISSING| > - UFFDIO_REGISTER_MODE_WP)) > + if (uffdio_register.mode & ~UFFD_API_REGISTER_MODES) > goto out; > vm_flags = 0; > if (uffdio_register.mode & UFFDIO_REGISTER_MODE_MISSING) > vm_flags |= VM_UFFD_MISSING; > if (uffdio_register.mode & UFFDIO_REGISTER_MODE_WP) > vm_flags |= VM_UFFD_WP; > + if (uffdio_register.mode & UFFDIO_REGISTER_MODE_MINOR) { > + /* VM_UFFD_MINOR == VM_NONE if this arch doesn't support it. */ How about check CONFIG_HAVE_ARCH_USERFAULTFD_MINOR below directly instead of commenting? > + ret = -EINVAL; Should be able to drop this line too since ret is -EINVAL already? > + if (!VM_UFFD_MINOR) > + goto out; > + vm_flags |= VM_UFFD_MINOR; > + } [...] > diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h > index 67018d367b9f..a743a0f9ebde 100644 > --- a/include/trace/events/mmflags.h > +++ b/include/trace/events/mmflags.h > @@ -137,6 +137,12 @@ IF_HAVE_PG_ARCH_2(PG_arch_2, "arch_2" ) > #define IF_HAVE_VM_SOFTDIRTY(flag,name) > #endif > > +#ifdef CONFIG_HAVE_ARCH_USERFAULTFD_MINOR > +# define IF_HAVE_UFFD_MINOR(flag, name) {flag, name}, > +#else > +# define IF_HAVE_UFFD_MINOR(flag, name) > +#endif > + > #define __def_vmaflag_names \ > {VM_READ, "read" }, \ > {VM_WRITE, "write" }, \ > @@ -148,6 +154,7 @@ IF_HAVE_PG_ARCH_2(PG_arch_2, "arch_2" ) > {VM_MAYSHARE, "mayshare" }, \ > {VM_GROWSDOWN, "growsdown" }, \ > {VM_UFFD_MISSING, "uffd_missing" }, \ > +IF_HAVE_UFFD_MINOR(VM_UFFD_MINOR, "uffd_minor" ) \ > {VM_PFNMAP, "pfnmap" }, \ > {VM_DENYWRITE, "denywrite" }, \ > {VM_UFFD_WP, "uffd_wp" }, \ > @@ -169,7 +176,7 @@ IF_HAVE_VM_SOFTDIRTY(VM_SOFTDIRTY, "softdirty" ) \ > {VM_MIXEDMAP, "mixedmap" }, \ > {VM_HUGEPAGE, "hugepage" }, \ > {VM_NOHUGEPAGE, "nohugepage" }, \ > - {VM_MERGEABLE, "mergeable" } \ > + {VM_MERGEABLE, "mergeable" } This change seems irrelevant. If you agree with above comments, please feel free to add: Reviewed-by: Peter Xu Thanks, -- Peter Xu