From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC95C433DB for ; Fri, 26 Feb 2021 01:21:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D8E7A64F3E for ; Fri, 26 Feb 2021 01:21:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8E7A64F3E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6687A6B00F1; Thu, 25 Feb 2021 20:21:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61A616B00F2; Thu, 25 Feb 2021 20:21:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 555376B00F3; Thu, 25 Feb 2021 20:21:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 3A42D6B00F1 for ; Thu, 25 Feb 2021 20:21:37 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A6679989B for ; Fri, 26 Feb 2021 01:21:36 +0000 (UTC) X-FDA: 77858666592.10.992B650 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP id 33CA6E0011E3 for ; Fri, 26 Feb 2021 01:21:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B57564F3B; Fri, 26 Feb 2021 01:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614302495; bh=LK5Gdxoelh+DSiG0Dui941ewcvz04XCRFup/um5DaaU=; h=Date:From:To:Subject:In-Reply-To:From; b=YOVujVYHX3QA0Kb2m9zK9jUPNtkhPUUUB9GtX2tvDGvUIOFupjiRd6JG2n2rTLeg3 Pw2cY6NIWhrXa8yyrjPDkoZoydplhygQypKqO+8QiBNigEkYNHdJXEo2f4BMTj9Lw6 CI3PxidwK7qyh/eGfOamPu98NO8/5U4n3mlLQy4w= Date: Thu, 25 Feb 2021 17:21:34 -0800 From: Andrew Morton To: akpm@linux-foundation.org, linux-mm@kvack.org, masahiroy@kernel.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 097/118] lib/cmdline: remove an unneeded local variable in next_arg() Message-ID: <20210226012134.dlagKsZvQ%akpm@linux-foundation.org> In-Reply-To: <20210225171452.713967e96554bb6a53e44a19@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 33CA6E0011E3 X-Stat-Signature: mx8oxummqoijabqnfkt9omyukdz11o5b Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614302495-382783 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Masahiro Yamada Subject: lib/cmdline: remove an unneeded local variable in next_arg() The local variable 'next' is unneeded because you can simply advance the existing pointer 'args'. Link: https://lkml.kernel.org/r/20210201014707.3828753-1-masahiroy@kernel.org Signed-off-by: Masahiro Yamada Signed-off-by: Andrew Morton --- lib/cmdline.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- a/lib/cmdline.c~lib-cmdline-remove-an-unneeded-local-variable-in-next_arg +++ a/lib/cmdline.c @@ -228,7 +228,6 @@ char *next_arg(char *args, char **param, { unsigned int i, equals = 0; int in_quote = 0, quoted = 0; - char *next; if (*args == '"') { args++; @@ -266,10 +265,10 @@ char *next_arg(char *args, char **param, if (args[i]) { args[i] = '\0'; - next = args + i + 1; + args += i + 1; } else - next = args + i; + args += i; /* Chew up trailing spaces. */ - return skip_spaces(next); + return skip_spaces(args); } _