From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FB9C433E0 for ; Fri, 26 Feb 2021 09:48:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E0B5B64EDC for ; Fri, 26 Feb 2021 09:48:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0B5B64EDC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 491226B0006; Fri, 26 Feb 2021 04:48:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 441A46B006C; Fri, 26 Feb 2021 04:48:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 357916B006E; Fri, 26 Feb 2021 04:48:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 1DD8C6B0006 for ; Fri, 26 Feb 2021 04:48:12 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DB4AD1801C36C for ; Fri, 26 Feb 2021 09:48:11 +0000 (UTC) X-FDA: 77859943182.20.0C696E1 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf08.hostedemail.com (Postfix) with ESMTP id F2F9480192C7 for ; Fri, 26 Feb 2021 09:47:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6120CACF6; Fri, 26 Feb 2021 09:48:10 +0000 (UTC) Date: Fri, 26 Feb 2021 10:48:07 +0100 From: Oscar Salvador To: Mike Kravetz Cc: Andrew Morton , David Hildenbrand , Muchun Song , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm: Make alloc_contig_range handle free hugetlb pages Message-ID: <20210226094807.GC3240@linux> References: <20210222135137.25717-1-osalvador@suse.de> <20210222135137.25717-2-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F2F9480192C7 X-Stat-Signature: 4nyywh13xkws65dqcqh8w35rti7jicn7 Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1614332878-324384 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 25, 2021 at 12:03:18PM -0800, Mike Kravetz wrote: > Thanks Oscar, > > I spent a bunch of time looking for possible race issues. Thankfully, > the recent code from Muchun dealing with free lists helps. In addition, > all the hugetlb acounting looks good. > > Reviewed-by: Mike Kravetz thanks for having a look Mike ;-) > > > --- > > include/linux/hugetlb.h | 6 +++ > > mm/compaction.c | 12 ++++++ > > mm/hugetlb.c | 111 +++++++++++++++++++++++++++++++++++++++++++++++- > > 3 files changed, 127 insertions(+), 2 deletions(-) > -- > Mike Kravetz -- Oscar Salvador SUSE L3