From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14579C433E0 for ; Fri, 26 Feb 2021 12:10:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7464064EE7 for ; Fri, 26 Feb 2021 12:10:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7464064EE7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE2898D0001; Fri, 26 Feb 2021 07:10:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A91E76B006E; Fri, 26 Feb 2021 07:10:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A8A68D0001; Fri, 26 Feb 2021 07:10:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 877F16B006C for ; Fri, 26 Feb 2021 07:10:15 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 50C1418215EF2 for ; Fri, 26 Feb 2021 12:10:15 +0000 (UTC) X-FDA: 77860301190.15.CFEABEA Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf20.hostedemail.com (Postfix) with ESMTP id B810512E for ; Fri, 26 Feb 2021 12:10:14 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8E171AB8C; Fri, 26 Feb 2021 12:10:13 +0000 (UTC) Date: Fri, 26 Feb 2021 13:10:11 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Michal Hocko , VlastimilBabkavbabka@suse.cz, pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual Subject: Re: [PATCH v2 7/7] arm64/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Message-ID: <20210226121011.GD3661@localhost.localdomain> References: <20210209133854.17399-1-osalvador@suse.de> <20210209133854.17399-8-osalvador@suse.de> <126fa740-c163-1463-ff48-dbec4ad17ed7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <126fa740-c163-1463-ff48-dbec4ad17ed7@redhat.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B810512E X-Stat-Signature: pcg8q85t78nyeuh57qn4b1uyasmuuybt Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1614341414-840365 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 25, 2021 at 07:29:23PM +0100, David Hildenbrand wrote: > On 09.02.21 14:38, Oscar Salvador wrote: > > Enable arm64 platform to use the MHP_MEMMAP_ON_MEMORY feature. > > > > Signed-off-by: Oscar Salvador > > --- > > arch/arm64/Kconfig | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 87fd02a7a62f..d4fb29779cd4 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -309,6 +309,10 @@ config ARCH_ENABLE_MEMORY_HOTPLUG > > config ARCH_ENABLE_MEMORY_HOTREMOVE > > def_bool y > > +config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > > + def_bool y > > + depends on MEMORY_HOTPLUG && SPARSEMEM_VMEMMAP_ENABLE > > + > > Same comment as for x86-64 variant. >From arm64/Kconfig: config ARCH_SPARSEMEM_ENABLE def_bool y select SPARSEMEM_VMEMMAP_ENABLE config ARCH_SPARSEMEM_DEFAULT def_bool ARCH_SPARSEMEM_ENABLE config ARCH_SELECT_MEMORY_MODEL def_bool ARCH_SPARSEMEM_ENABLE config ARCH_FLATMEM_ENABLE def_bool !NUMA It seems SPARSEMEM_VMEMMAP_ENABLE is ticked by default unless we are on a !NUMA system. So make it dependent on SPARSEMEM_VMEMMAP_ENABLE seems the right thing to do? -- Oscar Salvador SUSE L3