From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05178C433E0 for ; Mon, 1 Mar 2021 10:07:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 83DB864E41 for ; Mon, 1 Mar 2021 10:07:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83DB864E41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E88DF8D005E; Mon, 1 Mar 2021 05:07:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DEA158D0060; Mon, 1 Mar 2021 05:07:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE6168D005E; Mon, 1 Mar 2021 05:07:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id B1B378D005E for ; Mon, 1 Mar 2021 05:07:42 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7F35D2AAE for ; Mon, 1 Mar 2021 10:07:42 +0000 (UTC) X-FDA: 77870878764.22.7EDEA53 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf02.hostedemail.com (Postfix) with ESMTP id DD3D5407F8EB for ; Mon, 1 Mar 2021 10:07:24 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D747AAAC5; Mon, 1 Mar 2021 10:07:40 +0000 (UTC) Date: Mon, 1 Mar 2021 11:07:38 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Michal Hocko , VlastimilBabkavbabka@suse.cz, pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual Subject: Re: [PATCH v2 6/7] x86/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Message-ID: <20210301100737.GB32425@linux> References: <20210209133854.17399-1-osalvador@suse.de> <20210209133854.17399-7-osalvador@suse.de> <20210226120451.GA3661@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: c973bxd5dtu15seyzmun3gpt5ksghta3 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DD3D5407F8EB Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1614593244-327088 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 01, 2021 at 09:45:07AM +0100, David Hildenbrand wrote: > Take your config and set > X86_5LEVEL=n > (because it enforces SPARSEMEM_VMEMMAP) > and > SPARSEMEM_VMEMMAP=n > > When compiling, you'll end up with a config like > CONFIG_SPARSEMEM_VMEMMAP_ENABLE=y > # CONFIG_SPARSEMEM_VMEMMAP is not set I see > > Yet, with your patch you would get > > ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE=y > > And it would not get fenced off in the code, right? > > > I think you either have to check (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP)) in > addition in your code, or enforce it differently. Like > > > config MHP_MEMMAP_ON_MEMORY > depends on SPARSEMEM_VMEMMAP && ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > bool > > > Then you can simplify the arch Kconfig settings, removing the sparesemem > dependency there. Yes, will do it this way. Thanks! -- Oscar Salvador SUSE L3