From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C76C433E0 for ; Mon, 1 Mar 2021 22:18:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D21A60201 for ; Mon, 1 Mar 2021 22:18:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D21A60201 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B9E0A8D00AD; Mon, 1 Mar 2021 17:18:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4E8E8D0063; Mon, 1 Mar 2021 17:18:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A652D8D00AD; Mon, 1 Mar 2021 17:18:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 91A1C8D0063 for ; Mon, 1 Mar 2021 17:18:54 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 52164180AD83B for ; Mon, 1 Mar 2021 22:18:54 +0000 (UTC) X-FDA: 77872721388.05.44B82DD Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf12.hostedemail.com (Postfix) with ESMTP id 88738459CD for ; Mon, 1 Mar 2021 22:18:42 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B108EAD29; Mon, 1 Mar 2021 22:18:48 +0000 (UTC) Date: Mon, 1 Mar 2021 23:18:46 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot , Andrew Morton , Michal Simek , Mike Rapoport , Thomas Gleixner , Arvind Sankar , Ira Weiny , Randy Dunlap , Anshuman Khandual Subject: Re: [PATCH v1] microblaze: tag highmem_setup() with __meminit Message-ID: <20210301221846.GA4744@localhost.localdomain> References: <20210301114749.47914-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301114749.47914-1-david@redhat.com> X-Stat-Signature: ww4eiybdpennwes567hahcmanbpjrhtf X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 88738459CD Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1614637122-286235 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 01, 2021 at 12:47:49PM +0100, David Hildenbrand wrote: > With commit a0cd7a7c4bc0 ("mm: simplify free_highmem_page() and > free_reserved_page()") the kernel test robot complains about a warning: > > WARNING: modpost: vmlinux.o(.text.unlikely+0x23ac): Section mismatch in > reference from the function highmem_setup() to the function > .meminit.text:memblock_is_reserved() > > This has been broken ever since microblaze added highmem support, > because memblock_is_reserved() was already tagged with "__init" back then - > most probably the function always got inlined, so we never stumbled over > it. It might be good to point out that we need __meminit instead of __init because microblaze platform does not define CONFIG_ARCH_KEEP_MEMBLOCK, and __init_memblock fallsback to that. (I had to go and look as I was puzzled :-) ) Reviewed-by: Oscar Salvador > > Reported-by: kernel test robot > Fixes: 2f2f371f8907 ("microblaze: Highmem support") > Cc: Andrew Morton > Cc: Michal Simek > Cc: Mike Rapoport > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: Arvind Sankar > Cc: Ira Weiny > Cc: Randy Dunlap > Cc: Oscar Salvador > Cc: Anshuman Khandual > Signed-off-by: David Hildenbrand > --- > arch/microblaze/mm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c > index 181e48782e6c..05cf1fb3f5ff 100644 > --- a/arch/microblaze/mm/init.c > +++ b/arch/microblaze/mm/init.c > @@ -52,7 +52,7 @@ static void __init highmem_init(void) > pkmap_page_table = virt_to_kpte(PKMAP_BASE); > } > > -static void highmem_setup(void) > +static void __meminit highmem_setup(void) > { > unsigned long pfn; > > -- > 2.29.2 > > -- Oscar Salvador SUSE L3