From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFDCC433E0 for ; Tue, 2 Mar 2021 23:57:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0566864F37 for ; Tue, 2 Mar 2021 23:57:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0566864F37 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 081046B019D; Tue, 2 Mar 2021 18:57:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F11E58D00FA; Tue, 2 Mar 2021 18:57:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC9498D0063; Tue, 2 Mar 2021 18:57:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 8B5FE6B019D for ; Tue, 2 Mar 2021 18:57:22 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2C567181251B8 for ; Tue, 2 Mar 2021 23:57:19 +0000 (UTC) X-FDA: 77876598198.19.DC6ABEE Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf26.hostedemail.com (Postfix) with ESMTP id ACF80407F8F3 for ; Tue, 2 Mar 2021 23:57:17 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id E259711CEC for ; Tue, 2 Mar 2021 23:57:17 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id C425B23810 for ; Tue, 2 Mar 2021 23:57:17 +0000 (UTC) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9E8718249980 for ; Tue, 2 Mar 2021 23:57:07 +0000 (UTC) X-FDA: 77876597694.22.88D5005 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf13.hostedemail.com (Postfix) with ESMTP id 26576E0001B4 for ; Tue, 2 Mar 2021 23:57:06 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 91ABC11CEC for ; Tue, 2 Mar 2021 23:57:06 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 6D99B23810 for ; Tue, 2 Mar 2021 23:57:06 +0000 (UTC) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4FE2152CC for ; Tue, 2 Mar 2021 23:56:56 +0000 (UTC) X-FDA: 77876597232.15.33027DC Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf01.hostedemail.com (Postfix) with ESMTP id 9CBBF2000391 for ; Tue, 2 Mar 2021 23:56:55 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 50A4011CEC for ; Tue, 2 Mar 2021 23:56:55 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 2F38823810 for ; Tue, 2 Mar 2021 23:56:55 +0000 (UTC) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0A5C51809AF0E for ; Tue, 2 Mar 2021 23:56:45 +0000 (UTC) X-FDA: 77876596770.20.8A9FB72 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf09.hostedemail.com (Postfix) with ESMTP id C88F86000107 for ; Tue, 2 Mar 2021 23:56:43 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 1BF0911CEC for ; Tue, 2 Mar 2021 23:56:44 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id EE23E23810 for ; Tue, 2 Mar 2021 23:56:43 +0000 (UTC) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CB3F98249980 for ; Tue, 2 Mar 2021 23:56:33 +0000 (UTC) X-FDA: 77876596266.19.746D693 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf24.hostedemail.com (Postfix) with ESMTP id 410A0A0009D5 for ; Tue, 2 Mar 2021 23:56:32 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id EDB6E11CEC for ; Tue, 2 Mar 2021 23:56:32 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id CDEC923810 for ; Tue, 2 Mar 2021 23:56:32 +0000 (UTC) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B15E44DDB for ; Tue, 2 Mar 2021 23:56:22 +0000 (UTC) X-FDA: 77876595804.07.9D2BA63 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf18.hostedemail.com (Postfix) with ESMTP id B68E62000380 for ; Tue, 2 Mar 2021 23:56:21 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id D0F1E11CEC for ; Tue, 2 Mar 2021 23:56:21 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id B15DC23810 for ; Tue, 2 Mar 2021 23:56:21 +0000 (UTC) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8C18A181AF5C4 for ; Tue, 2 Mar 2021 23:56:11 +0000 (UTC) X-FDA: 77876595342.21.BBE18D2 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf29.hostedemail.com (Postfix) with ESMTP id 9E99C139 for ; Tue, 2 Mar 2021 23:56:10 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id B3D0B11CEC for ; Tue, 2 Mar 2021 23:56:10 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 9369023810 for ; Tue, 2 Mar 2021 23:56:10 +0000 (UTC) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 729B41EF3 for ; Tue, 2 Mar 2021 23:56:00 +0000 (UTC) X-FDA: 77876594880.03.B19F06A Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf01.hostedemail.com (Postfix) with ESMTP id 07BF72000382 for ; Tue, 2 Mar 2021 23:55:59 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id AD1BB11CEC for ; Tue, 2 Mar 2021 23:55:59 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 714BB23810 for ; Tue, 2 Mar 2021 23:55:59 +0000 (UTC) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 541B2814B for ; Tue, 2 Mar 2021 23:55:49 +0000 (UTC) X-FDA: 77876594418.11.269B6B0 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf25.hostedemail.com (Postfix) with ESMTP id EE4206000103 for ; Tue, 2 Mar 2021 23:55:47 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 9FC7D11CEC for ; Tue, 2 Mar 2021 23:55:48 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 7EEE523810 for ; Tue, 2 Mar 2021 23:55:48 +0000 (UTC) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 542778249980 for ; Tue, 2 Mar 2021 23:55:38 +0000 (UTC) X-FDA: 77876593956.09.1D28CF0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf22.hostedemail.com (Postfix) with ESMTP id 5FE21C0001FA for ; Tue, 2 Mar 2021 23:55:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9DACD64F18; Tue, 2 Mar 2021 23:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614729335; bh=zWac9cnIz9laoxFW85MyWgw2aqumRTdkZfT7OXGdHyQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bkgAstw4SxlWP3Cxm/Te8Q8pKFapVg3IsYz1ONK5o1n8THhzzPmvMT/8M18o1H2kB TOyUqfrcz8YDMDH2oMaeb5QhbDJy9ihtsfKRdJ42k+3jKztE39oZhRQWSIukPQ+ezD NLuSj1RQZ4UiPIT+4DX5E7okKS8q6MD7/r6AoGuA= Date: Tue, 2 Mar 2021 15:55:34 -0800 From: Andrew Morton To: Wang Qing Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: delete bool "migrated" Message-Id: <20210302155534.34fa737060e1f29ebfe2fe52@linux-foundation.org> In-Reply-To: <1614603421-2681-1-git-send-email-wangqing@vivo.com> References: <1614603421-2681-1-git-send-email-wangqing@vivo.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729337-525460 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729347-651950 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729359-905654 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729370-158019 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729381-502689 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729392-792335 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729403-771265 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729415-761765 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729426-687857 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: ACF80407F8F3 X-Stat-Signature: ns9xxmhsu651mssx8jcc9a11hmnx4iu1 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614729437-959900 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 1 Mar 2021 20:57:01 +0800 Wang Qing wrote: > Smatch gives the warning: > do_numa_page() warn: assigning (-11) to unsigned variable 'migrated' > > ... > > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4102,7 +4102,6 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) > int page_nid = NUMA_NO_NODE; > int last_cpupid; > int target_nid; > - bool migrated = false; > pte_t pte, old_pte; > bool was_writable = pte_savedwrite(vmf->orig_pte); > int flags = 0; > @@ -4172,8 +4171,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) > } > > /* Migrate to the requested node */ > - migrated = migrate_misplaced_page(page, vma, target_nid); > - if (migrated) { > + if (migrate_misplaced_page(page, vma, target_nid)) { > page_nid = target_nid; > flags |= TNF_MIGRATED; > } else Looks right. Methinks both migrate_misplaced_page() and numamigrate_isolate_page() should return bools. (And that their return values should be documented!)