From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA48C433E0 for ; Thu, 4 Mar 2021 15:53:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E04964E60 for ; Thu, 4 Mar 2021 15:53:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E04964E60 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C183F6B0022; Thu, 4 Mar 2021 10:53:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BECFE6B0023; Thu, 4 Mar 2021 10:53:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A66656B0022; Thu, 4 Mar 2021 10:53:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id 81DE66B000E for ; Thu, 4 Mar 2021 10:53:55 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 376B0180ACC44 for ; Thu, 4 Mar 2021 15:53:55 +0000 (UTC) X-FDA: 77882637630.02.33FDEE9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf27.hostedemail.com (Postfix) with ESMTP id D7B13801A811 for ; Thu, 4 Mar 2021 15:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614873227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AInNnjMguHDerAYue5jzJjfxuItC8i8L4zsZ48EhHbA=; b=GRj2fCxZjdciHxuyBm45ew2x1atz8ZuakIXJP0g6stuI42pxkD/zMvTcbvQ1Ftv+75LwrX hOs5VWb0RzeCXwbVE2lW8YdbAxhEKxorQUuKnxiUqnvLlg+aYII/n5cHL10EupAJRfG/BX P1RE5CkTUfF38KrOaOhON0J/Gnud/38= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-k-zuhMDHOl-MZUj-KR-mzw-1; Thu, 04 Mar 2021 10:53:45 -0500 X-MC-Unique: k-zuhMDHOl-MZUj-KR-mzw-1 Received: by mail-qt1-f198.google.com with SMTP id k10so18017671qte.17 for ; Thu, 04 Mar 2021 07:53:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AInNnjMguHDerAYue5jzJjfxuItC8i8L4zsZ48EhHbA=; b=f1UGSru2iLBmCWsRG6U1oqhbkOmOu+VhJInonnXrOLuc4CYZIWCK7p9GIKcXkbplvt kG+wq/Rz6Uec1YQ/OFlJRrXArk/LesTMiWH11aVTp3gBDe0mFho1XawOJCpqOKtKzmPR I3MLowk+ujx4wKpoq55iFZoyQ345CKOGXYlotfWJt8i6ddbJYdxtsR6KstFl/ihDIDIE x7aTO537uyJFup/OFVWIkPMda6h6nVA8wGMcQvX6LPgK3n89Nf2KDE2c8J/fr//yQyC9 nLKGt5sfuTg/IU+GAjM/5liigd4lN+DzlE+uJFMtv/q7DdYl26DKH4fH8SyBGAd9F5m2 rcrQ== X-Gm-Message-State: AOAM5317Uc3llZNKUypMZzO7g7vwtjjqTuMNwgfhEbS6kIbYpRGhwPnc AXuypuySUTmhoEGj9z7ickdf90OPoFLzViVBXwsxfEB2QnacM9YyZwwB036iwOj2CfFZwHprkWd 0JSq/g18I3qQ= X-Received: by 2002:a0c:b7a1:: with SMTP id l33mr4442584qve.17.1614873225466; Thu, 04 Mar 2021 07:53:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJxj3betVE9M6Fb3f0nr2xiIAAJvEDxTdPk1N7+r3GfIZ84WE+jiOi4ZUO6tlsHyuUmJqEgpkQ== X-Received: by 2002:a0c:b7a1:: with SMTP id l33mr4442575qve.17.1614873225263; Thu, 04 Mar 2021 07:53:45 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-25-174-95-95-253.dsl.bell.ca. [174.95.95.253]) by smtp.gmail.com with ESMTPSA id v4sm17665062qtp.72.2021.03.04.07.53.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 07:53:44 -0800 (PST) Date: Thu, 4 Mar 2021 10:53:42 -0500 From: Peter Xu To: Mike Rapoport Cc: linux-man@vger.kernel.org, Mike Rapoport , Nadav Amit , linux-kernel@vger.kernel.org, Linux MM Mailing List , Axel Rasmussen , Alejandro Colomar , Andrea Arcangeli , Andrew Morton , Michael Kerrisk Subject: Re: [PATCH 1/4] userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs Message-ID: <20210304155342.GY397383@xz-x1> References: <20210304015947.517713-1-peterx@redhat.com> <20210304015947.517713-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: ko7sqki65b3tozwpxtxucyg86pqaxgq3 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D7B13801A811 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614873231-523870 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 04, 2021 at 08:38:09AM +0200, Mike Rapoport wrote: > On Wed, Mar 03, 2021 at 08:59:44PM -0500, Peter Xu wrote: > > UFFD_FEATURE_THREAD_ID is supported since Linux 4.14. > > > > Signed-off-by: Peter Xu > > --- > > man2/userfaultfd.2 | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2 > > index e7dc9f813..2d14effc6 100644 > > --- a/man2/userfaultfd.2 > > +++ b/man2/userfaultfd.2 > > @@ -77,6 +77,12 @@ When the last file descriptor referring to a userfaultfd object is closed, > > all memory ranges that were registered with the object are unregistered > > and unread events are flushed. > > .\" > > +.PP > > +Since Linux 4.14, userfaultfd page fault message can selectively embed fault > > Maybe faulting? ^ Ok. > > > +thread ID information into the fault message. One needs to enable this feature > > +explicitly using the > > +.BR UFFD_FEATURE_THREAD_ID > > +feature bit when initializing the userfaultfd context, otherwise disabled. > > "... otherwise thread ID reporting is disabled" ^ I changed to "... By default, thread ID reporting is diabled." Thanks! -- Peter Xu