linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org,Dave Hansen
	<dave.hansen@linux.intel.com>,yang.shi@linux.alibaba.com,rientjes@google.com,ying.huang@intel.com,dan.j.williams@intel.com,david@redhat.com,osalvador@suse.de
Subject: [PATCH 06/10] mm/vmscan: add page demotion counter
Date: Thu, 04 Mar 2021 16:00:00 -0800	[thread overview]
Message-ID: <20210305000000.48BA4A97@viggo.jf.intel.com> (raw)
In-Reply-To: <20210304235949.7922C1C3@viggo.jf.intel.com>


From: Yang Shi <yang.shi@linux.alibaba.com>

Account the number of demoted pages into reclaim_state->nr_demoted.

Add pgdemote_kswapd and pgdemote_direct VM counters showed in
/proc/vmstat.

[ daveh:
   - __count_vm_events() a bit, and made them look at the THP
     size directly rather than getting data from migrate_pages()
]

Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: osalvador <osalvador@suse.de>

--

Changes since 202010:
 * remove unused scan-control 'demoted' field
---

 b/include/linux/vm_event_item.h |    2 ++
 b/mm/vmscan.c                   |    5 +++++
 b/mm/vmstat.c                   |    2 ++
 3 files changed, 9 insertions(+)

diff -puN include/linux/vm_event_item.h~mm-vmscan-add-page-demotion-counter include/linux/vm_event_item.h
--- a/include/linux/vm_event_item.h~mm-vmscan-add-page-demotion-counter	2021-03-04 15:35:57.698806425 -0800
+++ b/include/linux/vm_event_item.h	2021-03-04 15:35:57.719806425 -0800
@@ -33,6 +33,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS
 		PGREUSE,
 		PGSTEAL_KSWAPD,
 		PGSTEAL_DIRECT,
+		PGDEMOTE_KSWAPD,
+		PGDEMOTE_DIRECT,
 		PGSCAN_KSWAPD,
 		PGSCAN_DIRECT,
 		PGSCAN_DIRECT_THROTTLE,
diff -puN mm/vmscan.c~mm-vmscan-add-page-demotion-counter mm/vmscan.c
--- a/mm/vmscan.c~mm-vmscan-add-page-demotion-counter	2021-03-04 15:35:57.700806425 -0800
+++ b/mm/vmscan.c	2021-03-04 15:35:57.724806425 -0800
@@ -1118,6 +1118,11 @@ static unsigned int demote_page_list(str
 			    target_nid, MIGRATE_ASYNC, MR_DEMOTION,
 			    &nr_succeeded);
 
+	if (current_is_kswapd())
+		__count_vm_events(PGDEMOTE_KSWAPD, nr_succeeded);
+	else
+		__count_vm_events(PGDEMOTE_DIRECT, nr_succeeded);
+
 	return nr_succeeded;
 }
 
diff -puN mm/vmstat.c~mm-vmscan-add-page-demotion-counter mm/vmstat.c
--- a/mm/vmstat.c~mm-vmscan-add-page-demotion-counter	2021-03-04 15:35:57.708806425 -0800
+++ b/mm/vmstat.c	2021-03-04 15:35:57.726806425 -0800
@@ -1244,6 +1244,8 @@ const char * const vmstat_text[] = {
 	"pgreuse",
 	"pgsteal_kswapd",
 	"pgsteal_direct",
+	"pgdemote_kswapd",
+	"pgdemote_direct",
 	"pgscan_kswapd",
 	"pgscan_direct",
 	"pgscan_direct_throttle",
_


  parent reply	other threads:[~2021-03-05  0:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04 23:59 [PATCH 00/10] [v6] Migrate Pages in lieu of discard Dave Hansen
2021-03-04 23:59 ` [PATCH 01/10] mm/numa: node demotion data structure and lookup Dave Hansen
2021-03-08 23:58   ` Yang Shi
2021-03-04 23:59 ` [PATCH 02/10] mm/numa: automatically generate node migration order Dave Hansen
2021-03-08 23:59   ` Yang Shi
2021-03-04 23:59 ` [PATCH 03/10] mm/migrate: update node demotion order during on hotplug events Dave Hansen
2021-03-09  0:03   ` Yang Shi
2021-03-09 22:07     ` Dave Hansen
2021-03-04 23:59 ` [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded Dave Hansen
2021-03-09  0:05   ` Yang Shi
2021-03-04 23:59 ` [PATCH 05/10] mm/migrate: demote pages during reclaim Dave Hansen
2021-03-09  0:10   ` Yang Shi
2021-03-09 23:05     ` Dave Hansen
2021-03-05  0:00 ` Dave Hansen [this message]
2021-03-09  0:11   ` [PATCH 06/10] mm/vmscan: add page demotion counter Yang Shi
2021-03-05  0:00 ` [PATCH 07/10] mm/vmscan: add helper for querying ability to age anonymous pages Dave Hansen
2021-03-09  0:14   ` Yang Shi
2021-03-20  4:05   ` Greg Thelen
2021-03-05  0:00 ` [PATCH 08/10] mm/vmscan: Consider anonymous pages without swap Dave Hansen
2021-03-09  0:17   ` Yang Shi
2021-03-09 23:08     ` Dave Hansen
2021-03-05  0:00 ` [PATCH 09/10] mm/vmscan: never demote for memcg reclaim Dave Hansen
2021-03-09  0:17   ` Yang Shi
2021-03-05  0:00 ` [PATCH 10/10] mm/migrate: new zone_reclaim_mode to enable reclaim migration Dave Hansen
2021-03-09  0:24   ` Yang Shi
2021-03-09 21:53     ` Dave Hansen
2021-03-09  0:34 ` [PATCH 00/10] [v6] Migrate Pages in lieu of discard Yang Shi
2021-03-09 21:52   ` Dave Hansen
2021-04-01 18:32 [PATCH 00/10] [v7][RESEND] " Dave Hansen
2021-04-01 18:32 ` [PATCH 06/10] mm/vmscan: add page demotion counter Dave Hansen
2021-04-10  3:40   ` Wei Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305000000.48BA4A97@viggo.jf.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    --cc=rientjes@google.com \
    --cc=yang.shi@linux.alibaba.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).