From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A074DC433E6 for ; Tue, 9 Mar 2021 02:17:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 29F7365290 for ; Tue, 9 Mar 2021 02:17:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29F7365290 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kingsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E3358D00AD; Mon, 8 Mar 2021 21:17:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66BF18D00A9; Mon, 8 Mar 2021 21:17:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BECB8D00AD; Mon, 8 Mar 2021 21:17:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id 95BF98D00A9 for ; Mon, 8 Mar 2021 21:17:01 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3B9FE181AF5FA for ; Tue, 9 Mar 2021 02:17:01 +0000 (UTC) X-FDA: 77898723042.14.35730C8 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf17.hostedemail.com (Postfix) with ESMTP id 055FE4080F46 for ; Tue, 9 Mar 2021 02:16:59 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id B5BB511CEC for ; Tue, 9 Mar 2021 02:16:59 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 902C223810 for ; Tue, 9 Mar 2021 02:16:59 +0000 (UTC) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2BC832492 for ; Tue, 9 Mar 2021 02:15:59 +0000 (UTC) X-FDA: 77898720438.25.2C81234 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf18.hostedemail.com (Postfix) with ESMTP id 31839200038F for ; Tue, 9 Mar 2021 02:15:59 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 2840311CEC for ; Tue, 9 Mar 2021 02:15:58 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 0BA6123810 for ; Tue, 9 Mar 2021 02:15:58 +0000 (UTC) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AF12062D9 for ; Tue, 9 Mar 2021 02:14:57 +0000 (UTC) X-FDA: 77898717834.07.E64A976 Received: from mail.kingsoft.com (mail.kingsoft.com [114.255.44.145]) by imf27.hostedemail.com (Postfix) with ESMTP id 51DE6801914C for ; Tue, 9 Mar 2021 02:14:52 +0000 (UTC) X-AuditID: 0a580157-463ff70000021a79-54-6046d380849f Received: from mail.kingsoft.com (localhost [10.88.1.32]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.kingsoft.com (SMG-1-NODE-87) with SMTP id 7C.E2.06777.083D6406; Tue, 9 Mar 2021 09:46:40 +0800 (HKT) Received: from alex-virtual-machine (172.16.253.254) by KSBJMAIL2.kingsoft.cn (10.88.1.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 9 Mar 2021 10:14:52 +0800 Date: Tue, 9 Mar 2021 10:14:52 +0800 From: Aili Yao To: "Luck, Tony" CC: Andy Lutomirski , Andy Lutomirski , HORIGUCHI NAOYA , Dave Hansen , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , X86 ML , "yangfeng1@kingsoft.com" , Linux-MM , LKML , Subject: Re: [PATCH v3] x86/fault: Send a SIGBUS to user process always for hwpoison page access. Message-ID: <20210309101452.281af49d@alex-virtual-machine> In-Reply-To: <4fc1b4e8f1fb4c8c81f280db09178797@intel.com> References: <20210308174912.4ac9029a@alex-virtual-machine> <8F3F763F-59CC-4E25-B4DE-89CD0632F754@amacapital.net> <4fc1b4e8f1fb4c8c81f280db09178797@intel.com> Organization: kingsoft X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.253.254] X-ClientProxiedBy: KSBJMAIL1.kingsoft.cn (10.88.1.31) To KSBJMAIL2.kingsoft.cn (10.88.1.32) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsXCFcGooNtw2S3B4HajkcXnDf/YLF5saGe0 mLZR3OLyrjlsFvfW/Ge1WL22gdXi/K61rBaXDixgsrjYeIDR4njvASaLzZumMlu8uXCPxeLH hsesDrwe31v7WDzuv/nL4rF5hZbH4j0vmTw2repk89j0aRK7x7tz59g95p0M9HhxdSOLx/t9 V9k8Pm+S8zjR8oU1gCeKyyYlNSezLLVI3y6BK+Pe5yWsBSfZK851bGRqYHzB2sXIySEhYCJx 6PlOli5GLg4hgelMEjde3WWEcF4ySuzauZkdpIpFQEWib98jZhCbTUBVYte9WWDdIgJqEpcW P2AGaWAWaGeRaLv5CqxBWCBZ4sykB4wgNq+AlcTWPxuBVnBwcApYSvRPTodYsJBR4ufvQ2CD +AXEJHqv/GeCOMleom3LIqheQYmTM5+wgNjMAjoSJ1YdY4aw5SW2v50DZgsJKEocXvKLHaJX SeJI9ww2CDtWYtm8V6wTGIVnIRk1C8moWUhGLWBkXsXIUpybbriJERKL4TsY5zV91DvEyMTB eIhRgoNZSYTX77hbghBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHeluOuCUIC6YklqdmpqQWpRTBZ Jg5OqQYmzbNND/KYcyd/a1l3tZ3Nak6X+PVFdsHtx6b69M3ufjWZR3bzlE4LnWbx389n33Po 2Gkatzo8a82TJyZtFip/V764NKfue87d++27bdSerlvx80R/EvvvBW/uuE1YuncKp8X/GX1r fPm2fcvN3jaz0fh0mhp70n1x2/O/4nJmPt2p0710B1vOoTOC9a+LjnauSpab/XHZxrS2n0Jt bu8fSO2dlt626BTjSpWnEu1J+5bMeympo8S2qeWQzcpmt/45h5J027dm/pv0mMlcfWVLhtJx 3pcrlQ688Z5RzVYvc+dqpmZqxBnXom+TVYQYgrZdlxOVnG7x1ORJSornBa6tvPZVWfvL6ss3 1czYFPpgkRJLcUaioRZzUXEiAJeOtqg0AwAA Received-SPF: none (kingsoft.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mail.kingsoft.com; client-ip=114.255.44.145 X-HE-DKIM-Result: none/none X-HE-Tag: 1615256092-550693 Received-SPF: none (kingsoft.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: none/none X-HE-Tag: 1615256159-168568 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 055FE4080F46 X-Stat-Signature: rx5k43yx5wueanurnuxrk64gyqqysbwq Received-SPF: none (kingsoft.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=smtprelay.test.hostedemail.com; client-ip=216.40.41.5 X-HE-DKIM-Result: none/none X-HE-Tag: 1615256219-379684 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 8 Mar 2021 18:31:07 +0000 "Luck, Tony" wrote: > > Can you point me at that SIGBUS code in a current kernel? > > It is in kill_me_maybe(). mce_vaddr is setup when we disassemble whatever get_user() > or copy from user variant was in use in the kernel when the poison memory was consumed. > > if (p->mce_vaddr != (void __user *)-1l) { > force_sig_mceerr(BUS_MCEERR_AR, p->mce_vaddr, PAGE_SHIFT); > > Would it be any better if we used the BUS_MCEERR_AO code that goes into siginfo? > > That would make it match up better with what happens when poison is found > asynchronously by the patrol scrubber. I.e. the semantics are: > > AR: You just touched poison at this address and need to do something about that. > AO: Just letting you know that you have some poison at the address in siginfo. > > -Tony Is the kill action for this scenario in memory_failure()? -- Thanks! Aili Yao