From: kernel test robot <lkp@intel.com>
To: Alistair Popple <apopple@nvidia.com>,
linux-mm@kvack.org, nouveau@lists.freedesktop.org,
bskeggs@redhat.com, akpm@linux-foundation.org
Cc: kbuild-all@lists.01.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
dri-devel@lists.freedesktop.org, jhubbard@nvidia.com,
rcampbell@nvidia.com
Subject: Re: [PATCH v5 5/8] mm: Device exclusive memory access
Date: Wed, 10 Mar 2021 11:51:08 +0800 [thread overview]
Message-ID: <202103101110.dxjXRy6j-lkp@intel.com> (raw)
In-Reply-To: <20210309121505.23608-6-apopple@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 5411 bytes --]
Hi Alistair,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on s390/features]
[also build test ERROR on linus/master v5.12-rc2 next-20210309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alistair-Popple/Add-support-for-SVM-atomics-in-Nouveau/20210310-064003
base: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f16159aa0e930d32501682bca18bd840f4afd7f1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alistair-Popple/Add-support-for-SVM-atomics-in-Nouveau/20210310-064003
git checkout f16159aa0e930d32501682bca18bd840f4afd7f1
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Note: the linux-review/Alistair-Popple/Add-support-for-SVM-atomics-in-Nouveau/20210310-064003 HEAD 1c7d3a45d0693d661c4d9fbd8d25745b1db4fcbb builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/gpu/drm/nouveau/nouveau_svm.c: In function 'nouveau_svmm_invalidate_range_start':
>> drivers/gpu/drm/nouveau/nouveau_svm.c:268:12: error: 'const struct mmu_notifier_range' has no member named 'migrate_pgmap_owner'
268 | update->migrate_pgmap_owner == svmm->vmm->cli->drm->dev)
| ^~
drivers/gpu/drm/nouveau/nouveau_svm.c: In function 'nouveau_pfns_map':
drivers/gpu/drm/nouveau/nouveau_svm.c:814:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
814 | int ret;
| ^~~
vim +268 drivers/gpu/drm/nouveau/nouveau_svm.c
eeaf06ac1a5584 Ben Skeggs 2018-07-05 244
eeaf06ac1a5584 Ben Skeggs 2018-07-05 245 static int
c625c274ee0058 Jason Gunthorpe 2019-11-12 246 nouveau_svmm_invalidate_range_start(struct mmu_notifier *mn,
1f961807925032 Ralph Campbell 2019-07-25 247 const struct mmu_notifier_range *update)
eeaf06ac1a5584 Ben Skeggs 2018-07-05 248 {
c625c274ee0058 Jason Gunthorpe 2019-11-12 249 struct nouveau_svmm *svmm =
c625c274ee0058 Jason Gunthorpe 2019-11-12 250 container_of(mn, struct nouveau_svmm, notifier);
eeaf06ac1a5584 Ben Skeggs 2018-07-05 251 unsigned long start = update->start;
eeaf06ac1a5584 Ben Skeggs 2018-07-05 252 unsigned long limit = update->end;
eeaf06ac1a5584 Ben Skeggs 2018-07-05 253
1f961807925032 Ralph Campbell 2019-07-25 254 if (!mmu_notifier_range_blockable(update))
eeaf06ac1a5584 Ben Skeggs 2018-07-05 255 return -EAGAIN;
eeaf06ac1a5584 Ben Skeggs 2018-07-05 256
eeaf06ac1a5584 Ben Skeggs 2018-07-05 257 SVMM_DBG(svmm, "invalidate %016lx-%016lx", start, limit);
eeaf06ac1a5584 Ben Skeggs 2018-07-05 258
eeaf06ac1a5584 Ben Skeggs 2018-07-05 259 mutex_lock(&svmm->mutex);
c625c274ee0058 Jason Gunthorpe 2019-11-12 260 if (unlikely(!svmm->vmm))
c625c274ee0058 Jason Gunthorpe 2019-11-12 261 goto out;
c625c274ee0058 Jason Gunthorpe 2019-11-12 262
f8477ce6b5923e Ralph Campbell 2020-07-23 263 /*
f8477ce6b5923e Ralph Campbell 2020-07-23 264 * Ignore invalidation callbacks for device private pages since
f8477ce6b5923e Ralph Campbell 2020-07-23 265 * the invalidation is handled as part of the migration process.
f8477ce6b5923e Ralph Campbell 2020-07-23 266 */
f8477ce6b5923e Ralph Campbell 2020-07-23 267 if (update->event == MMU_NOTIFY_MIGRATE &&
f8477ce6b5923e Ralph Campbell 2020-07-23 @268 update->migrate_pgmap_owner == svmm->vmm->cli->drm->dev)
f8477ce6b5923e Ralph Campbell 2020-07-23 269 goto out;
f8477ce6b5923e Ralph Campbell 2020-07-23 270
eeaf06ac1a5584 Ben Skeggs 2018-07-05 271 if (limit > svmm->unmanaged.start && start < svmm->unmanaged.limit) {
eeaf06ac1a5584 Ben Skeggs 2018-07-05 272 if (start < svmm->unmanaged.start) {
eeaf06ac1a5584 Ben Skeggs 2018-07-05 273 nouveau_svmm_invalidate(svmm, start,
eeaf06ac1a5584 Ben Skeggs 2018-07-05 274 svmm->unmanaged.limit);
eeaf06ac1a5584 Ben Skeggs 2018-07-05 275 }
eeaf06ac1a5584 Ben Skeggs 2018-07-05 276 start = svmm->unmanaged.limit;
eeaf06ac1a5584 Ben Skeggs 2018-07-05 277 }
eeaf06ac1a5584 Ben Skeggs 2018-07-05 278
eeaf06ac1a5584 Ben Skeggs 2018-07-05 279 nouveau_svmm_invalidate(svmm, start, limit);
c625c274ee0058 Jason Gunthorpe 2019-11-12 280
c625c274ee0058 Jason Gunthorpe 2019-11-12 281 out:
eeaf06ac1a5584 Ben Skeggs 2018-07-05 282 mutex_unlock(&svmm->mutex);
eeaf06ac1a5584 Ben Skeggs 2018-07-05 283 return 0;
eeaf06ac1a5584 Ben Skeggs 2018-07-05 284 }
eeaf06ac1a5584 Ben Skeggs 2018-07-05 285
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 76878 bytes --]
next prev parent reply other threads:[~2021-03-10 3:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 12:14 [PATCH v5 0/8] Add support for SVM atomics in Nouveau Alistair Popple
2021-03-09 12:14 ` [PATCH v5 1/8] mm: Remove special swap entry functions Alistair Popple
2021-03-09 12:49 ` Matthew Wilcox
2021-03-12 4:42 ` Alistair Popple
2021-03-10 2:59 ` kernel test robot
2021-03-09 12:14 ` [PATCH v5 2/8] mm/swapops: Rework swap entry manipulation code Alistair Popple
2021-03-09 12:15 ` [PATCH v5 3/8] mm/rmap: Split try_to_munlock from try_to_unmap Alistair Popple
2021-03-09 12:15 ` [PATCH v5 4/8] mm/rmap: Split migration into its own function Alistair Popple
2021-03-09 12:15 ` [PATCH v5 5/8] mm: Device exclusive memory access Alistair Popple
2021-03-10 3:51 ` kernel test robot [this message]
2021-03-09 12:15 ` [PATCH v5 6/8] mm: Selftests for exclusive device memory Alistair Popple
2021-03-09 22:38 ` [PATCH v5 7/8] nouveau/svm: Refactor nouveau_range_fault Alistair Popple
2021-03-09 22:38 ` [PATCH v5 8/8] nouveau/svm: Implement atomic SVM access Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103101110.dxjXRy6j-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jhubbard@nvidia.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).