From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198B9C433E6 for ; Thu, 11 Mar 2021 19:09:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 94A3464EBB for ; Thu, 11 Mar 2021 19:09:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94A3464EBB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C93528D02E5; Thu, 11 Mar 2021 14:09:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF74C8D02B2; Thu, 11 Mar 2021 14:09:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A20C28D02E5; Thu, 11 Mar 2021 14:09:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 79BE08D02B2 for ; Thu, 11 Mar 2021 14:09:03 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 32AB9180ACF9A for ; Thu, 11 Mar 2021 19:09:03 +0000 (UTC) X-FDA: 77908530966.10.19EBCA8 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf13.hostedemail.com (Postfix) with ESMTP id 6A9B3E005F2E for ; Thu, 11 Mar 2021 19:09:00 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id y67so204916pfb.2 for ; Thu, 11 Mar 2021 11:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ad6rFdrjF9qkUCg0uueBGRPkzrqRpMOaGc3NS4qxCRQ=; b=vKEaDb0pRFGw1ac2fSVbByJ/bryyv9m8N66XhwfI1mxAIXCGvTtnVNSRknaDGOpu3r mF3ky3Se8SjadopZ5vbnZFBEAtxE+6nQMUWUQsIiqZYLtnIoCW76v532jRs1CJv6MJW0 UXSaDvB/qYPV0hTsi4Ofsshg6au5Kmv82jo+dQ9t7h1iXScyhgymtcd1OkWkMN1oO7SX fzGehcR1dmA2UtgSb0aaSuzWHC9mBk6khdIF8MdEBsDZVrYgl43eE3Y1jm2kG4jfVMzH /1raUVFgjAKf1VVMxt/sL6d7NmzzBfCWRM/JIwTbu05KOem0EBBq+foWfz4PzbZ1OoV6 z09w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ad6rFdrjF9qkUCg0uueBGRPkzrqRpMOaGc3NS4qxCRQ=; b=YxqTSqZoKqyUqIRL4pRk4k+oqoS5V7ccZXE9szfWy1jSOe9fYhuP/YsPk0PVWGjUDj lvMqd45wFWj/6HupSe35i7dC1W9kE1an1QJtI+Ee7jOvxRve1XQkkoOCIFAmD7Z3kgGA 1Zp1J7jPJ1co8S5Rwuj0ggXBcOsPykOGSGtFeiOG0uiUr1qpuVxreSe9oHTBYEvSioR2 4nbUeMfs8nTO5dSBIs7dABXhBUvXAoBWJSlwIQllpYYCVMG/Q7tH20jIe3lOFTAv7eAO +Ia+aJBpVrs6v/SN2Acue5FL/pQ15XiHF4UsFoqLZsaX8zkZI9+0t27ZFHrGZjP4B2Br gRaA== X-Gm-Message-State: AOAM532R0LEoedf/h/GTz1ZkdM+vXaZ3aJaHGT7w1sdXmnDHAawVQBse 8SKgiDR6WUkI+4+1qzJjod8= X-Google-Smtp-Source: ABdhPJzkCuz0y/v1wgMPEFCdMw3j4bSNGMz2Ido7wOOTliNLwGqxRrstshQGOD0XEXWudM+Ej+Xhfg== X-Received: by 2002:a63:d601:: with SMTP id q1mr8342915pgg.417.1615489741567; Thu, 11 Mar 2021 11:09:01 -0800 (PST) Received: from localhost.localdomain (c-73-93-239-127.hsd1.ca.comcast.net. [73.93.239.127]) by smtp.gmail.com with ESMTPSA id t12sm2999111pfe.203.2021.03.11.11.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 11:09:00 -0800 (PST) From: Yang Shi To: guro@fb.com, ktkhai@virtuozzo.com, vbabka@suse.cz, shakeelb@google.com, david@fromorbit.com, hannes@cmpxchg.org, mhocko@suse.com, akpm@linux-foundation.org Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v10 PATCH 01/13] mm: vmscan: use nid from shrink_control for tracepoint Date: Thu, 11 Mar 2021 11:08:33 -0800 Message-Id: <20210311190845.9708-2-shy828301@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311190845.9708-1-shy828301@gmail.com> References: <20210311190845.9708-1-shy828301@gmail.com> MIME-Version: 1.0 X-Stat-Signature: 3dkstfq15rrojnhxwgudoqwe5iajhguc X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6A9B3E005F2E Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=mail-pf1-f177.google.com; client-ip=209.85.210.177 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615489740-32724 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The tracepoint's nid should show what node the shrink happens on, the sta= rt tracepoint uses nid from shrinkctl, but the nid might be set to 0 before end tracepo= int if the shrinker is not NUMA aware, so the tracing log may show the shrink happen= s on one node but end up on the other node. It seems confusing. And the followin= g patch will remove using nid directly in do_shrink_slab(), this patch also helps= cleanup the code. Acked-by: Vlastimil Babka Acked-by: Kirill Tkhai Reviewed-by: Shakeel Butt Acked-by: Roman Gushchin Signed-off-by: Yang Shi --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 407051ebe869..bdc32c803c66 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -536,7 +536,7 @@ static unsigned long do_shrink_slab(struct shrink_con= trol *shrinkctl, else new_nr =3D atomic_long_read(&shrinker->nr_deferred[nid]); =20 - trace_mm_shrink_slab_end(shrinker, nid, freed, nr, new_nr, total_scan); + trace_mm_shrink_slab_end(shrinker, shrinkctl->nid, freed, nr, new_nr, t= otal_scan); return freed; } =20 --=20 2.26.2