From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F33EDC433E6 for ; Thu, 11 Mar 2021 19:09:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7140E64EF2 for ; Thu, 11 Mar 2021 19:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7140E64EF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EDCE48D02E9; Thu, 11 Mar 2021 14:09:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E652B8D02B2; Thu, 11 Mar 2021 14:09:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE1D78D02E9; Thu, 11 Mar 2021 14:09:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id AB16F8D02B2 for ; Thu, 11 Mar 2021 14:09:14 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 665FF52A8 for ; Thu, 11 Mar 2021 19:09:14 +0000 (UTC) X-FDA: 77908531428.15.DEAF0DE Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf26.hostedemail.com (Postfix) with ESMTP id 5CEB24080F45 for ; Thu, 11 Mar 2021 19:09:10 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id a22-20020a17090aa516b02900c1215e9b33so9542268pjq.5 for ; Thu, 11 Mar 2021 11:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yTJ/H30mQn6R1SM8EhChDB9qQz/lBTytGLmfD9l2+II=; b=bKs5nQfvV9VNRtxx31OVFCDRjVIUA1MqSq0Qlg7NDlpuCeL1wAHmHtmIMAixLQz84t gPqu8nQa8Yo6lewYSj7868vMjMp7E13B28hlaGRZecAESSK19pvSf5/3tEEFZ3I5gnqN 83SHWyHA4YlXuoBJshYoOzb3nB8xQ0OG4UkP05L+mAPXiz8u+476k26xYw9lNzRiUO1u VHj5ADPOHJxzusnnpD0P5BPOKwkgBSyqYfgITS2LK6oTpYeiNZobE2yjjQwzYmqlOF1/ yCweqr+zHrLlL/Wv0Fi/rODH+MBcPWLvKCjaMJtgskIdVpAjdTfRvg7WrTBiFK0fSnvN 5X+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yTJ/H30mQn6R1SM8EhChDB9qQz/lBTytGLmfD9l2+II=; b=ojsYb45rlGOO70v1qjk5NTolZNImhHU4XeiKevlAl+nI70i/qO85sT3URVdtlalwwZ +3+XqKmQ8JuyDVK8BlUfyzAu1IXqv/D6j2DEOUdrpY2rucH4m9V5ARxemRFAnT9oytvY HampHG5A7hi5Y7WdNeWbuH55CcElh6dJHc3wzEUmnBVF+0SLICYpJIqpi6b7RLIgzZ4h acWdUioPl5T0FGsj/ygM+POdbdzVlZGJ43Z5IyHmvJ24ON7QLiwCRrzMJF9OL63vE/ld 9D3LAwC+V4uAT+7lNIyDHlpu5KEW5ebaRWZpuEO7ccCNAR1uQiOhzz7fHJLc1DKv3ybl cPKg== X-Gm-Message-State: AOAM531LAFs51iyrmMmoxrtLlwdJ5ovK3CKDjnt5KRm/SIITn/R52a6l HwPPpmqBx8oEnA69Vo0fq8Z+XPr0OVv0Zg== X-Google-Smtp-Source: ABdhPJwOllGQof/4c+nVC7dRgHvATP7IsRB2CncLFsjLly9r/Xyx9wDnDSbkHWVV8oVmalZuJixtNQ== X-Received: by 2002:a17:90a:a4cb:: with SMTP id l11mr10054163pjw.144.1615489752274; Thu, 11 Mar 2021 11:09:12 -0800 (PST) Received: from localhost.localdomain (c-73-93-239-127.hsd1.ca.comcast.net. [73.93.239.127]) by smtp.gmail.com with ESMTPSA id t12sm2999111pfe.203.2021.03.11.11.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 11:09:11 -0800 (PST) From: Yang Shi To: guro@fb.com, ktkhai@virtuozzo.com, vbabka@suse.cz, shakeelb@google.com, david@fromorbit.com, hannes@cmpxchg.org, mhocko@suse.com, akpm@linux-foundation.org Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v10 PATCH 06/13] mm: memcontrol: rename shrinker_map to shrinker_info Date: Thu, 11 Mar 2021 11:08:38 -0800 Message-Id: <20210311190845.9708-7-shy828301@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210311190845.9708-1-shy828301@gmail.com> References: <20210311190845.9708-1-shy828301@gmail.com> MIME-Version: 1.0 X-Stat-Signature: gaicxpni5hfo5dyiarpwgyyzwawc8tir X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5CEB24080F45 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-pj1-f42.google.com; client-ip=209.85.216.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615489750-853760 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The following patch is going to add nr_deferred into shrinker_map, the ch= ange will make shrinker_map not only include map anymore, so rename it to "memcg_sh= rinker_info". And this should make the patch adding nr_deferred cleaner and readable an= d make review easier. Also remove the "memcg_" prefix. Acked-by: Vlastimil Babka Acked-by: Kirill Tkhai Acked-by: Roman Gushchin Reviewed-by: Shakeel Butt Signed-off-by: Yang Shi --- include/linux/memcontrol.h | 8 +++--- mm/memcontrol.c | 6 ++-- mm/vmscan.c | 58 +++++++++++++++++++------------------- 3 files changed, 36 insertions(+), 36 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index b07dc2d5014d..dc7d0e2cb3ad 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -117,7 +117,7 @@ struct batched_lruvec_stat { * Bitmap of shrinker::id corresponding to memcg-aware shrinkers, * which have elements charged to this memcg. */ -struct memcg_shrinker_map { +struct shrinker_info { struct rcu_head rcu; unsigned long map[]; }; @@ -145,7 +145,7 @@ struct mem_cgroup_per_node { =20 struct mem_cgroup_reclaim_iter iter; =20 - struct memcg_shrinker_map __rcu *shrinker_map; + struct shrinker_info __rcu *shrinker_info; =20 struct rb_node tree_node; /* RB tree node */ unsigned long usage_in_excess;/* Set to the value by which */ @@ -1533,8 +1533,8 @@ static inline bool mem_cgroup_under_socket_pressure= (struct mem_cgroup *memcg) return false; } =20 -int alloc_shrinker_maps(struct mem_cgroup *memcg); -void free_shrinker_maps(struct mem_cgroup *memcg); +int alloc_shrinker_info(struct mem_cgroup *memcg); +void free_shrinker_info(struct mem_cgroup *memcg); void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id= ); #else #define mem_cgroup_sockets_enabled 0 diff --git a/mm/memcontrol.c b/mm/memcontrol.c index aeb1847f159c..35d44afdd9fc 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5131,11 +5131,11 @@ static int mem_cgroup_css_online(struct cgroup_su= bsys_state *css) struct mem_cgroup *memcg =3D mem_cgroup_from_css(css); =20 /* - * A memcg must be visible for expand_shrinker_maps() + * A memcg must be visible for expand_shrinker_info() * by the time the maps are allocated. So, we allocate maps * here, when for_each_mem_cgroup() can't skip it. */ - if (alloc_shrinker_maps(memcg)) { + if (alloc_shrinker_info(memcg)) { mem_cgroup_id_remove(memcg); return -ENOMEM; } @@ -5199,7 +5199,7 @@ static void mem_cgroup_css_free(struct cgroup_subsy= s_state *css) vmpressure_cleanup(&memcg->vmpressure); cancel_work_sync(&memcg->high_work); mem_cgroup_remove_from_trees(memcg); - free_shrinker_maps(memcg); + free_shrinker_info(memcg); memcg_free_kmem(memcg); mem_cgroup_free(memcg); } diff --git a/mm/vmscan.c b/mm/vmscan.c index bbe13985ae05..7fdfdacf9a1f 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -192,16 +192,16 @@ static inline int shrinker_map_size(int nr_items) return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); } =20 -static int expand_one_shrinker_map(struct mem_cgroup *memcg, - int size, int old_size) +static int expand_one_shrinker_info(struct mem_cgroup *memcg, + int size, int old_size) { - struct memcg_shrinker_map *new, *old; + struct shrinker_info *new, *old; struct mem_cgroup_per_node *pn; int nid; =20 for_each_node(nid) { pn =3D memcg->nodeinfo[nid]; - old =3D rcu_dereference_protected(pn->shrinker_map, true); + old =3D rcu_dereference_protected(pn->shrinker_info, true); /* Not yet online memcg */ if (!old) return 0; @@ -214,17 +214,17 @@ static int expand_one_shrinker_map(struct mem_cgrou= p *memcg, memset(new->map, (int)0xff, old_size); memset((void *)new->map + old_size, 0, size - old_size); =20 - rcu_assign_pointer(pn->shrinker_map, new); + rcu_assign_pointer(pn->shrinker_info, new); kvfree_rcu(old, rcu); } =20 return 0; } =20 -void free_shrinker_maps(struct mem_cgroup *memcg) +void free_shrinker_info(struct mem_cgroup *memcg) { struct mem_cgroup_per_node *pn; - struct memcg_shrinker_map *map; + struct shrinker_info *info; int nid; =20 if (mem_cgroup_is_root(memcg)) @@ -232,15 +232,15 @@ void free_shrinker_maps(struct mem_cgroup *memcg) =20 for_each_node(nid) { pn =3D memcg->nodeinfo[nid]; - map =3D rcu_dereference_protected(pn->shrinker_map, true); - kvfree(map); - rcu_assign_pointer(pn->shrinker_map, NULL); + info =3D rcu_dereference_protected(pn->shrinker_info, true); + kvfree(info); + rcu_assign_pointer(pn->shrinker_info, NULL); } } =20 -int alloc_shrinker_maps(struct mem_cgroup *memcg) +int alloc_shrinker_info(struct mem_cgroup *memcg) { - struct memcg_shrinker_map *map; + struct shrinker_info *info; int nid, size, ret =3D 0; =20 if (mem_cgroup_is_root(memcg)) @@ -249,20 +249,20 @@ int alloc_shrinker_maps(struct mem_cgroup *memcg) down_write(&shrinker_rwsem); size =3D shrinker_map_size(shrinker_nr_max); for_each_node(nid) { - map =3D kvzalloc_node(sizeof(*map) + size, GFP_KERNEL, nid); - if (!map) { - free_shrinker_maps(memcg); + info =3D kvzalloc_node(sizeof(*info) + size, GFP_KERNEL, nid); + if (!info) { + free_shrinker_info(memcg); ret =3D -ENOMEM; break; } - rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_map, map); + rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_info, info); } up_write(&shrinker_rwsem); =20 return ret; } =20 -static int expand_shrinker_maps(int new_id) +static int expand_shrinker_info(int new_id) { int size, old_size, ret =3D 0; int new_nr_max =3D new_id + 1; @@ -282,7 +282,7 @@ static int expand_shrinker_maps(int new_id) do { if (mem_cgroup_is_root(memcg)) continue; - ret =3D expand_one_shrinker_map(memcg, size, old_size); + ret =3D expand_one_shrinker_info(memcg, size, old_size); if (ret) { mem_cgroup_iter_break(NULL, memcg); goto out; @@ -298,13 +298,13 @@ static int expand_shrinker_maps(int new_id) void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id= ) { if (shrinker_id >=3D 0 && memcg && !mem_cgroup_is_root(memcg)) { - struct memcg_shrinker_map *map; + struct shrinker_info *info; =20 rcu_read_lock(); - map =3D rcu_dereference(memcg->nodeinfo[nid]->shrinker_map); + info =3D rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); /* Pairs with smp mb in shrink_slab() */ smp_mb__before_atomic(); - set_bit(shrinker_id, map->map); + set_bit(shrinker_id, info->map); rcu_read_unlock(); } } @@ -335,7 +335,7 @@ static int prealloc_memcg_shrinker(struct shrinker *s= hrinker) goto unlock; =20 if (id >=3D shrinker_nr_max) { - if (expand_shrinker_maps(id)) { + if (expand_shrinker_info(id)) { idr_remove(&shrinker_idr, id); goto unlock; } @@ -665,7 +665,7 @@ static unsigned long do_shrink_slab(struct shrink_con= trol *shrinkctl, static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, int priority) { - struct memcg_shrinker_map *map; + struct shrinker_info *info; unsigned long ret, freed =3D 0; int i; =20 @@ -675,12 +675,12 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_ma= sk, int nid, if (!down_read_trylock(&shrinker_rwsem)) return 0; =20 - map =3D rcu_dereference_protected(memcg->nodeinfo[nid]->shrinker_map, - true); - if (unlikely(!map)) + info =3D rcu_dereference_protected(memcg->nodeinfo[nid]->shrinker_info, + true); + if (unlikely(!info)) goto unlock; =20 - for_each_set_bit(i, map->map, shrinker_nr_max) { + for_each_set_bit(i, info->map, shrinker_nr_max) { struct shrink_control sc =3D { .gfp_mask =3D gfp_mask, .nid =3D nid, @@ -691,7 +691,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask= , int nid, shrinker =3D idr_find(&shrinker_idr, i); if (unlikely(!shrinker || shrinker =3D=3D SHRINKER_REGISTERING)) { if (!shrinker) - clear_bit(i, map->map); + clear_bit(i, info->map); continue; } =20 @@ -702,7 +702,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask= , int nid, =20 ret =3D do_shrink_slab(&sc, shrinker, priority); if (ret =3D=3D SHRINK_EMPTY) { - clear_bit(i, map->map); + clear_bit(i, info->map); /* * After the shrinker reported that it had no objects to * free, but before we cleared the corresponding bit in --=20 2.26.2