From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A546FC433DB for ; Fri, 12 Mar 2021 09:30:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3BCE664F2C for ; Fri, 12 Mar 2021 09:30:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BCE664F2C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CAFAA8D0342; Fri, 12 Mar 2021 04:30:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C86568D0317; Fri, 12 Mar 2021 04:30:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4EE68D0342; Fri, 12 Mar 2021 04:30:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 996178D0317 for ; Fri, 12 Mar 2021 04:30:38 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4D98E8248047 for ; Fri, 12 Mar 2021 09:30:38 +0000 (UTC) X-FDA: 77910702156.05.D491FB4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 55F59130 for ; Fri, 12 Mar 2021 09:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/PY1FtmG3ac2SthA8z5yZwsXBWGLH/vri2vgNuCMVKM=; b=P5wamdz2faf+EoMA1yl/bkt1Kn tBG5+2J7pgNwd9gxHE2WLsWsWJZORrx0XrqI3Ks2LnCF0E7ntIPNhbz5W5WJgsHQsLy4JATrQxGrd 17CxkCwVA1meyjfsDUBXTrz6ZQPmxj2W9KdmtHyWxQtG8MJtQijljhcGb/+RVHU0VHaJLo8W53Adv Nui1OWTkrp0C84Z2bkKN5sWDvVDYU2HF7SNgIYJiEMCBfR13/416fteRMbXpMMbgcgM8DjkTejAwQ hphyA/VW2FmrJnvc/afWDKGL8BTshsa9N/FFGXBNlaoTFV9sKFwUwd9dRMdm5F5MW3fvbwIXGv/NY PltV3i3Q==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lKe70-00A7fg-GY; Fri, 12 Mar 2021 09:29:45 +0000 Date: Fri, 12 Mar 2021 09:29:38 +0000 From: Christoph Hellwig To: Jianqun Xu Cc: cl@linux.co, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] mm/slab: kmalloc with GFP_DMA32 allocate from SLAB_CACHE_DMA32 Message-ID: <20210312092938.GA2412021@infradead.org> References: <20210312080320.1965201-1-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210312080320.1965201-1-jay.xu@rock-chips.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: pd9tjk7mxux5g3pic3sz7k6h75q95wjb X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 55F59130 Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615541436-486241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 12, 2021 at 04:03:20PM +0800, Jianqun Xu wrote: > The flag GFP_DMA32 only effect in kmalloc_large currently. > > This patch will create caches with GFP_DMA32 to support kmalloc with > size under KMALLOC_MAX_CACHE_SIZE. No. No new code should use GFP_DMA32, never mind through slab. Please use the proper DMA APIs for your addressing needs.