From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F0BC433E0 for ; Sat, 13 Mar 2021 14:57:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9B3FB64F18 for ; Sat, 13 Mar 2021 14:57:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B3FB64F18 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB4326B006C; Sat, 13 Mar 2021 09:57:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8AEE6B0071; Sat, 13 Mar 2021 09:57:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7B026B0072; Sat, 13 Mar 2021 09:57:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id BD92B6B006C for ; Sat, 13 Mar 2021 09:57:01 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 64C68180397B7 for ; Sat, 13 Mar 2021 14:57:01 +0000 (UTC) X-FDA: 77915153442.07.733AA16 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by imf08.hostedemail.com (Postfix) with ESMTP id 8865D83EFEE9 for ; Sat, 13 Mar 2021 12:24:01 +0000 (UTC) IronPort-SDR: SEDGf4v8M4BVd8Yc/HyYNwvjM/H653U+rA9gBj9VhN3RnSOgy5vuQbkkeXm60J6jvQGrufMEIH BJzuo0XxLJXg== X-IronPort-AV: E=McAfee;i="6000,8403,9921"; a="250300695" X-IronPort-AV: E=Sophos;i="5.81,245,1610438400"; d="scan'208";a="250300695" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2021 04:24:07 -0800 IronPort-SDR: oHZ6EF8VT4RCAr6fhA5r3GxuG9LlJ2AtiEoPuCNUL2WM69/1yzsyiX8zgxmhpW0eJmEwfYZXKR EogAJid+gX8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,245,1610438400"; d="scan'208";a="372944110" Received: from lkp-server02.sh.intel.com (HELO ce64c092ff93) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 13 Mar 2021 04:24:04 -0800 Received: from kbuild by ce64c092ff93 with local (Exim 4.92) (envelope-from ) id 1lL3JM-00021n-5x; Sat, 13 Mar 2021 12:24:04 +0000 Date: Sat, 13 Mar 2021 20:23:30 +0800 From: kernel test robot To: Yu Zhao , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, Alex Shi , Andrew Morton , Linux Memory Management List , Dave Hansen , Hillf Danton , Johannes Weiner , Joonsoo Kim , Matthew Wilcox , Mel Gorman Subject: Re: [PATCH v1 12/14] mm: multigenerational lru: user space interface Message-ID: <202103132018.8RBnL0OM-lkp@intel.com> References: <20210313075747.3781593-13-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210313075747.3781593-13-yuzhao@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: efdkkfqwe5rm4qxgqqbj73x8y1gypqbc X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8865D83EFEE9 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mga06.intel.com; client-ip=134.134.136.31 X-HE-DKIM-Result: none/none X-HE-Tag: 1615638241-899698 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/x86/core] [also build test WARNING on tip/x86/mm tip/sched/core linus/master v5.12-rc2] [cannot apply to cgroup/for-next tip/perf/core hnaz-linux-mm/master next-20210312] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Yu-Zhao/Multigenerational-LRU/20210313-160036 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git d0962f2b24c99889a386f0658c71535f56358f77 compiler: s390-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cppcheck possible warnings: (new ones prefixed by >>, may not real problems) mm/vmscan.c:4107:22: warning: Local variable kswapd shadows outer function [shadowFunction] struct task_struct *kswapd = NODE_DATA(nid)->kswapd; ^ mm/vmscan.c:3909:12: note: Shadowed declaration static int kswapd(void *p) ^ mm/vmscan.c:4107:22: note: Shadow variable struct task_struct *kswapd = NODE_DATA(nid)->kswapd; ^ vim +6140 mm/vmscan.c 6106 6107 static ssize_t lru_gen_debugfs_write(struct file *file, const char __user *src, 6108 size_t len, loff_t *pos) 6109 { 6110 void *buf; 6111 char *cur, *next; 6112 int err = 0; 6113 6114 buf = kvmalloc(len + 1, GFP_USER); 6115 if (!buf) 6116 return -ENOMEM; 6117 6118 if (copy_from_user(buf, src, len)) { 6119 kvfree(buf); 6120 return -EFAULT; 6121 } 6122 6123 next = buf; 6124 next[len] = '\0'; 6125 6126 while ((cur = strsep(&next, ",;\n"))) { 6127 int n; 6128 int end; 6129 char cmd; 6130 int memcg_id; 6131 int nid; 6132 unsigned long seq; 6133 int swappiness = -1; 6134 unsigned long nr_to_reclaim = -1; 6135 6136 cur = skip_spaces(cur); 6137 if (!*cur) 6138 continue; 6139 > 6140 n = sscanf(cur, "%c %u %u %lu %n %u %n %lu %n", &cmd, &memcg_id, &nid, 6141 &seq, &end, &swappiness, &end, &nr_to_reclaim, &end); 6142 if (n < 4 || cur[end]) { 6143 err = -EINVAL; 6144 break; 6145 } 6146 6147 err = advance_seq(cmd, memcg_id, nid, seq, swappiness, nr_to_reclaim); 6148 if (err) 6149 break; 6150 } 6151 6152 kvfree(buf); 6153 6154 return err ? : len; 6155 } 6156 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org