From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC32FC433E0 for ; Tue, 16 Mar 2021 21:38:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60D7F64F77 for ; Tue, 16 Mar 2021 21:38:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60D7F64F77 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E65436B0036; Tue, 16 Mar 2021 17:38:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E14466B006C; Tue, 16 Mar 2021 17:38:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB5796B006E; Tue, 16 Mar 2021 17:38:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id AC0636B0036 for ; Tue, 16 Mar 2021 17:38:01 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 74EF38249980 for ; Tue, 16 Mar 2021 21:38:01 +0000 (UTC) X-FDA: 77927050362.11.2FAE26E Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf22.hostedemail.com (Postfix) with ESMTP id E0DC9C0007D3 for ; Tue, 16 Mar 2021 21:38:00 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0524E64DF0; Tue, 16 Mar 2021 21:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615930678; bh=/Wp1VJrmKmqXE0oo2vwWwXpBvd/xhNubrkciEhZ7HwQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K63G76znfslp8HYsGmaz4/ruhH7TzA98kHXqHDymqpYVWjjPKjDpXBIgsBfACk7Jj tq1eAkNNy0bMOjqV7gqsAoM28VOc2is+KjhI2mwA4e9DeaWFcZUoP0ND7YINeNj75b MjVm3jvQo+izo2RgEgCePMkuIT0IUaErMJNadagNG+FWMp4VNfuzej7z8i+IxobrHj zed0lmXAcLZVQAsC+8JIEf5NHHnL3TkkIac2URecudCyxPtrwtRfQfILRUnSk2SmW5 CqUlWc7RQ7zYW5aSeFQ3ou3S7wXhTI3fRDinfsW4zBNgtuLyzJGKKhnd1c0O7wISWo YWv83UYNaeNrw== Date: Tue, 16 Mar 2021 14:37:56 -0700 From: Jakub Kicinski To: Jarvis Jiang Cc: davem@davemloft.net, rppt@linux.ibm.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, cchen50@lenovo.com, mpearson@lenovo.com Subject: Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem Message-ID: <20210316143756.45ef6d91@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210316124237.3469-1-jarvis.w.jiang@gmail.com> References: <20210316124237.3469-1-jarvis.w.jiang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E0DC9C0007D3 X-Stat-Signature: yscr4cmkc3n6jk4gpadfdnurq8p3kkou Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615930680-957845 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 16 Mar 2021 05:42:37 -0700 Jarvis Jiang wrote: > drivers/bus/mhi/devices/mhi_netdev.c | 1830 +++++++++++++ There's already a drivers/net/mhi/ Please make sure the drivers live in their respective subsystem. Virtio drivers don't sit under drivers/virtio, and most certainly not under drivers/bus/virtio... > drivers/bus/mhi/devices/mhi_satellite.c | 1155 +++++++++ > drivers/bus/mhi/devices/mhi_uci.c | 802 ++++++ Ugh, can you clarify what's the source of this code dump and if you're coordinating with others working on Qualcomm drivers?