From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD2AC433E0 for ; Thu, 18 Mar 2021 03:16:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD41764F20 for ; Thu, 18 Mar 2021 03:16:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD41764F20 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kingsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E5DC86B0070; Wed, 17 Mar 2021 23:16:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE71B6B0071; Wed, 17 Mar 2021 23:16:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C60CA6B0072; Wed, 17 Mar 2021 23:16:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id A5B186B0070 for ; Wed, 17 Mar 2021 23:16:00 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6654E3D0F for ; Thu, 18 Mar 2021 03:16:00 +0000 (UTC) X-FDA: 77931530880.11.2C429E6 Received: from mail.kingsoft.com (unknown [114.255.44.146]) by imf22.hostedemail.com (Postfix) with ESMTP id 45D62C0001EE for ; Thu, 18 Mar 2021 03:15:55 +0000 (UTC) X-AuditID: 0a580157-463ff70000021a79-a6-6052bf0b35bc Received: from mail.kingsoft.com (localhost [10.88.1.32]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.kingsoft.com (SMG-1-NODE-87) with SMTP id 9B.2F.06777.B0FB2506; Thu, 18 Mar 2021 10:46:35 +0800 (HKT) Received: from alex-virtual-machine (172.16.253.254) by KSBJMAIL2.kingsoft.cn (10.88.1.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 18 Mar 2021 11:15:51 +0800 Date: Thu, 18 Mar 2021 11:15:46 +0800 From: Aili Yao To: David Hildenbrand CC: , , , , , , Oscar Salvador , Mike Kravetz , Subject: Re: [PATCH] mm/gup: check page posion status for coredump. Message-ID: <20210318111546.4bda8c7a@alex-virtual-machine> In-Reply-To: <20a0d078-f49d-54d6-9f04-f6b41dd51e5f@redhat.com> References: <20210317163714.328a038d@alex-virtual-machine> <20a0d078-f49d-54d6-9f04-f6b41dd51e5f@redhat.com> Organization: kingsoft X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.253.254] X-ClientProxiedBy: KSBJMAIL1.kingsoft.cn (10.88.1.31) To KSBJMAIL2.kingsoft.cn (10.88.1.32) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsXCFcGooMu9PyjB4OAHJYs569ewWXxd/4vZ 4vKuOWwW99b8Z7X4uD/Y4mLjAUaLM9OKHNg9Nn2axO5xYsZvFo8XVzeyeHx8eovF4/2+q2we m09Xe3zeJBfAHsVlk5Kak1mWWqRvl8CV0fX0BmvBUvaKzjvrmRoY97J2MXJySAiYSOy495mx i5GLQ0hgOpPE7v2LmSGcV4wSczu3snQxcnCwCKhKHDivC9LABmTuujcLrFlEQENiU9sGsHpm gT4miY6VR1hAEsICzhKbj89kBrF5Bawkvj97zQ5icwrYSfz5dJARxBYSyJNY/GwpG4jNLyAm 0XvlPxPERfYSbVsWMUL0CkqcnPkEbCazgI7EiVXHmCFseYntb+cwQ8xRlDi85Bc7RK+SxJHu GWwQdqzEsnmvWCcwCs9CMmoWklGzkIxawMi8ipGlODfdcBMjJDbCdzDOa/qod4iRiYPxEKME B7OSCK9pXkCCEG9KYmVValF+fFFpTmrxIUZpDhYlcV6RKKCUQHpiSWp2ampBahFMlomDU6qB yc14wdWtbUWLVumlPGTOvHZJmlH6tmfmoxmL33tbdhWLTX6xxHLeU4u/2yZ+mHaW6bJVWpSm W1mWcI/t9skSKz3d0p3cNh+50hiYLhf6Rbeqbu7eQ+UdE8SXWcTmS1zMCvolk3s2TuWXRlvr p3jGd8E8V8KNJxTYGd76se+Oxs9H6QIMx+cpl24pmDf38M0vwfPemm+/pxzcbNt98kL/+aPX jGaFvFpzMdi80fLAseMn4j0ZuTo/yVz6/HX+s8PykalfpGax3Vfbe3pW07olBdxn1q6xm/r3 neOzrYmV37/vY7tuuzSqjeGfs+Uq5U7f9OkcYT3Fc0T1tq1+sEXDpVRra/Bxbd8wXvVHk6q/ 1iuxFGckGmoxFxUnAgBTk1IU/AIAAA== X-Stat-Signature: brej7qif6zax6wk9boayqzhcd8yc394t X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 45D62C0001EE Received-SPF: none (kingsoft.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail.kingsoft.com; client-ip=114.255.44.146 X-HE-DKIM-Result: none/none X-HE-Tag: 1616037355-712100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 17 Mar 2021 10:12:02 +0100 David Hildenbrand wrote: > > I wonder if a simple > > if (PageHWPoison(compound_head(page))) > ret = 0; > > won't suffice. But I guess the "issue" is compound pages that are not > huge pages or transparent huge pages. Yes, the simple case won't suffice, as we mark the hugetlb page poison in head, and other cases in the specific single page struct. > If not, we certainly want a wrapper for that magic, otherwise we have to > replicate the same logic all over the place. > > > + > > return (ret == 1) ? page : NULL; > > } > > #endif /* CONFIG_ELF_CORE */ > > > > Yes, May other places meet the requirements as the coredump meets, it's better to make a wrapper for this. But i am not familiar with the specific scenario, so this patch only cover the coredump case. I will post a v2 patch for this. -- Thanks! Aili Yao