From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9176C433DB for ; Thu, 18 Mar 2021 15:07:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D32664F1D for ; Thu, 18 Mar 2021 15:07:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D32664F1D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 662A46B0073; Thu, 18 Mar 2021 11:07:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 636566B0075; Thu, 18 Mar 2021 11:07:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D7918D0001; Thu, 18 Mar 2021 11:07:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id 31C9B6B0073 for ; Thu, 18 Mar 2021 11:07:31 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D757A8E78 for ; Thu, 18 Mar 2021 15:07:30 +0000 (UTC) X-FDA: 77933323860.35.066DCD6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id D1FA2C000C7E for ; Thu, 18 Mar 2021 15:07:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616080046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1/LrD+I/pla5Li7HJQKY+fP7jpet1+5dxXs7b6R+8aw=; b=eB9E/IQV4WeRVa9kwga5kMezUPh7OxpN9i4c7leinV18hAGgVh0w8XFrV1FGcxEF+IoTgO Grz1+ecev7Xfap3C0X10qLCgLpy7gT54RLr9vflhsa78yCcTApH0p9glW8llGsDG9yPch+ 4vKzYcJWROjBztfdd+VkWqMRdHlmdpg= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-106-_urEfbvHO0uV9p9sUAaXNg-1; Thu, 18 Mar 2021 11:07:24 -0400 X-MC-Unique: _urEfbvHO0uV9p9sUAaXNg-1 Received: by mail-qv1-f72.google.com with SMTP id dz17so29992131qvb.14 for ; Thu, 18 Mar 2021 08:07:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1/LrD+I/pla5Li7HJQKY+fP7jpet1+5dxXs7b6R+8aw=; b=USam6fVHj/BBuZWHw00x3qJRrwFqRR3WQWFxvG4QLNNVfJwuUCoEzxr6AqSOmGdQHM HGaNBKT4A8MFoXlSg5faztBH4rmiBeB80+pvJVg1bmm7o6ljj8ekLIlzZ7+gbek5LCuH 3Afhu4/vfWOO3oStR5qgR9CAutMVJhYQW5GFHhAfQeuI6UhAbKqQiVLuSttG+YB8dqbt SJS7UgDrGnW6uNFIzPZFk1cEvh9t7mobdFGETDUBRcZ122nem2qMX/UODkb9Tfh9PyYD LwwqckxDOTWLAcryscNs8CNDvMwEzvzqA2A6/8+UvsOy/SBLoGJCQ8C0KoiRqVJaQ4kk b3xw== X-Gm-Message-State: AOAM530y1VMhadgFLhIHKRjj/ASolxplJHqoyahVsuzC9vtv5jIum5LF VISnu/ltkmIydl6AdWXG5uJZIcL1nvmF5O013r9npoQFAXQQt2Ou25qei8x+EVUxn+xsttlStTk 13DD+t5PFqRs= X-Received: by 2002:a05:620a:110a:: with SMTP id o10mr4887497qkk.281.1616080043401; Thu, 18 Mar 2021 08:07:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxc2pygDzR+H4VqimhmOKQC0aDZ5rEfXPBH4NGN/DAGFsv6CKyGqkvVzT7bYv+X91M4O50KVQ== X-Received: by 2002:a05:620a:110a:: with SMTP id o10mr4887446qkk.281.1616080043110; Thu, 18 Mar 2021 08:07:23 -0700 (PDT) Received: from xz-x1 ([142.126.89.138]) by smtp.gmail.com with ESMTPSA id j3sm1946715qki.84.2021.03.18.08.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 08:07:22 -0700 (PDT) Date: Thu, 18 Mar 2021 11:07:20 -0400 From: Peter Xu To: Miaohe Lin Cc: akpm@linux-foundation.org, ziy@nvidia.com, willy@infradead.org, william.kucharski@oracle.com, vbabka@suse.cz, yulei.kernel@gmail.com, walken@google.com, aneesh.kumar@linux.ibm.com, rcampbell@nvidia.com, thomas_os@shipmail.org, yang.shi@linux.alibaba.com, richard.weiyang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 0/6] Some cleanups for huge_memory Message-ID: <20210318150720.GP395976@xz-x1> References: <20210318122722.13135-1-linmiaohe@huawei.com> MIME-Version: 1.0 In-Reply-To: <20210318122722.13135-1-linmiaohe@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D1FA2C000C7E X-Stat-Signature: ahagbgzethk3staj6h9o771msawjwphj Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616080046-927431 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 18, 2021 at 08:27:16AM -0400, Miaohe Lin wrote: > Hi all, > This series contains cleanups to rework some function logics to make it > more readable, use helper function and so on. More details can be found > in the respective changelogs. Thanks! > > v2->v3: > use ALIGN/ALIGN_DOWN too against HPAGE_PMD_SIZE per Peter. > > v1->v2: > rename try_to_split_huge_pmd_address and move up comments. > > Miaohe Lin (6): > mm/huge_memory.c: rework the function vma_adjust_trans_huge() > mm/huge_memory.c: make get_huge_zero_page() return bool > mm/huge_memory.c: rework the function do_huge_pmd_numa_page() slightly > mm/huge_memory.c: remove redundant PageCompound() check > mm/huge_memory.c: remove unused macro > TRANSPARENT_HUGEPAGE_DEBUG_COW_FLAG > mm/huge_memory.c: use helper function migration_entry_to_page() Reviewed-by: Peter Xu -- Peter Xu