From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97908C433E0 for ; Fri, 19 Mar 2021 10:31:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 054A364F6E for ; Fri, 19 Mar 2021 10:31:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 054A364F6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7CB056B0074; Fri, 19 Mar 2021 06:31:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77B436B007B; Fri, 19 Mar 2021 06:31:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 642AE6B007D; Fri, 19 Mar 2021 06:31:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 4C2B46B0074 for ; Fri, 19 Mar 2021 06:31:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 12DCA18041E83 for ; Fri, 19 Mar 2021 10:31:25 +0000 (UTC) X-FDA: 77936256930.01.F3761C5 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf18.hostedemail.com (Postfix) with ESMTP id 8D8F42000255 for ; Fri, 19 Mar 2021 10:31:24 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 88490AE05; Fri, 19 Mar 2021 10:31:23 +0000 (UTC) Date: Fri, 19 Mar 2021 11:31:21 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Michal Hocko , Anshuman Khandual , Vlastimil Babka , Pavel Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/5] mm,memory_hotplug: Allocate memmap from the added memory range Message-ID: <20210319103120.GB6868@linux> References: <20210319092635.6214-1-osalvador@suse.de> <20210319092635.6214-2-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8D8F42000255 X-Stat-Signature: uxex8xm9759yjn3r7idrqzisyo5iyhsq Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1616149884-380056 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 19, 2021 at 11:20:19AM +0100, David Hildenbrand wrote: > > +bool mhp_supports_memmap_on_memory(unsigned long size) > > +{ > > + unsigned long nr_vmemmap_pages = size / PAGE_SIZE; > > + unsigned long vmemmap_size = nr_vmemmap_pages * sizeof(struct page); > > + unsigned long remaining_size = size - vmemmap_size; > > + > > + /* > > + * Besides having arch support and the feature enabled at runtime, we > > + * need a few more assumptions to hold true: > > + * > > + * a) We span a single memory block: memory onlining/offlinin;g happens > > s/offlinin;g/offlining;/ Bleh, terrible :-( > IS_ALIGNED(remaining_size, pageblock_nr_pages << PAGE_SHIFT); Yaiks Hopefully Andrew can amend these two nits? > (another pair of eyes certainly wouldn't hurt :) ) definitely, but those are pricy as you may know :-D > Reviewed-by: David Hildenbrand Thanks a lot for the throughout review David, highly appreciated! -- Oscar Salvador SUSE L3