From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 224A9C433C1 for ; Sat, 20 Mar 2021 01:19:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 642B16195F for ; Sat, 20 Mar 2021 01:19:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 642B16195F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B391E6B0075; Fri, 19 Mar 2021 21:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE8E66B0078; Fri, 19 Mar 2021 21:19:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B13E6B0080; Fri, 19 Mar 2021 21:19:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id 7AC216B0075 for ; Fri, 19 Mar 2021 21:19:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3CC2F18027983 for ; Sat, 20 Mar 2021 01:19:15 +0000 (UTC) X-FDA: 77938494270.03.FF67E42 Received: from mail3-165.sinamail.sina.com.cn (mail3-165.sinamail.sina.com.cn [202.108.3.165]) by imf07.hostedemail.com (Postfix) with SMTP id 6F3ADA0009CD for ; Sat, 20 Mar 2021 01:19:13 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([124.64.68.206]) by sina.com (172.16.97.32) with ESMTP id 60554D8C000319C5; Sat, 20 Mar 2021 09:19:10 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 249589628870 From: Hillf Danton To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 7/8] hugetlb: add update_and_free_page_no_sleep for irq context Date: Sat, 20 Mar 2021 09:18:57 +0800 Message-Id: <20210320011857.2004-1-hdanton@sina.com> In-Reply-To: <20210319224209.150047-8-mike.kravetz@oracle.com> References: <20210319224209.150047-1-mike.kravetz@oracle.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6F3ADA0009CD X-Stat-Signature: fwcu8hzz3rmqdupa11ephiamy8114e4j Received-SPF: none (sina.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail3-165.sinamail.sina.com.cn; client-ip=202.108.3.165 X-HE-DKIM-Result: none/none X-HE-Tag: 1616203153-894362 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000075, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 19 Mar 2021 15:42:08 -0700 Mike Kravetz wrote: > + > + if (!can_sleep && free_page_may_sleep(h, page)) { > + /* > + * Send page freeing to workqueue > + * > + * Only call schedule_work() if hpage_freelist is previously > + * empty. Otherwise, schedule_work() had been called but the > + * workfn hasn't retrieved the list yet. > + */ > + if (llist_add((struct llist_node *)&page->mapping, > + &hpage_freelist)) > + schedule_work(&free_hpage_work); > + return; > + } Queue work on system_unbound_wq instead of system_wq because of blocking = work.