From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D915BC433DB for ; Mon, 22 Mar 2021 11:27:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 392CB6191F for ; Mon, 22 Mar 2021 11:27:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 392CB6191F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 135026B00B3; Mon, 22 Mar 2021 07:08:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E5B16B00B4; Mon, 22 Mar 2021 07:08:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E79F56B00B5; Mon, 22 Mar 2021 07:08:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id C9F946B00B3 for ; Mon, 22 Mar 2021 07:08:17 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2BE831801FA22 for ; Mon, 22 Mar 2021 11:27:08 +0000 (UTC) X-FDA: 77947283736.40.E1F5EC2 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf09.hostedemail.com (Postfix) with ESMTP id 927CA6000100 for ; Mon, 22 Mar 2021 11:27:07 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id o10so20661999lfb.9 for ; Mon, 22 Mar 2021 04:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Wfahuc/4FrKDMvX9RZ/+E+DVaHu+EE7CL6DE9+//ml0=; b=W/0O2nsBYq5ZzI5Y2K6tiA0U+Vcf5xqBG9/hGbwF73UE5fdrI6KzNreiefIsogp+qj cXSg85GgCuXFHCjemkKuoi7erPMcQiHreiV5s5uWVTpcSYsH96Z99CYlCJhhRRjaoxSN yTLRstwNrVDeuegg+v/xLsx3QsEJCa8ExQN2izI84K4rkQVXdWcWnh/z7EgLx+d2Gj4v KlLnpCsgCwRuVJI0aj/tFBp+YTkjQx0FW2CH2rIpZNSPE+ktNfEdni1/QLDfZ1W1BdAJ EMzt3I++yezG517Cs6AuXcooYDevc+dkbOTnHC341yzM0ARPNOKj445LyePnX0To7wF9 m2fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Wfahuc/4FrKDMvX9RZ/+E+DVaHu+EE7CL6DE9+//ml0=; b=qAH6AWIhh93cb2gcPfd66ZS03r+YkgpRHFcVI+Gg8kT09ZoFkE4JJ++w1mp74zo12S kSs3gnsQYBpo6DkAwQS6wKkLw4mMYdaJI4iKSv1pOy0GcW6LG4LTmPe0lq9zPY+jqxdU O6Zg/2i/l7sjoHXB1tHU1bU6vrtnN6LN5KTnk9SjIiXBpseQHMMy2ibpkFyg7kW6aA2n XK7k0ED5a6BHZVknvH9TYWiEs5VG0FGg18sDpuqufXR5kKd2NlW3jp5murhl0pbt1oSN UTqtC1OEK1C31DzEwYkiWFU+s0Kp4zi2vW0W6chje7s//UdYPAAMnezQZm0bi4WSHHbK 2TEA== X-Gm-Message-State: AOAM532PUllJfhDTO0wHoh0gEsUrm6feCaSmS/yG2UTO6WNPC43IYaKI Yy8BRzib3NmDPCYHxuma6xvdMA== X-Google-Smtp-Source: ABdhPJy4IdxcKDpK5GSmJnFhB/DWMG+MxhYZnGmWYx03PQEDC8gCv+MgnJiU2/rBF1HiU8PkWfw01Q== X-Received: by 2002:a19:521a:: with SMTP id m26mr8825738lfb.56.1616412425904; Mon, 22 Mar 2021 04:27:05 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id e15sm1541510lfs.83.2021.03.22.04.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 04:27:05 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id A8293101DEB; Mon, 22 Mar 2021 14:27:12 +0300 (+03) Date: Mon, 22 Mar 2021 14:27:12 +0300 From: "Kirill A. Shutemov" To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang Subject: Re: [PATCH v23 28/28] mm: Introduce PROT_SHSTK for shadow stack Message-ID: <20210322112712.di6vthmgrvu5znhv@box> References: <20210316151054.5405-1-yu-cheng.yu@intel.com> <20210316151054.5405-29-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316151054.5405-29-yu-cheng.yu@intel.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 927CA6000100 X-Stat-Signature: et1zfn7febyucahfy5gjsycs3az5h7dh Received-SPF: none (shutemov.name>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-lf1-f50.google.com; client-ip=209.85.167.50 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616412427-626022 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 16, 2021 at 08:10:54AM -0700, Yu-cheng Yu wrote: > There are three possible options to create a shadow stack allocation API: > an arch_prctl, a new syscall, or adding PROT_SHSTK to mmap()/mprotect(). > Each has its advantages and compromises. > > An arch_prctl() is the least intrusive. However, the existing x86 > arch_prctl() takes only two parameters. Multiple parameters must be > passed in a memory buffer. There is a proposal to pass more parameters in > registers [1], but no active discussion on that. > > A new syscall minimizes compatibility issues and offers an extensible frame > work to other architectures, but this will likely result in some overlap of > mmap()/mprotect(). > > The introduction of PROT_SHSTK to mmap()/mprotect() takes advantage of > existing APIs. The x86-specific PROT_SHSTK is translated to VM_SHSTK and > a shadow stack mapping is created without reinventing the wheel. There are > potential pitfalls though. The most obvious one would be using this as a > bypass to shadow stack protection. However, the attacker would have to get > to the syscall first. > > [1] https://lore.kernel.org/lkml/20200828121624.108243-1-hjl.tools@gmail.com/ > > Signed-off-by: Yu-cheng Yu > Reviewed-by: Kees Cook > --- > arch/x86/include/asm/mman.h | 57 +++++++++++++++++++++++++++++++- > arch/x86/include/uapi/asm/mman.h | 1 + > include/linux/mm.h | 1 + > mm/mmap.c | 8 ++++- > 4 files changed, 65 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/mman.h b/arch/x86/include/asm/mman.h > index 629f6c81263a..bd94e30b5d34 100644 > --- a/arch/x86/include/asm/mman.h > +++ b/arch/x86/include/asm/mman.h > @@ -20,11 +20,66 @@ > ((vm_flags) & VM_PKEY_BIT2 ? _PAGE_PKEY_BIT2 : 0) | \ > ((vm_flags) & VM_PKEY_BIT3 ? _PAGE_PKEY_BIT3 : 0)) > > -#define arch_calc_vm_prot_bits(prot, key) ( \ > +#define pkey_vm_prot_bits(prot, key) ( \ > ((key) & 0x1 ? VM_PKEY_BIT0 : 0) | \ > ((key) & 0x2 ? VM_PKEY_BIT1 : 0) | \ > ((key) & 0x4 ? VM_PKEY_BIT2 : 0) | \ > ((key) & 0x8 ? VM_PKEY_BIT3 : 0)) > +#else > +#define pkey_vm_prot_bits(prot, key) (0) > +#endif > + > +static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot, > + unsigned long pkey) > +{ > + unsigned long vm_prot_bits = pkey_vm_prot_bits(prot, pkey); > + > + if (!(prot & PROT_WRITE) && (prot & PROT_SHSTK)) > + vm_prot_bits |= VM_SHSTK; > + > + return vm_prot_bits; > +} > + > +#define arch_calc_vm_prot_bits(prot, pkey) arch_calc_vm_prot_bits(prot, pkey) > + > +#ifdef CONFIG_X86_CET > +static inline bool arch_validate_prot(unsigned long prot, unsigned long addr) > +{ > + unsigned long valid = PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM; > + > + if (prot & ~(valid | PROT_SHSTK)) Why PROT_SHSTK is not part of valid? > + return false; > + > + if (prot & PROT_SHSTK) { > + struct vm_area_struct *vma; > + > + if (!current->thread.cet.shstk_size) > + return false; > + > + /* > + * A shadow stack mapping is indirectly writable by only > + * the CALL and WRUSS instructions, but not other write > + * instructions). PROT_SHSTK and PROT_WRITE are mutually > + * exclusive. > + */ > + if (prot & PROT_WRITE) > + return false; > + > + vma = find_vma(current->mm, addr); > + if (!vma) > + return false; NAK. This is racy. arch_validate_prot() called outside of mmap_lock and the vma may be freed or modified under us. do_mprotect_pkey() already calls find_vma() with the right locking. Maybe re-strucure do_mprotect_pkey() to call arch_validate_prot() after find_vma() and pass down the vma? > + > + /* > + * Shadow stack cannot be backed by a file or shared. > + */ > + if (vma->vm_file || (vma->vm_flags & VM_SHARED)) > + return false; > + } > + > + return true; > +} > + > +#define arch_validate_prot arch_validate_prot > #endif > > #endif /* _ASM_X86_MMAN_H */ > diff --git a/arch/x86/include/uapi/asm/mman.h b/arch/x86/include/uapi/asm/mman.h > index 3ce1923e6ed9..39bb7db344a6 100644 > --- a/arch/x86/include/uapi/asm/mman.h > +++ b/arch/x86/include/uapi/asm/mman.h > @@ -4,6 +4,7 @@ > > #define MAP_32BIT 0x40 /* only give out 32bit addresses */ > > +#define PROT_SHSTK 0x10 /* shadow stack pages */ > > #include > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index e178be052419..40c4b0fe7cc4 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -342,6 +342,7 @@ extern unsigned int kobjsize(const void *objp); > > #if defined(CONFIG_X86) > # define VM_PAT VM_ARCH_1 /* PAT reserves whole VMA at once (x86) */ > +# define VM_ARCH_CLEAR VM_SHSTK > #elif defined(CONFIG_PPC) > # define VM_SAO VM_ARCH_1 /* Strong Access Ordering (powerpc) */ > #elif defined(CONFIG_PARISC) > diff --git a/mm/mmap.c b/mm/mmap.c > index 99077171010b..934cb3cbe952 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1481,6 +1481,12 @@ unsigned long do_mmap(struct file *file, unsigned long addr, > struct inode *inode = file_inode(file); > unsigned long flags_mask; > > + /* > + * Call stack cannot be backed by a file. > + */ > + if (vm_flags & VM_SHSTK) > + return -EINVAL; > + > if (!file_mmap_ok(file, inode, pgoff, len)) > return -EOVERFLOW; > > @@ -1545,7 +1551,7 @@ unsigned long do_mmap(struct file *file, unsigned long addr, > } else { > switch (flags & MAP_TYPE) { > case MAP_SHARED: > - if (vm_flags & (VM_GROWSDOWN|VM_GROWSUP)) > + if (vm_flags & (VM_GROWSDOWN|VM_GROWSUP|VM_SHSTK)) > return -EINVAL; > /* > * Ignore pgoff. > -- > 2.21.0 > -- Kirill A. Shutemov