From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] cachefiles, afs: mm wait fixes
Date: Tue, 23 Mar 2021 12:08:29 +0000 [thread overview]
Message-ID: <20210323120829.GC1719932@casper.infradead.org> (raw)
In-Reply-To: <161650040278.2445805.7652115256944270457.stgit@warthog.procyon.org.uk>
On Tue, Mar 23, 2021 at 11:53:22AM +0000, David Howells wrote:
>
> Here are some patches to fix page waiting-related issues in cachefiles and
> afs[1]:
>
> (1) In cachefiles, remove the use of the wait_bit_key struct to access
> something that's actually in wait_page_key format. The proper struct
> is now available in the header, so that should be used instead.
>
> (2) Add a proper wait function for waiting killably on the page writeback
> flag. This includes a recent bugfix here (presumably commit
> c2407cf7d22d0c0d94cf20342b3b8f06f1d904e7).
>
> (3) In afs, use the function added in (2) rather than using
> wait_on_page_bit_killable() which doesn't have the aforementioned
> bugfix.
>
> Note that I modified this to work with the upstream code where the
> page pointer isn't cached in a local variable.
Thanks, the minor modifications to the patches (changelogs, fixes to apply
to upstream) all look good to me.
prev parent reply other threads:[~2021-03-23 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 11:53 [PATCH 0/3] cachefiles, afs: mm wait fixes David Howells
2021-03-23 11:53 ` [PATCH 1/3] fs/cachefiles: Remove wait_bit_key layout dependency David Howells
2021-03-23 11:53 ` [PATCH 2/3] mm/writeback: Add wait_on_page_writeback_killable David Howells
2021-03-23 11:53 ` [PATCH 3/3] afs: Use wait_on_page_writeback_killable David Howells
2021-03-23 12:08 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323120829.GC1719932@casper.infradead.org \
--to=willy@infradead.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).