From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83E58C433DB for ; Tue, 23 Mar 2021 15:43:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0822A619BD for ; Tue, 23 Mar 2021 15:43:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0822A619BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 623936B0246; Tue, 23 Mar 2021 11:43:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D2F96B024A; Tue, 23 Mar 2021 11:43:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44CF16B024B; Tue, 23 Mar 2021 11:43:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 256266B0246 for ; Tue, 23 Mar 2021 11:43:29 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D9015180AD820 for ; Tue, 23 Mar 2021 15:43:28 +0000 (UTC) X-FDA: 77951558496.17.855C17A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 30709407F8DF for ; Tue, 23 Mar 2021 15:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616514207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQwwd9nOnJe1+uHPoxzHuoEj26bQew0s4XHSj0Ikdsw=; b=TIUwj4R/aG2m0yzlzhx/IWm2y0neUKMKN/K7EhcC008P32Tj0Em9wjue0vtc4OeEKRhj6X Ln3/wWG6jGA3NMsPHAGGxsVIqxzJhLsroVB6K6cHMxTFUxtW0MRGrx490OfMYJ6u7HtuPm ZVep5nlmc30LV1ZCxqgYR1LhMcqx1rE= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-WmglAfexNV-NMW8iMeCmXg-1; Tue, 23 Mar 2021 11:43:23 -0400 X-MC-Unique: WmglAfexNV-NMW8iMeCmXg-1 Received: by mail-qv1-f70.google.com with SMTP id k4so1868499qvf.8 for ; Tue, 23 Mar 2021 08:43:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fQwwd9nOnJe1+uHPoxzHuoEj26bQew0s4XHSj0Ikdsw=; b=PuxEfIy69FrwQkJFDsimcOPb7F+Pu05xCLJMH6Xw2d5r3hpXuzoy35fKCJVRKMOj1n 6XenlyXeLCEZJdw20k25hsXASMwweRLBsCWXOEH99RFjQndpjVVvgHEC8vQfNFeJqIwx znkzXTdwSSZbseofKeVRZgfRPisWxWFQj9ADHAaBX1itt4kZZtbw8af0DO+vK9S0yL2E L1JltEXTJwvfqgA1AfXYXVgyHculGcQUXYVd6cwPea8tI3+3Zf8iBgadBkEqUT1f5R3D aZdDlg6cOgIZl1Stwbqq1derJyOM2NNX51hByT62UwaSmf7Ik7N1UjeJH3U9L0nQv7bC +Eeg== X-Gm-Message-State: AOAM530wRAeeuFUOXn2l59oONbG5B8MmUfWu+Q7aG3dKRwg1VubVRc5x rQmJmB8AK7FckXezxDxMyG4ZYK4ox8I3NdPeh9ZL8G6fRK5dKXe1j8MXeGFWZ0T+bmNp5BOv8Qy iYdJb0DguHck= X-Received: by 2002:a05:620a:981:: with SMTP id x1mr5807035qkx.501.1616514203216; Tue, 23 Mar 2021 08:43:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJym/kQ1w5u7o1QHL31laqkymPkn/C2lVnlgp1kv4esRLoT59gBX0FFLLopujlqx2vELTjFLBA== X-Received: by 2002:a05:620a:981:: with SMTP id x1mr5807023qkx.501.1616514203017; Tue, 23 Mar 2021 08:43:23 -0700 (PDT) Received: from xz-x1 (bras-base-toroon474qw-grc-82-174-91-135-175.dsl.bell.ca. [174.91.135.175]) by smtp.gmail.com with ESMTPSA id z14sm10958800qti.87.2021.03.23.08.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 08:43:22 -0700 (PDT) Date: Tue, 23 Mar 2021 11:43:21 -0400 From: Peter Xu To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Kirill A . Shutemov" , Jerome Glisse , Mike Kravetz , Andrew Morton , Axel Rasmussen , Hugh Dickins , Nadav Amit , Andrea Arcangeli , Mike Rapoport Subject: Re: [PATCH 07/23] mm: Introduce zap_details.zap_flags Message-ID: <20210323154321.GG6486@xz-x1> References: <20210323004912.35132-1-peterx@redhat.com> <20210323004912.35132-8-peterx@redhat.com> <20210323021129.GZ1719932@casper.infradead.org> MIME-Version: 1.0 In-Reply-To: <20210323021129.GZ1719932@casper.infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: 5jfwozigohskqzkiedtyx54fkpzs1eua X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 30709407F8DF Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616514207-7824 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 23, 2021 at 02:11:29AM +0000, Matthew Wilcox wrote: > On Mon, Mar 22, 2021 at 08:48:56PM -0400, Peter Xu wrote: > > +/* Whether to check page->mapping when zapping */ > > +#define ZAP_FLAG_CHECK_MAPPING BIT(0) > > + > > /* > > * Parameter block passed down to zap_pte_range in exceptional cases. > > */ > > struct zap_details { > > - struct address_space *check_mapping; /* Check page->mapping if set */ > > + struct address_space *zap_mapping; /* Check page->mapping if set */ > > Now the comment is wrong. It used to mean "If this is NULL, zap pages > with any mapping", but now it's always set, and the decision about whether > to check the mapping is in the flag. > > Honestly, I'd remove the comments from both these members. They don't add > anything to understandability now. Agreed, I'm removing them. Thanks, -- Peter Xu