linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sparc32: add stub pud_page define for walking huge vmalloc page tables
@ 2021-03-24 23:28 Nicholas Piggin
  2021-03-24 23:32 ` David Miller
  2021-03-25 21:17 ` Stephen Rothwell
  0 siblings, 2 replies; 3+ messages in thread
From: Nicholas Piggin @ 2021-03-24 23:28 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Nicholas Piggin, David S. Miller, sparclinux, linux-mm, Stephen Rothwell

Similarly to the stub p4d_page in sparc64, add a stub pud_page, this
is needed for hugepages in the vmap page tables to be walked without
ifdefs, which should be no functional change for sparc32.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---

This should go in Andrew's mm tree which has a compile error on sparc32
introduced by the huge vmalloc pages, noticed by Stephen.

Thanks,
Nick

 arch/sparc/include/asm/pgtable_32.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h
index 632cdb959542..a5cf79c149fe 100644
--- a/arch/sparc/include/asm/pgtable_32.h
+++ b/arch/sparc/include/asm/pgtable_32.h
@@ -321,6 +321,9 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)
 		pgprot_val(newprot));
 }
 
+/* only used by the huge vmap code, should never be called */
+#define pud_page(pud)			NULL
+
 struct seq_file;
 void mmu_info(struct seq_file *m);
 
-- 
2.23.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sparc32: add stub pud_page define for walking huge vmalloc page tables
  2021-03-24 23:28 [PATCH] sparc32: add stub pud_page define for walking huge vmalloc page tables Nicholas Piggin
@ 2021-03-24 23:32 ` David Miller
  2021-03-25 21:17 ` Stephen Rothwell
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2021-03-24 23:32 UTC (permalink / raw)
  To: npiggin; +Cc: akpm, sparclinux, linux-mm, sfr

From: Nicholas Piggin <npiggin@gmail.com>
Date: Thu, 25 Mar 2021 09:28:25 +1000

> Similarly to the stub p4d_page in sparc64, add a stub pud_page, this
> is needed for hugepages in the vmap page tables to be walked without
> ifdefs, which should be no functional change for sparc32.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Acked-by: David S. Miller <davem@davemloft.net>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sparc32: add stub pud_page define for walking huge vmalloc page tables
  2021-03-24 23:28 [PATCH] sparc32: add stub pud_page define for walking huge vmalloc page tables Nicholas Piggin
  2021-03-24 23:32 ` David Miller
@ 2021-03-25 21:17 ` Stephen Rothwell
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2021-03-25 21:17 UTC (permalink / raw)
  To: Nicholas Piggin; +Cc: Andrew Morton, David S. Miller, sparclinux, linux-mm

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

Hi all,

On Thu, 25 Mar 2021 09:28:25 +1000 Nicholas Piggin <npiggin@gmail.com> wrote:
>
> Similarly to the stub p4d_page in sparc64, add a stub pud_page, this
> is needed for hugepages in the vmap page tables to be walked without
> ifdefs, which should be no functional change for sparc32.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> 
> This should go in Andrew's mm tree which has a compile error on sparc32
> introduced by the huge vmalloc pages, noticed by Stephen.
> 
> Thanks,
> Nick
> 
>  arch/sparc/include/asm/pgtable_32.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h
> index 632cdb959542..a5cf79c149fe 100644
> --- a/arch/sparc/include/asm/pgtable_32.h
> +++ b/arch/sparc/include/asm/pgtable_32.h
> @@ -321,6 +321,9 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)
>  		pgprot_val(newprot));
>  }
>  
> +/* only used by the huge vmap code, should never be called */
> +#define pud_page(pud)			NULL
> +
>  struct seq_file;
>  void mmu_info(struct seq_file *m);
>  
> -- 
> 2.23.0
> 

I have used this instead of my hack fix in linux-next today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-25 21:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 23:28 [PATCH] sparc32: add stub pud_page define for walking huge vmalloc page tables Nicholas Piggin
2021-03-24 23:32 ` David Miller
2021-03-25 21:17 ` Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).