From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] sparc32: add stub pud_page define for walking huge vmalloc page tables
Date: Fri, 26 Mar 2021 08:17:25 +1100 [thread overview]
Message-ID: <20210326081725.01d50c91@canb.auug.org.au> (raw)
In-Reply-To: <20210324232825.1157363-1-npiggin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
Hi all,
On Thu, 25 Mar 2021 09:28:25 +1000 Nicholas Piggin <npiggin@gmail.com> wrote:
>
> Similarly to the stub p4d_page in sparc64, add a stub pud_page, this
> is needed for hugepages in the vmap page tables to be walked without
> ifdefs, which should be no functional change for sparc32.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>
> This should go in Andrew's mm tree which has a compile error on sparc32
> introduced by the huge vmalloc pages, noticed by Stephen.
>
> Thanks,
> Nick
>
> arch/sparc/include/asm/pgtable_32.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h
> index 632cdb959542..a5cf79c149fe 100644
> --- a/arch/sparc/include/asm/pgtable_32.h
> +++ b/arch/sparc/include/asm/pgtable_32.h
> @@ -321,6 +321,9 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)
> pgprot_val(newprot));
> }
>
> +/* only used by the huge vmap code, should never be called */
> +#define pud_page(pud) NULL
> +
> struct seq_file;
> void mmu_info(struct seq_file *m);
>
> --
> 2.23.0
>
I have used this instead of my hack fix in linux-next today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-03-25 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 23:28 [PATCH] sparc32: add stub pud_page define for walking huge vmalloc page tables Nicholas Piggin
2021-03-24 23:32 ` David Miller
2021-03-25 21:17 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326081725.01d50c91@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).