From: Uladzislau Rezki <urezki@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Matthew Wilcox <willy@infradead.org>,
Colin King <colin.king@canonical.com>,
Nicholas Piggin <npiggin@gmail.com>,
linux-mm@kvack.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] mm/vmalloc: Fix read of pointer area after it has been free'd
Date: Mon, 29 Mar 2021 20:30:36 +0200 [thread overview]
Message-ID: <20210329183036.GA22667@pc638.lan> (raw)
In-Reply-To: <20210329181453.GA13467@pc638.lan>
On Mon, Mar 29, 2021 at 08:14:53PM +0200, Uladzislau Rezki wrote:
> On Mon, Mar 29, 2021 at 07:40:29PM +0200, Uladzislau Rezki wrote:
> > On Mon, Mar 29, 2021 at 06:14:34PM +0100, Matthew Wilcox wrote:
> > > On Mon, Mar 29, 2021 at 06:07:30PM +0100, Colin King wrote:
> > > > From: Colin Ian King <colin.king@canonical.com>
> > > >
> > > > Currently the memory pointed to by area is being freed by the
> > > > free_vm_area call and then area->nr_pages is referencing the
> > > > free'd object. Fix this swapping the order of the warn_alloc
> > > > message and the free.
> > > >
> > > > Addresses-Coverity: ("Read from pointer after free")
> > > > Fixes: 014ccf9b888d ("mm/vmalloc: improve allocation failure error messages")
> > >
> > > i don't have this git sha. if this is -next, the sha ids aren't stable
> > > and shouldn't be referenced in commit logs, because these fixes should
> > > just be squashed into the not-yet-upstream commits.
> > >
> > > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > > ---
> > > > mm/vmalloc.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> > > > index b73e4e715e0d..7936405749e4 100644
> > > > --- a/mm/vmalloc.c
> > > > +++ b/mm/vmalloc.c
> > > > @@ -2790,11 +2790,11 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
> > > > }
> > > >
> > > > if (!pages) {
> > > > - free_vm_area(area);
> > > > warn_alloc(gfp_mask, NULL,
> > > > "vmalloc size %lu allocation failure: "
> > > > "page array size %lu allocation failed",
> > > > area->nr_pages * PAGE_SIZE, array_size);
> > > > + free_vm_area(area);
> > > > return NULL;
> > >
> > > this fix looks right to me.
> > >
> > That is from the linux-next. Same to me.
> >
> > Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> >
> > --
> > Vlad Rezki
> Is the linux-next(next-20210329) broken?
>
Please ignore my previous email. That was due to my local "stashed" change.
--
Vlad Rezki
next prev parent reply other threads:[~2021-03-29 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 17:07 [PATCH][next] mm/vmalloc: Fix read of pointer area after it has been free'd Colin King
2021-03-29 17:14 ` Matthew Wilcox
2021-03-29 17:40 ` Uladzislau Rezki
2021-03-29 18:14 ` Uladzislau Rezki
2021-03-29 18:30 ` Uladzislau Rezki [this message]
2021-03-29 19:32 ` Uladzislau Rezki
2021-03-30 9:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329183036.GA22667@pc638.lan \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).