From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 360DDC433C1 for ; Tue, 30 Mar 2021 18:15:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B636261996 for ; Tue, 30 Mar 2021 18:15:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B636261996 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 325C06B007D; Tue, 30 Mar 2021 14:15:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D5996B0081; Tue, 30 Mar 2021 14:15:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19E5B6B0082; Tue, 30 Mar 2021 14:15:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 00FE06B007D for ; Tue, 30 Mar 2021 14:15:00 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ACFE1181AEF23 for ; Tue, 30 Mar 2021 18:15:00 +0000 (UTC) X-FDA: 77977341960.12.D74841B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id D2BBDE0001B4 for ; Tue, 30 Mar 2021 18:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EmF3w0hVBC+ZHp4W/qPPZe6sZHzkhbeBfjQ3MKRFYro=; b=EDlR7dilO/eQopvezzwA0Q1ZSO k6zRfW5EHL+XY4O3DIZJLbIw+0cOGxCL4xjdCug1AP7C/FfC1RGqRrZzp6Y+Z+6qRN/QvI3EAks9o GCR4FdtUhTB7HFfoBSiRdTijILL1hSSkZohmFXlZrOTSh5F3XQoTjXPrKP2iJ0qMp7l+uG0oSmsH9 Hw3SeDTRSXzH1cekN49tXNAe8p6ksHxH6pa25wyc/DhzN4WlFFCFnN6Wgf+Khj8+9XGfx9WMMuoub DDxXTamO/qb++ckAHrRmjvp/RMEkfE3l9n86dhsAdTu9aAD2MDW802leWhcAHHpYsdayrNzCTow1Z j2is8msQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lRIs7-003Px1-Aq; Tue, 30 Mar 2021 18:13:51 +0000 Date: Tue, 30 Mar 2021 19:13:47 +0100 From: Matthew Wilcox To: Mike Rapoport Cc: Andrew Morton , Greentime Hu , Huang Ying , Mike Rapoport , Nick Hu , Vincent Chen , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] nds32: flush_dcache_page: use page_mapping_file to avoid races with swapoff Message-ID: <20210330181347.GQ351017@casper.infradead.org> References: <20210330175126.26500-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330175126.26500-1-rppt@kernel.org> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D2BBDE0001B4 X-Stat-Signature: hpbanycme54h5ay8omfbigzkcn5roi78 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617128097-860015 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 30, 2021 at 08:51:26PM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > Commit cb9f753a3731 ("mm: fix races between swapoff and flush dcache") > updated flush_dcache_page implementations on several architectures to use > page_mapping_file() in order to avoid races between page_mapping() and > swapoff(). > > This update missed arch/nds32 and there is a possibility of a race there. > > Replace page_mapping() with page_mapping_file() in nds32 implementation of > flush_dcache_page(). > > Fixes: cb9f753a3731 ("mm: fix races between swapoff and flush dcache") > Signed-off-by: Mike Rapoport Reviewed-by: Matthew Wilcox (Oracle)