From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60900C433B4 for ; Thu, 1 Apr 2021 06:59:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D448A60FEA for ; Thu, 1 Apr 2021 06:59:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D448A60FEA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 698896B0080; Thu, 1 Apr 2021 02:59:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 648806B0081; Thu, 1 Apr 2021 02:59:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C3D86B0082; Thu, 1 Apr 2021 02:59:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 317426B0080 for ; Thu, 1 Apr 2021 02:59:07 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E5AC98249980 for ; Thu, 1 Apr 2021 06:59:06 +0000 (UTC) X-FDA: 77982896292.06.5B4DB6B Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf17.hostedemail.com (Postfix) with ESMTP id 6285A40002C4 for ; Thu, 1 Apr 2021 06:59:05 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id w10so966642pgh.5 for ; Wed, 31 Mar 2021 23:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fcskQaTmFb+0fkW2jo5lLy1NvjqxJI8ndRFO1CrEEC8=; b=JIn3UmAuLWVAwbXYRQ2p9135ooYRvhq6XPnebpW6ndXbwgBjn47e/yLy0eXYEhD8lc SchKs1SIQDNOeEltHPecTpf8DEOZuRbA0waQS+g8cbHhlDk2nAc6S502hVY6qRXqXRQO O+eMWVxnHFbhz5J/t/a+vD8RxouVx5bzj2Yw4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fcskQaTmFb+0fkW2jo5lLy1NvjqxJI8ndRFO1CrEEC8=; b=ZvE+Q92rDks9c2713r087OG7hCIvbEDGLkEbMcr7GkBsGbkuQb57Z0JgU5SgQuk6Im IBWuL3lcTye4IESWVnx87BAHDW90VSFWXnI0eaIFhdGmxxYwRbQlyBsWhvQI4uB4J52V hOYNtZpFstIuMTU1G4HJ5PksYsFZQihjHTeA+kJQWdIWmGBgAPp+MvwXRTZJo0qR1tjE MXxilbOQF+UYdkf1LcDJYdco+qjy9u041UFtY8F5KwFNV6KTxrB+RpHRWP4dL00fjwIp 1Mn4/EK89aTundM71S+wnMtXP64uY2Dpc8H3C0VfNAVcLREh0mrBAhLDp2brMrhp7pdN 03Nw== X-Gm-Message-State: AOAM531u7OKffx1PK5MmOgNkWXArKui3rn+KM6A+CwzpxlsTclPspfgU jhLhPHOHC9XNQlezhF63R6SStw== X-Google-Smtp-Source: ABdhPJxO26E+wLwimiSl2XR2zKGbqsBLKvk6R45Ovscf7tTQfW37ULIBGC2jr8qWGgTnPvDPm6LIyA== X-Received: by 2002:a63:6683:: with SMTP id a125mr6149517pgc.382.1617260345487; Wed, 31 Mar 2021 23:59:05 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f2sm3961559pfe.177.2021.03.31.23.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 23:59:04 -0700 (PDT) Date: Wed, 31 Mar 2021 23:59:03 -0700 From: Kees Cook To: Nathan Chancellor Cc: kernel test robot , Greg Kroah-Hartman , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Andrew Morton , Linux Memory Management List , "Rafael J. Wysocki" , Michal Hocko , Alexey Dobriyan , Lee Duncan , Chris Leech , Adam Nichols Subject: Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer Message-ID: <202103312354.A15E2A808@keescook> References: <20210401022145.2019422-1-keescook@chromium.org> <202104011400.HiuLgSvb-lkp@intel.com> <20210401064753.6ub6dhcuu6zuhdjq@archlinux-ax161> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401064753.6ub6dhcuu6zuhdjq@archlinux-ax161> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6285A40002C4 X-Stat-Signature: es7t3ef8qs54ngub5sy4mrowe8j89jwy Received-SPF: none (chromium.org>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mail-pg1-f175.google.com; client-ip=209.85.215.175 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617260345-296511 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 31, 2021 at 11:47:53PM -0700, Nathan Chancellor wrote: > On Thu, Apr 01, 2021 at 02:41:37PM +0800, kernel test robot wrote: > > Hi Kees, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on driver-core/driver-core-testing] > > [also build test WARNING on kees/for-next/pstore v5.12-rc5 next-20210331] > > [cannot apply to hnaz-linux-mm/master] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch] > > > > url: https://github.com/0day-ci/linux/commits/Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git d225ef6fda7ce9ff7d28764bd1cceea2d0215e8b > > config: powerpc-randconfig-r001-20210401 (attached as .config) > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c268a8ff4e90a85d0e634350b1104080614cf2b) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # install powerpc cross compiling tool for clang build > > # apt-get install binutils-powerpc-linux-gnu > > # https://github.com/0day-ci/linux/commit/c80ca56c15314908ebc1881678da3b36e007a2f4 > > git remote add linux-review https://github.com/0day-ci/linux > > git fetch --no-tags linux-review Kees-Cook/sysfs-Unconditionally-use-vmalloc-for-buffer/20210401-102455 > > git checkout c80ca56c15314908ebc1881678da3b36e007a2f4 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >> fs/sysfs/file.c:52:14: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > return NULL + !*ppos; > > ~~~~ ^ > > 1 warning generated. > > > > Arnd addressed other warnings of this nature in this patch: > > https://lore.kernel.org/r/20201028151202.3074398-1-arnd@kernel.org/ Ah! Yeah, I copied exactly that clever idiom that Arnd fixed. :) > which it seems never got picked up :( Greg, are you able to pick this up too? (Yeow, sent in October!) (Or I could respin and send them as a series?) -- Kees Cook